[Phpmyadmin-devel] about long lines

[Marc Delisle]

Le 2012-06-12 13:29, Chanaka Dharmarathna a écrit :
> On Tue, Jun 12, 2012 at 6:18 PM, Marc Delisle <marc at infomarc.info> wrote:
> 
>> Chanaka,
>>
>> about your question on long lines, I agree with you that this could be
>> put on two lines. Suggestion:
>>
>> if ((PMA_strlen($wktval) > $GLOBALS['cfg']['LimitChars'])
>>    && ($_SESSION['tmp_user_values']['display_text'] ==
>>        self::DISPLAY_PARTIAL_TEXT)
>> ) {
>>
>> --
>> Marc Delisle
>> http://infomarc.info
>>
>>
> Hi Marc,
> 
> Thanks for your suggestion.
> I check whether it works or not before also.
> 
> But code sniffer gives following errors,
> | ERROR   | Multi-line IF statement not indented correctly; expected 20
> spaces but found 24

The code sniffer does not like the additional indenting of "self", so
align it under "&&".

> | ERROR   | Each line in a multi-line IF statement must begin with a
> boolean operator

Maybe move the "==" under the "&&".

> 
> Sorry if I'm doing any wrong. Can you please tell any guesses why I'm
> getting these errors ?
> 
> Regards !



-- 
Marc Delisle
http://infomarc.info

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: OpenPGP digital signature
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20120613/442ad555/attachment.sig>