[Phpmyadmin-devel] GSoC: Refactoring Table search, Db search, Multi-table query

[Marc Delisle]

Le 2012-05-15 09:42, Atul Pratap Singh a écrit :
> On Wed, May 9, 2012 at 2:28 AM, Atul Pratap Singh <
> atulpratapsingh05 at gmail.com> wrote:
> 
>>
>>
>> On Wed, May 9, 2012 at 1:57 AM, Marc Delisle <marc at infomarc.info> wrote:
>>
>>> Le 2012-05-08 16:18, Atul Pratap Singh a écrit :
>>>> On Tue, May 8, 2012 at 3:24 PM, Marc Delisle <marc at infomarc.info>
>>> wrote:
>>>>
>>>>> Le 2012-05-08 02:44, Atul Pratap Singh a écrit :
>>>>> (...)
>>>>>>
>>>>>> So, to move HTML to lib/include files, slicing proper reusable HTML
>>>>> blocks
>>>>>> from the script should be done, followed by moving it to a lib/include
>>>>>> file, and then calling the include file at proper places. Is this the
>>>>> way,
>>>>>> I should proceed ?
>>>>>>
>>>>>
>>>>> Hi Atul,
>>>>> it depends: do you plan to create a class for this, or use global
>>>>> functions?
>>>>>
>>>>
>>>> For an example using a class, look at libraries/Menu.class.php. The
>>>>> _getBreadcrumbs() function returns some HTML and is called afterwards
>>>>> with an "echo".
>>>>>
>>>>> You should have just one library file that will contain all your
>>>>> refactored functions for tbl_select.php.
>>>>>
>>>>> Marc, yes I would like to form a class. As there is already a library
>>> for
>>>> "tbl_select.php" i.e. "tbl_select.lib.php" and it contains some
>>> functions,
>>>> Should I refactor it and convert it into a class file for
>>> "tbl_select.php"
>>>> and "tbl_zoom_select.php" ?
>>>>
>>>
>>> Yes, good idea.
>>>
>> Thanks Marc, will show you a few commits in a day or two :).
>>
> Hi Marc,
> Sorry for the delay. I have done some refactoring in tbl_select.php. Part
> of the script responsible for displaying table search form(which was
> earlier done using HTML-PHP mix) has now been converted into functions
> displaying HTML. Please checkout [0].
> 
> [0]
> https://github.com/zixtor/phpmyadmin/commit/36d56fb2ea56e47b3979cfb07ff3ad5a1b4f1b2f

Thanks Atul, I started to have a look and added my comments directly to
github.

-- 
Marc Delisle
http://infomarc.info

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: OpenPGP digital signature
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20120515/e58acf7d/attachment.sig>