[Phpmyadmin-devel] Refactoring: Displaying query results

Chanaka Dharmarathna pe.chanaka.ck at gmail.com
Wed May 23 15:17:18 CEST 2012

On 5/23/12, Michal Čihař <michal at cihar.com> wrote:
> Hi
> Dne Wed, 23 May 2012 15:55:38 +0530
> Chanaka Dharmarathna <pe.chanaka.ck at gmail.com> napsal(a):
>> I have updated my blog[0] with the updated design.
>> The file should be named as DisplayResults.class.php right ?
>> If you are okay with the design I can start the implementation.
>> But if their should be any improvements please let me know.
> Yes it looks okay. Maybe just the method should be called something
> like getHtml.
> On the other topic - I've merged your changes so far and as you can see
> [1] they produced lot of coding style violations. Please try to prevent
> this in future work. I'm committing fixes right now so that you can
> check the mistakes.
> [1]: https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1491/
> --
> 	Michal Čihař | http://cihar.com | http://blog.cihar.com

Hi Michal,

Its great to heard that you have merge my changes to the master branch.
I'll consider more on coding style in the future work and fix existing ones.

I'll start implementation on the PMA_DisplayResults class soon.

Regards !

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka

More information about the Developers mailing list