[Phpmyadmin-devel] Translations and CI for 4.0

[Michal Čihař]

Hi

Dne Wed, 10 Apr 2013 10:32:57 +0200
Dieter Adriaenssens <dieter.adriaenssens at gmail.com> napsal(a):

> 2013/4/9 Michal Čihař <michal at cihar.com>:
> > Well if I understand the docs [1] correctly, the only way to do that
> > is list files we want to cover in phpunit.xml.dist (some wildcards
> > are possible though). I'm not sure if doing this is better than current
> > approach...
> 
> Well, it seems that
> 
> <whitelist addUncoveredFilesFromWhitelist="true">
> 
> is needed to include the files that are not covered by a test. But
> when reading the doc you mentioned [1], it seems that by adding the
> whitelist config option, blacklisting is ignored. I would test it, but
> the machines I have available at the moment don't have enough memory
> to easily do this, at least not for phpMyAdmin, for one of my other
> projects it works fine with the 'addUncoveredFilesFromWhitelist'
> option : all files/classes are included in the coverage report, not
> only the ones that are already used in a test.
> 
> I think that having this option is better, because it gives a better
> view of the current coverage. At this moment only some classes and
> files are mentioned in the coverage report, giving a false idea of how
> much files/classes are tested.

Indeed it gives much better overview, actually I'd expect this would be
the default behavior.

Feel free to make needed changes in master.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20130410/82a6cb35/attachment.sig>