[Phpmyadmin-devel] Translations and CI for 4.0

Dieter Adriaenssens dieter.adriaenssens at gmail.com
Fri Apr 12 16:20:49 CEST 2013

2013/4/10 Michal Čihař <michal at cihar.com>:
> Hi
> Dne Wed, 10 Apr 2013 10:32:57 +0200
> Dieter Adriaenssens <dieter.adriaenssens at gmail.com> napsal(a):
>> 2013/4/9 Michal Čihař <michal at cihar.com>:
>> > Well if I understand the docs [1] correctly, the only way to do that
>> > is list files we want to cover in phpunit.xml.dist (some wildcards
>> > are possible though). I'm not sure if doing this is better than current
>> > approach...
>> Well, it seems that
>> <whitelist addUncoveredFilesFromWhitelist="true">
>> is needed to include the files that are not covered by a test. But
>> when reading the doc you mentioned [1], it seems that by adding the
>> whitelist config option, blacklisting is ignored. I would test it, but
>> the machines I have available at the moment don't have enough memory
>> to easily do this, at least not for phpMyAdmin, for one of my other
>> projects it works fine with the 'addUncoveredFilesFromWhitelist'
>> option : all files/classes are included in the coverage report, not
>> only the ones that are already used in a test.
>> I think that having this option is better, because it gives a better
>> view of the current coverage. At this moment only some classes and
>> files are mentioned in the coverage report, giving a false idea of how
>> much files/classes are tested.
> Indeed it gives much better overview, actually I'd expect this would be
> the default behavior.
> Feel free to make needed changes in master.

Done, see commit [0] and [1].
At this moment, only php files are tested and covered.

Should we have js (unit) tests as well?

[0] https://github.com/phpmyadmin/phpmyadmin/commit/104c99a7c9c11190608a7058911a215284b03835
[1] https://github.com/phpmyadmin/phpmyadmin/commit/43cce027a918a07d7201d9413272f00cb837f8d7.

More information about the Developers mailing list