[Phpmyadmin-devel] Double check our pull request after sending out

Bin Zu xmujay at gmail.com
Mon Aug 12 17:06:55 CEST 2013


Hi all,

After two month' coding and sending pull request, I found that we are missing something after sending out pull request.

After sending out pull request, we must check that Github shows that "Good to merge — The Travis CI build passed(Details)"

but actually, it is *not* good enough to merge, there may be some UT failures, 
so I think we should also click (Details) [1] to see the details of Travis CI build result for PHP5.5, PHP5.4, PHP5.3

After check that all UT passed, it is Good to merge.

Hope it is helpful

[1] https://travis-ci.org/phpmyadmin/phpmyadmin/builds/10117870


thanks,
Bin


More information about the Developers mailing list