[Phpmyadmin-devel] Double check our pull request after sending out
michal at cihar.com
Mon Aug 12 17:14:21 CEST 2013
Dne Mon, 12 Aug 2013 23:06:55 +0800
"Bin Zu" <xmujay at gmail.com> napsal(a):
> After two month' coding and sending pull request, I found that we are missing something after sending out pull request.
> After sending out pull request, we must check that Github shows that "Good to merge — The Travis CI build passed(Details)"
> but actually, it is *not* good enough to merge, there may be some UT failures,
What is actually a bug in our ant script, I've fixed it in 0dd6a9a. Now
it will correctly fail on unit test failure.
Michal Čihař | http://cihar.com | http://phpmyadmin.net
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: not available
More information about the Developers