[Phpmyadmin-devel] Unit tests failing

[adam]

Hi,

>
>Two of those tests, which are throwing the iconv error were written by me. I tested them on OS X and they seem to work fine here. I am wondering what could be the issue.   
>
>Also, I am now down to the following 2 failures now:
>
>There were 2 failures:
>
>1) ImportShp_Test::testGetProperties
>Failed asserting that null matches expected 'text/plain'.

I have fixed this error in the latest pull request:
https://github.com/adamgsoc2013/phpmyadmin/commit/336d18cdbc95c322e1ab176cd720d4ba9dbae233

still wait for review

>
>/Users/ayushchd/Sites/htdocs/phpmyadmin/test/classes/plugin/import/ImportShp_test.php:75
>/usr/local/php5-20130103-080303/bin/phpunit:46
>
>2) PMA_SQLParser_Test::testParser with data set #3 ('SELECT * from `aaa;', array('SELECT * from `aaa`;', array('alpha_reservedWord', 'SELECT', 6, true), array('punct', '*', 0), array('alpha_reservedWord', 'from', 13, true), array('quote_backtick', '`aaa`', 0), array('punct_queryend', ';', 0), 5), '<div class="notice"><img src="theme/s_notice.png" title="" alt="" /> Automatically appended backtick to the end of query!</div>')
>Failed asserting that two strings are equal.
>--- Expected
>+++ Actual
>@@ @@
>-'<div class="notice"><img src="theme/s_notice.png" title="" alt="" /> Automatically appended backtick to the end of query!</div>'
>+''
>
>/usr/local/php5-20130103-080303/bin/phpunit:46
>
>--
>
>Please advice.


Adam