[Phpmyadmin-devel] Automatic testing

[adam]

Hi,

I have a question about current Automatic testing process.
When one guy finished a piece of code on the library folder about the Backend logic. 

Should he follows some instructions before check in code besides Code-review?
1.  UT implementation
2.  Regression --> this will be checked by CI Job
3.  running regression and UT on his dev box?


In my mind, the fomal processes should be:
1.  add logic code
2. add UT code
3. test on dev box
4. run UT & regression test on dev box
5. code review after pass 1-4
6. checkin code
7. check CI build
.....



thanks





adam

From: adam
Date: 2013-03-26 18:17
To: phpmyadmin-devel
Subject: Re: Re: [Phpmyadmin-devel] Automatic testing
thanks MichalČihař,

> You don't have to learn everything from the code, we have much of that
>documented: http://wiki.phpmyadmin.net/pma/Development
Yes, I am setting up the CI env on my dev box. after that, I can run the test report on my dev box, so that I can manager everything before checking code.

> Because they are not run in any testcase and they are not included in
> coverage report because of that.

right, we should increase the code coverage of Backend class since there are logic related. and the render php may be changed easily.

thanks,




adam

From: MichalČihař
Date: 2013-03-25 17:54
To: phpmyadmin-devel
Subject: Re: [Phpmyadmin-devel] Automatic testing
Hi

first of all it is not needed to CC all my emails, using mailing list
is enough :-).

Dne Sat, 23 Mar 2013 18:18:36 +0800
adam <adamgsoc2013 at gmail.com> napsal(a):

> I have more thinkings on the Phpmyadmin Automatic testing after reading more codes.
> ========================Code Learning====================
> Following is my code learning:

You don't have to learn everything from the code, we have much of that
documented:

http://wiki.phpmyadmin.net/pma/Development

> 1.  why the db_create.php and some php page is stored on ROOT folder instead of libary folder? Is it because it for browser access? a link?

Yes for links and for backward compatibility with non AJAX versions.

> 2.  From the code coverage report page: http://ci.phpmyadmin.net/job/phpMyAdmin%203.5/cloverphp/? 
> I found that a lot of file is not included. such as the php file on the ROOT folder.

Because they are not run in any testcase and they are not included in
coverage report because of that.

> About the topic, at least two things should be done:
> 1.  create more test cases to increase the code-coverage of the test-suite 
> From the following data,
> Total48.55%11386 / 2345248.04%368 / 76615.79%9 / 57
>  libraries47.45%10894 / 2296048.04%368 / 76615.79%9 / 57

Yes, that's one of the goals for this GSoC project.

> 2.  set up the necessary scripts to automate this. 
> https://github.com/adamgsoc2013/phpmyadmin/tree/master/scripts 

Pretty much everything about testing is automated in build.xml in
project root.

-- 
Michal Čihař | http://cihar.com | http://blog.cihar.com



------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar


_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20130329/d91d78f7/attachment.html>