[Phpmyadmin-devel] about merging $what and $query_type on libraries/mult_submits.inc.php

Bin Zu xmujay at gmail.com
Sun Sep 15 17:38:59 CEST 2013


Hi Dev,

After the code refactor on libraries/mult_submits.inc.php, we try to merge $what and $query_type on libraries/mult_submits.inc.php

About this issue, I found that :$what and $query_type are used in different branches with different logic.

branch 1 : about $what : 
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/mult_submits.inc.php#L123

branch 2: about $query_type: 
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/mult_submits.inc.php#L159

If we merge them together, the two branches should be merged as well. so the logic will be more complicated.


What do other guys think?

thanks,
Bin


More information about the Developers mailing list