[Phpmyadmin-devel] about merging $what and $query_type on libraries/mult_submits.inc.php

[Marc Delisle]

Le 2013-09-15 11:38, Bin Zu a écrit :
> Hi Dev,
> 
> After the code refactor on libraries/mult_submits.inc.php, we try to merge $what and $query_type on libraries/mult_submits.inc.php
> 
> About this issue, I found that :$what and $query_type are used in different branches with different logic.
> 
> branch 1 : about $what : 
> https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/mult_submits.inc.php#L123
> 
> branch 2: about $query_type: 
> https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/mult_submits.inc.php#L159
> 
> If we merge them together, the two branches should be merged as well. so the logic will be more complicated.
> 
> 
> What do other guys think?
> 
> thanks,
> Bin

Hi Bin,
sorry, I'm not sure I understand your message. My point is that when I
see this:


$what = $submit_mult;

followed a few lines above by

$query_type = $submit_mult;

my conclusion is that, maybe, $what and $query_type should be merged.


-- 
Marc Delisle
http://infomarc.info