[Phpmyadmin-devel] New feature: Load/save Query-By-Example

[Marc Delisle]

Hugues Peccatte a écrit :
> 2014-03-09 20:53 GMT+01:00 Marc Delisle <marc at infomarc.info>:
> 
>> Le 2014-03-09 11:52, Hugues Peccatte a écrit :
>>>     How about adding a "Rename bookmark" button? Then, if I change the
>> name
>>>     and hit "Save bookmark", I get a copy (which is what I also expect
>> from
>>>     the UI).
>>>
>>>
>>> Won't we have too much button here ?
>>> If you think that the "Save button" shouldn't rename but save another
>>> one, I could change the behavior.
>>> But imagine that you just want to update a search without changing the
>>> name (and without implementing the "Rename" button), then you should:
>>> - load a search "MySearch"
>>> - change the filters
>>> - save the search with a new name "MyNewSearch"
>>> - delete the old one "MySearch"
>>> - load the new search "MyNewSearch"
>>> - save the search with the old name "MySearch"
>>> - delete the intermidiate search "MyNewSearch"
>>>
>>> Could I suggest to add a confirmation alert when trying to rename a
>> search ?
>>> "Do you really want to rename the bookmarked search <<MySearch>> as
>>> <<MyNewSearch>>? To create a new one, please select <<New bookmark>>."
>>> (Please correct if needed.)
>>>
>>> Another minor modifications could be to add a "as" between the select
>>> input and the text input.
>>> "Saved bookmarked search: <<New bookmark>> as <<SortByName>>"
>>> "Saved bookmarked search: <<SortByName>> as <<SortByNameDesc>>"
>> This will create a difficulty for translators, unless we implement a
>> unique, bigger message containing as the parameters, the two controls.
>>
> 
> You're right... I thought to this and I didn't know how to translate it in
> French.
> 
> 
>>> After your decision, I'll try to implement it. The choices:
>>> - new button "Rename bookmark"
>>> - new alert to warn the user (my favorite)
>>> - add a minor text to be clearer
>> Since we have the room for another button, my opinion is that we should
>> implement it, instead of asking the user to experiment with the UI to
>> find out how to do some operation.
> 
> 
> Ok.
> So I'll add a button. So we'll have:
> - Create bookmark
> - Update bookmark (visible only when a bookmark is selected)
> - Delete bookmark  (visible only when a bookmark is selected - currently
> always displayed)
> 
> If we have an "inactive" display for buttons, instead of hidding them, I
> could just use this display. Please tell me which one you prefer.
> I used "Update" instead of "Rename" because the work to save both (the new
> name and the new filters) is already done.
> 
> And when changing the selected item to "New bookmark", I'll reload the page
> and empty all the fields.
> 
> Do you agree with all these changes? Is it closer than the behavior you
> expect?
> 
> Hugues.

Looks fine.

-- 
Marc Delisle
http://infomarc.info | http://phpmyadmin.net