[Phpmyadmin-devel] Changes in SOB checking in pull requests

Michal Čihař michal at cihar.com
Thu Mar 13 11:54:25 CET 2014


Hi all

I've just changed way we check SOB lines in our pull requests. This
check is no longer done by Travis, but rather by separate hook, which
comments on individual commits in case SOB is missing. You can see
example here:

https://github.com/nijel/phpmyadmin/commit/6b22d159530337efab1def4d613387ac3c2a8079

Source code for the hook is in our scripts repo:

https://github.com/phpmyadmin/scripts/tree/master/hooks

This has advantage that authors get direct feedback mentioning what is
wrong and also these comments are directly visibly in pull request.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140313/560b09dc/attachment.sig>


More information about the Developers mailing list