[Phpmyadmin-devel] Changes in SOB checking in pull requests

Marc Delisle marc at infomarc.info
Thu Mar 13 15:09:18 CET 2014


Michal Čihař a écrit :
> Hi all
> 
> I've just changed way we check SOB lines in our pull requests. This
> check is no longer done by Travis, but rather by separate hook, which
> comments on individual commits in case SOB is missing. You can see
> example here:
> 
> https://github.com/nijel/phpmyadmin/commit/6b22d159530337efab1def4d613387ac3c2a8079
> 
> Source code for the hook is in our scripts repo:
> 
> https://github.com/phpmyadmin/scripts/tree/master/hooks
> 
> This has advantage that authors get direct feedback mentioning what is
> wrong and also these comments are directly visibly in pull request.

Thanks Michal, this will be very helpful.


-- 
Marc Delisle
http://infomarc.info | http://phpmyadmin.net




More information about the Developers mailing list