[Phpmyadmin-devel] Travis fails for the bug patch I have written

[Michal Čihař]

Hi

Dne Wed, 5 Mar 2014 14:10:45 +0100
Michal Čihař <michal at cihar.com> napsal(a):

> Dne Wed, 5 Mar 2014 16:37:41 +0530
> Sastry aditya <ganeshaditya1 at gmail.com> napsal(a):
> 
> > >Hi
> > >
> > >Dne Wed, 5 Mar 2014 13:05:17 +0530
> > >Sastry aditya <ganeshaditya1 at gmail.com> napsal(a):
> > >
> > >> No output has been received in the last 10 minutes, this potentially
> > >> indicates a stalled build or something wrong with the build itself."
> > >
> > >Unfortunately this happens occasionally on Travis. It is caused by some
> > >interactions of phpunit and our error handling in our Advisor code,
> > >which makes phpunit buffer all output. Then Travis thinks the build is
> > >stuck as it takes quite long without producing any output.
> > >
> > >The code causing this is in ruleExprEvaluate [1] and the problem happens
> > >only for case when eval ends with error. Maybe it's even some bug
> > >within PHP which breaks output buffering in this case.
> > >
> > >[1]:
> > https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/Advisor.class.php#L341
> > 
> > So how do I go about getting Travis to process my commit again ? should I
> > send another pull request or something ?
> 
> I've restarted it, but it should be fine as there was only one PHP
> versions causing the problem.
> 
> Anyway anybody is welcome to look deeper into this issue as it is
> really annoying.

This issue should be now fixed in eb85831. Was caused by phpunit
changing PHP runtime errors into exceptions and our code then leaving
one more ob_start level open than phpunit expected.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140313/98d46358/attachment.sig>