[Phpmyadmin-devel] Changes in SOB checking in pull requests

Hugues Peccatte hugues.peccatte at gmail.com
Thu Mar 13 18:34:12 CET 2014

2014-03-13 11:54 GMT+01:00 Michal Čihař <michal at cihar.com>:

> Hi all
> I've just changed way we check SOB lines in our pull requests. This
> check is no longer done by Travis, but rather by separate hook, which
> comments on individual commits in case SOB is missing. You can see
> example here:
> https://github.com/nijel/phpmyadmin/commit/6b22d159530337efab1def4d613387ac3c2a8079
> Source code for the hook is in our scripts repo:
> https://github.com/phpmyadmin/scripts/tree/master/hooks
> This has advantage that authors get direct feedback mentioning what is
> wrong and also these comments are directly visibly in pull request.

Nice work !

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140313/f7477db4/attachment.html>

More information about the Developers mailing list