[phpMyAdmin Developers] Question about PSR1

[Hugues Peccatte]

Le sam. 5 déc. 2015 à 13:57, Marc Delisle <marc at infomarc.info> a écrit :

> Hi,
>
> We have some PSR1 Scrutinizer warnings in many files. For example, in
> js/whitelist.php:
>
> "For compatibility and reusability of your code, PSR1 recommends that a
> file should either new symbols (like classes, functions, etc.) or have
> side-effects (like outputting something, or including other files), but
> not both at the same time. The first symbol is defined on line 20 and
> the first side effect is on line 9."
>
> Is it true that PSR1 objects to our having a define() statement and
> ordinary code like chdir() in the same file?
>
> --
> Marc Delisle | phpMyAdmin
>
> _______________________________________________
> Developers mailing list
> Developers at phpmyadmin.net
> https://lists.phpmyadmin.net/mailman/listinfo/developers
>
Hi,

Yes, that's true because one of the rules is not to have declaration and
logic code in the same file. Define is declaration, chdir is logic.

H.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.phpmyadmin.net/pipermail/developers/attachments/20151205/e262e5b2/attachment.html>