[phpMyAdmin Developers] Question about PSR1
marc at infomarc.info
Mon Dec 7 19:16:13 CET 2015
Le 2015-12-07 10:46, Michal Čihař a écrit :
> Dne 5.12.2015 v 16:51 Marc Delisle napsal(a):
>> I find it overkill to move one line of define() to an include file. A
>> possible way to comply with PSR1 in this situation would be the following.
>> In js/whitelist.php, replace the define() with
>> $pmaMinimumCommon = true;
>> In libraries/common.inc.php replace the if (! defined()) with
>> if (! pmaMinimumCommon)
> Maybe it would be better (and cleaner) to split up common.inc.php to two
> files - one doing the "minimal" set of things, the other one adding
> other logic on top of it.
Marc Delisle | phpMyAdmin
More information about the Developers