[Phpmyadmin-devel] LIMIT clause when browsing

[Madhura Jayaratne]

On Thu, Jul 9, 2015 at 5:28 PM, Marc Delisle <marc at infomarc.info> wrote:

> Hi,
>
> Dan Ungureanu was asking me about some dead code, and this made me
> realize that we might have a bug; however I'm not sure whether this was
> intentional or not.
>
> To see what I mean, use the MAINT_4_0_10 branch and browse a table that
> has many rows: you'll see that the displayed query shows the proper
> generated LIMIT clause, which changes when you click on the Next icon.
>
> This comes from [0] which uses a GLOBAL variable set in [1].
>
> Starting with 4.1, due to some refactoring, the generated LIMIT clause
> is no longer shown.
>
> Intentional or not?
>
> [0]
>
> https://github.com/phpmyadmin/phpmyadmin/blob/MAINT_4_0_10/libraries/Util.class.php#L1168
>
> [1]
> https://github.com/phpmyadmin/phpmyadmin/blob/MAINT_4_0_10/sql.php#L577
>
> --
> Marc Delisle | phpMyAdmin
>
>
Not sure whether it's intentional or not, but it corresponds well with the
message "Showing rows 0 - 24 (98 total...". If we show the LIMIT 0, 25 in
the query "98 total" might look confusing.

-- 
Thanks and Regards,

Madhura Jayaratne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20150709/fc43e1b0/attachment.html>