[Phpmyadmin-devel] Issue with closing tags at the end of the file

[Hugues Peccatte]

2015-03-05 13:56 GMT+01:00 Marc Delisle <marc at infomarc.info>:

> Rahul Kadyan a écrit :
> > Hi everyone,
> >
> > In all files of phpMyAdmin source code, closing tag (?>) is included at
> the
> > end of file. Most frameworks like zend or symfony or laravel suggest to
> > omit closing tag to prevent accidental output of whites paces. In some
> > situations  output may send headers which makes the application incapable
> > to control response headers.
> >
> > My question is: Is there any specific reason for doing so?
> > secondly: Can we omit closing tags at the end of file?
>
> The most authoritative reference I could find is
> http://php.net/manual/en/language.basic-syntax.phptags.php
>
> but we have a mix of files of pure PHP code and not pure PHP code, as
> can be seen with
>
> git grep '<?php'
>
> (It would be a good time to improve those "not pure" files).
>
> --
> Marc Delisle (phpMyAdmin)
>

Hi,

I agree that we should remove ?> closing files.

Hugues.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20150305/63cc8aa5/attachment.html>