[phpMyAdmin Developers] Refactoring a controller

Madhura Jayaratne madhura.cj at gmail.com
Thu Oct 29 10:57:07 CET 2015


Indeed, it looks too long. I will look into the indexAction() method to
find logical sections to break into new methods.

On Thu, Oct 29, 2015 at 4:26 PM, Marc Delisle <marc at infomarc.info> wrote:

> Hi Madhura and Atul,
>
> I was looking at indexAction() in DatabaseStructureController.class.php,
> which is 566 lines. I find it too long to be manageable, and PMD agrees
> [0].
>
> Do you consider this method a work in progress? Does MVC mandate that
> indexAction() should remain that size?
>
> [0]
>
> http://ci.phpmyadmin.net/job/phpMyAdmin/1588/pmdResult/type.-385120790/file.-1544904175/
>
> --
> Marc Delisle | phpMyAdmin
>
> _______________________________________________
> Developers mailing list
> Developers at phpmyadmin.net
> https://lists.phpmyadmin.net/mailman/listinfo/developers
>



-- 
Thanks and Regards,

Madhura Jayaratne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.phpmyadmin.net/pipermail/developers/attachments/20151029/ce51d789/attachment.html>


More information about the Developers mailing list