[phpMyAdmin Developers] Responsive Tables - Improvement
Manish Bisht
manish.bisht490 at gmail.com
Sun Jun 18 15:37:21 CEST 2017
Hi,
I have made the Indexes area also responsive.
Branch: https://github.com/manishbisht/phpmyadmin/tree/responsive-design
Commit:
https://github.com/manishbisht/phpmyadmin/commit/4c4904d6638e1f04ce61f4d58e6c2ae7d1d7e5e8
I am looking forward for the suggestions.
Thanks,
Manish Bisht
Email : hi at manishbisht.me
Website : https://manishbisht.me
On Fri, Jun 16, 2017 at 11:54 PM, Manish Bisht <manish.bisht490 at gmail.com>
wrote:
> Hi,
>
> I am having some issues in making "Indexes" area responsive. I think its
> due to the css used for `fieldset` tag. I am working on it and will
> update as soon as it will be done.
>
> I can add scrolling to menu bar. But as the height of the scrollbar is
> more only the half area will be shown to user. Attached the screenshot
> displaying it. Also the scrollbar is only shown when the user is scrolling
> same as in tables. Let me know if it works.
>
> Thanks,
>
> Manish Bisht
> Email : hi at manishbisht.me
> Website : https://manishbisht.me
>
>
> On Fri, Jun 16, 2017 at 8:10 PM, Isaac Bennetch <bennetch at gmail.com>
> wrote:
>
>> Hi Manish,
>>
>> On Thu, Jun 15, 2017 at 11:46 AM, Manish Bisht
>> <manish.bisht490 at gmail.com> wrote:
>> > Hi,
>> >
>> > I have now made the table structure page responsive.
>> >
>> > Branch: https://github.com/manishbisht/phpmyadmin/tree/responsive-
>> design
>> > Commit:
>> > https://github.com/manishbisht/phpmyadmin/commit/3e1d1bf3dbe
>> 739607a8de34995d2d356894b2622
>> >
>> > Please have a look at it. I will be looking forward for your
>> suggestions.
>>
>> I'm quite happy with how this is developing.
>>
>> I like how the table structure page has the scrolling for the columns
>> "detached" from the rest of the page, so I can scroll to the right and
>> see, for instance, the Actions area without the Information pane being
>> affected. It would be helpful if the "Indexes" area acted the same.
>>
>> The databases and user accounts pages both work really well, too
>> (everything is coming together nicely, but those two in particular
>> seem to work especially well).
>>
>> One thing I'm realizing, even with the improvements you've made to the
>> menu bar at the top of the page, my instinctive reaction is to want to
>> grab is and scroll it (like I scroll down a page), rather than
>> pressing the button to have it scroll. I hope that makes sense. I
>> wonder if such a thing is easily possible and what you and some others
>> think about this. When I first saw it, the buttons that are there made
>> sense, but as I started using it and as more pages have been
>> converted, it seems more natural to want to scroll it rather than
>> having the buttons. Just my two cents.
>>
>> Nice work so far, thanks for the update.
>> Isaac
>>
>>
>> > Manish Bisht
>> > Email : hi at manishbisht.me
>> > Website : https://manishbisht.me
>> >
>> >
>> > On Thu, Jun 15, 2017 at 8:43 AM, Manish Bisht <
>> manish.bisht490 at gmail.com>
>> > wrote:
>> >>
>> >> I have checked the master branch of phpmyadmin and found that the
>> error is
>> >> coming from the main branch. Check this Issue:
>> >> https://github.com/phpmyadmin/phpmyadmin/issues/13384
>> >>
>> >> Manish Bisht
>> >> Email : hi at manishbisht.me
>> >> Website : https://manishbisht.me
>> >>
>> >>
>> >> On Thu, Jun 15, 2017 at 8:19 AM, Manish Bisht <
>> manish.bisht490 at gmail.com>
>> >> wrote:
>> >>>
>> >>> This condition `$GLOBALS['server'] != $GLOBALS['cfg']['ServerDefault
>> ']`
>> >>> is returning false.
>> >>>
>> >>> In my case both the values are 1. What is the difference between both
>> >>> variables ?
>> >>>
>> >>> Manish Bisht
>> >>> Email : hi at manishbisht.me
>> >>> Website : https://manishbisht.me
>> >>>
>> >>>
>> >>> On Wed, Jun 14, 2017 at 11:48 PM, Manish Bisht
>> >>> <manish.bisht490 at gmail.com> wrote:
>> >>>>
>> >>>> Seems like the following condition is broken.
>> >>>>
>> >>>> if (isset($GLOBALS['server'])
>> >>>> && $GLOBALS['server'] != $GLOBALS['cfg']['ServerDefault']
>> >>>> && ! isset($params['server'])
>> >>>> && ! defined('PMA_SETUP')
>> >>>> ) {
>> >>>> $params['server'] = $GLOBALS['server'];
>> >>>> }
>> >>>>
>> >>>>
>> >>>>
>> >>>> Manish Bisht
>> >>>> Email : hi at manishbisht.me
>> >>>> Website : https://manishbisht.me
>> >>>>
>> >>>>
>> >>>> On Wed, Jun 14, 2017 at 11:35 PM, Manish Bisht
>> >>>> <manish.bisht490 at gmail.com> wrote:
>> >>>>>
>> >>>>> After applying the commit the database selection from the database
>> >>>>> seems to be broken. While playing with code got to know that the
>> >>>>> `$GLOBALS['url_query']` seems to be broken. What is the use of this
>> variable
>> >>>>> so that I can find the mistake made ?
>> >>>>>
>> >>>>> Thanks,
>> >>>>>
>> >>>>>
>> >>>>> Manish Bisht
>> >>>>> Email : hi at manishbisht.me
>> >>>>> Website : https://manishbisht.me
>> >>>>>
>> >>>>>
>> >>>>> On Tue, Jun 13, 2017 at 10:10 PM, Manish Bisht
>> >>>>> <manish.bisht490 at gmail.com> wrote:
>> >>>>>>
>> >>>>>> Hi,
>> >>>>>>
>> >>>>>> I am working on making phpmyadmin responsive. I have added the
>> >>>>>> vertical scrolling on the tables on the databases, structure and
>> browse
>> >>>>>> pages
>> >>>>>>
>> >>>>>> Branch:
>> >>>>>> https://github.com/manishbisht/phpmyadmin/tree/responsive-design
>> >>>>>> Commit:
>> >>>>>> https://github.com/manishbisht/phpmyadmin/commit/25fc52aea65
>> 5989bd68a16643387b45c15a44be4
>> >>>>>>
>> >>>>>> Please have a look at it. I will be looking forward for your
>> >>>>>> suggestions.
>> >>>>>>
>> >>>>>> Thanks,
>> >>>>>>
>> >>>>>> Manish Bisht
>> >>>>>> Email : hi at manishbisht.me
>> >>>>>> Website : https://manishbisht.me
>> >>>>>>
>> >>>>>
>> >>>>
>> >>>
>> >>
>> >
>> >
>> > _______________________________________________
>> > Developers mailing list
>> > Developers at phpmyadmin.net
>> > https://lists.phpmyadmin.net/mailman/listinfo/developers
>> >
>>
>> _______________________________________________
>> Developers mailing list
>> Developers at phpmyadmin.net
>> https://lists.phpmyadmin.net/mailman/listinfo/developers
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.phpmyadmin.net/pipermail/developers/attachments/20170618/c5aa12dc/attachment.html>
More information about the Developers
mailing list