[phpMyAdmin Developers] GSOC 2017 - Manish Bisht Introduction - Contributing Guide

[Michal Čihař]

Hi

Manish Bisht píše v St 01. 03. 2017 v 13:30 +0530:
> 2. Disable charset conversion when importing with SET NAMES
> The list comment on this link https://github.com/phpmyadmin/phpmyadmi
> n/issues/9419 gives the start to solve this issue.
> 
> > Indeed the charset handling seems to be broken on the import:
> > the iso-8859-1 file imports fine if I choose utf-8 and keep SET
> > NAMES latin1
> > the iso-8859-1 file imports fine if I choose iso-8859-1 and remove
> > SET NAMES latin1
> > the iso-8859-1 file imports corrupted if I choose iso-8859-1 and
> > keep SET NAMES latin1
> > 
> 
> Any suggestions will be helpful to implement it in more better way.

I've already commented on this in the issue tracker:

Not sure how to best approach this, but we should avoid the double
encoding problem. On the other side the charset selector for import has
to stay for SQL files which do not do SET NAMES and for other formats
like CSV. Maybe disable our charset conversion once we spot SET NAMES
in the SQL?

If you want to followup, please do that in the issue tracker, so that
whole discussion stays in one place.

-- 
	Michal Čihař | https://cihar.com/ | https://weblate.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.phpmyadmin.net/pipermail/developers/attachments/20170301/c4bdae62/attachment.sig>