[phpMyAdmin Developers] GSOC 2017 - Manish Bisht Introduction - Contributing Guide
Isaac Bennetch
bennetch at gmail.com
Wed Mar 29 17:03:40 CEST 2017
On 3/29/17 10:26 AM, Manish Bisht wrote:
> Hi,
>
> The last discussion I can see on making phpyadmin responsive was
> this https://github.com/phpmyadmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up
> <https://github.com/phpmyadmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up> So
> I just wanted to know that is this issue is in priority ?
I think the problem is that we can't disrupt large amounts of the core
phpMyAdmin code for a massive rewrite, and no developer wishes to take
responsibility to work on this. It will probably make a good GSoC
project, because a student will have time to work on it through the
summer and, even if parts remain unfinished, the project won't stall and
languish with lack of developer time. I hope that makes sense. I'm not
sure how it will fit with GSoC due to the timeline; part of me sees ways
we can improve this with minimal effort and disruption to the code and
the other part of me thinks it's going to be too big for GSoC and too
disruptive to implement.
Honestly, out of all the tasks on the entire ideas list, this is the one
I'm least certain about. A good proposal for this particular project
would probably show how the student has anticipated working on this in
stages and has an honest and reasonable assessment of the time required.
As far as whether I, personally, think it's a good direction for the
project to go; I'm about 60% for including it and 40% don't see the
point (figuring that most serious development can't yet occur on a
tablet of phone, but realizing the value of being responsive to the
handful of user requests we've had for this functionality).
> Thanks,
>
>
> Manish Bisht
> Email : hi at manishbisht.me <mailto:hi at manishbisht.me>
> Website : https://manishbisht.me <https://manishbisht.me/>
>
>
> On Wed, Mar 22, 2017 at 11:37 PM, Manish Bisht
> <manish.bisht490 at gmail.com <mailto:manish.bisht490 at gmail.com>> wrote:
>
> Hi,
>
> I have submitted the draft of my GSoC Proposal. Can someone from the
> organisation review it.
>
> Thanks,
>
>
> Manish Bisht
> Email : hi at manishbisht.me <mailto:hi at manishbisht.me>
> Website : https://manishbisht.me <https://manishbisht.me/>
>
>
> On Wed, Mar 1, 2017 at 4:38 PM, Manish Bisht
> <manish.bisht490 at gmail.com <mailto:manish.bisht490 at gmail.com>> wrote:
>
> Yes, I will do my detailed discussion there.
>
> I've already commented on this in the issue tracker:
> Not sure how to best approach this, but we should avoid the
> double
> encoding problem. On the other side the charset selector for
> import has
> to stay for SQL files which do not do SET NAMES and for
> other formats
> like CSV. Maybe disable our charset conversion once we spot
> SET NAMES
> in the SQL?
> If you want to followup, please do that in the issue
> tracker, so that
> whole discussion stays in one place.
>
>
> Manish Bisht
> Email : hi at manishbisht.me <mailto:hi at manishbisht.me>
> Website : https://manishbisht.me <https://manishbisht.me/>
>
>
> On Wed, Mar 1, 2017 at 4:35 PM, Manish Bisht
> <manish.bisht490 at gmail.com <mailto:manish.bisht490 at gmail.com>>
> wrote:
>
> Any update on my implementation of this ?
>
> 1. Improve responsive/mobile interface
> Is there any designed proposed for mobile till now ? The
> last discussion i can see on this was
> this https://github.com/phpmyadmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up
> <https://github.com/phpmyadmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up> Also
> it was mentioned that this feature in right now not in
> priority.
> My plan to implement this is to make the interface the
> mobile first.
> a) The left side bar with id pma_navigation can be put
> as the menu/hamburger icon for smaller screens
> b) The div with id serverinfo will still remain at the top.
> c) The div with id topmenucontainer will be implemented
> as the horizontal scrolling like this (Open this link
> in https://getmdl.io/components/index.html
> <https://getmdl.io/components/index.html> on mobile you
> will see the horizontal scrolling at the top for about,
> getting started etc.)
> d) The div with id maincontainer will now have the main
> content. Home page boxes (General settings, Database
> server etc) can be shown in the vertical order. Right
> now it works but there is still some spacing issues.
> Tables can be shown with some min-width because it will
> not fit on smaller screen sizes when the number of
> columns in the table are more or they contains large
> strings like tokens, md5 strings etc.
> For status tab one more horizontal slider will be
> required and then the tables one after another in
> vertical position.
> e) The div with id pma_console will remain same. when it
> is opened on smaller devices it will open on the full
> screen instead of half as in larger screens.
>
>
> Manish Bisht
> Email : hi at manishbisht.me <mailto:hi at manishbisht.me>
> Website : https://manishbisht.me <https://manishbisht.me/>
>
>
> On Wed, Mar 1, 2017 at 2:44 PM, shishir bondre
> <bondreshishir at gmail.com <mailto:bondreshishir at gmail.com>>
> wrote:
>
> What will be necessary features required for the *Theme
> Generator* and Expectations so that i can propose a good
> proposal and focus on these features and generate a good
> idea
>
> On Wed, Mar 1, 2017 at 2:10 PM, Michal Čihař
> <michal at cihar.com <mailto:michal at cihar.com>> wrote:
>
> Hi
>
> Manish Bisht píše v St 01. 03. 2017 v 13:30 +0530:
> > 2. Disable charset conversion when importing with SET NAMES
> > The list comment on this link https://github.com/phpmyadmin/phpmyadmi
> <https://github.com/phpmyadmin/phpmyadmi>
> > n/issues/9419 gives the start to solve this issue.
> >
> > > Indeed the charset handling seems to be broken on the import:
> > > the iso-8859-1 file imports fine if I choose utf-8 and keep SET
> > > NAMES latin1
> > > the iso-8859-1 file imports fine if I choose iso-8859-1 and remove
> > > SET NAMES latin1
> > > the iso-8859-1 file imports corrupted if I choose iso-8859-1 and
> > > keep SET NAMES latin1
> > >
> >
> > Any suggestions will be helpful to implement it in more better way.
>
> I've already commented on this in the issue tracker:
>
> Not sure how to best approach this, but we should
> avoid the double
> encoding problem. On the other side the charset
> selector for import has
> to stay for SQL files which do not do SET NAMES and
> for other formats
> like CSV. Maybe disable our charset conversion once
> we spot SET NAMES
> in the SQL?
>
> If you want to followup, please do that in the issue
> tracker, so that
> whole discussion stays in one place.
>
> --
> Michal Čihař | https://cihar.com/ |
> https://weblate.org/
>
> _______________________________________________
> Developers mailing list
> Developers at phpmyadmin.net
> <mailto:Developers at phpmyadmin.net>
> https://lists.phpmyadmin.net/mailman/listinfo/developers
> <https://lists.phpmyadmin.net/mailman/listinfo/developers>
>
>
>
> _______________________________________________
> Developers mailing list
> Developers at phpmyadmin.net <mailto:Developers at phpmyadmin.net>
> https://lists.phpmyadmin.net/mailman/listinfo/developers
> <https://lists.phpmyadmin.net/mailman/listinfo/developers>
>
>
>
>
>
>
>
> _______________________________________________
> Developers mailing list
> Developers at phpmyadmin.net
> https://lists.phpmyadmin.net/mailman/listinfo/developers
>
More information about the Developers
mailing list