[Phpmyadmin-git] [SCM] phpMyAdmin branch, master, updated. RELEASE_3_4_0ALPHA2-1705-g9d9d88b

[Marc Delisle]

The branch, master has been updated
       via  9d9d88b83f82a2026336f19140c23a313d75bd56 (commit)
      from  c6d051b65e28b07b5b7980eac29616d3932f360c (commit)


- Log -----------------------------------------------------------------
commit 9d9d88b83f82a2026336f19140c23a313d75bd56
Author: Marc Delisle <marc at infomarc.info>
Date:   Sat Dec 4 06:35:55 2010 -0500

    bug #3119937 cannot upload into a BLOB

-----------------------------------------------------------------------

Summary of changes:
 js/tbl_change.js |   18 +++++++++++++++++-
 1 files changed, 17 insertions(+), 1 deletions(-)

diff --git a/js/tbl_change.js b/js/tbl_change.js
index dc1632a..758add1 100644
--- a/js/tbl_change.js
+++ b/js/tbl_change.js
@@ -276,8 +276,24 @@ $(document).ready(function() {
      * Submission of data to be inserted or updated 
      * 
      * @uses    PMA_ajaxShowMessage()
+     *
+     * This section has been deactivated. Here are the problems that I've
+     * noticed:
+     *
+     * 1. If the form contains a file upload field, the data does not reach
+     *    tbl_replace.php. This is because AJAX does not support file upload.
+     *    As a workaround I tried jquery.form.js version 2.49. The file
+     *    upload worked but afterwards the browser presented a tbl_replace.php
+     *    file and a choice to open or save.
+     *
+     * 2. This code can be called if we are editing or inserting. If editing,
+     *    the "and then" action can be "go back to this page" or "edit next
+     *    row", in which cases it makes sense to use AJAX. But the "go back
+     *    to previous page" and "insert another new row" actions, using AJAX 
+     *    has no obvious advantage. If inserting, the "go back to previous"
+     *    action needs a page refresh anyway. 
      */
-    $("#insertForm").live('submit', function(event) {
+    $("#insertFormDEACTIVATED").live('submit', function(event) {
 
         /**
          * @var the_form    Object referring to the insertion form


hooks/post-receive
-- 
phpMyAdmin