[Phpmyadmin-devel] RFE #982 : Support for editing binary fields in hexadecimal
Hi, Does this feature mean editing binary and blob fields should be done in hexadecimals always? And, even when table is browsed they should be shown in hexadecimal only? If yes, then there is no need for this $cfg['DisplayBinaryAsHex']? And for $cfg['ProtectBinary'], IMHO it should not be removed so that users have and option to disable editing of binary fields to avoid accidental changes to data (even though they can be edited in hexadecimal form). Also, BLOB data can be very large and if we remove this config. var. then whenever someone will try to edit row then every time that BLOB field data will be displayed (which can be very very large) will have performance issue as well as it can annoy the user. Feature Request Link : https://sourceforge.net/p/phpmyadmin/feature-requests/982/ -- Regards, Chirayu Chiripal phpMyAdmin Intern - Google Summer of Code 2014 https://chirayuchiripal.wordpress.com/
Sorry for the delay, I was offline most of yesterday. On 5/14/14 2:34 PM, Chirayu Chiripal wrote:
Hi,
Does this feature mean editing binary and blob fields should be done in hexadecimals always?
That's how I understand the feature request. In discussing this, we should make the distinction between the type BINARY and the binary _attribute_ (as in CHAR BINARY or VARCHAR BINARY).
And, even when table is browsed they should be shown in hexadecimal only?
Yes, that makes the most sense to me.
If yes, then there is no need for this $cfg['DisplayBinaryAsHex']?
As far as I know this is correct.
And for $cfg['ProtectBinary'], IMHO it should not be removed so that users have and option to disable editing of binary fields to avoid accidental changes to data (even though they can be edited in hexadecimal form). Also, BLOB data can be very large and if we remove this config. var. then whenever someone will try to edit row then every time that BLOB field data will be displayed (which can be very very large) will have performance issue as well as it can annoy the user.
I agree with your assessment.
Feature Request Link : https://sourceforge.net/p/phpmyadmin/feature-requests/982/
-- Regards, Chirayu Chiripal phpMyAdmin Intern - Google Summer of Code 2014 https://chirayuchiripal.wordpress.com/
------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Thu, May 15, 2014 at 9:01 PM, Isaac Bennetch <bennetch@gmail.com> wrote:
Sorry for the delay, I was offline most of yesterday.
On 5/14/14 2:34 PM, Chirayu Chiripal wrote:
Hi,
Does this feature mean editing binary and blob fields should be done in hexadecimals always?
That's how I understand the feature request.
In discussing this, we should make the distinction between the type BINARY and the binary _attribute_ (as in CHAR BINARY or VARCHAR BINARY).
I don't think binary attribute (CHAR binary or VARCHAR binary) has to do anything with this feature.
And, even when table is browsed they should be shown in hexadecimal only?
Yes, that makes the most sense to me.
If yes, then there is no need for this $cfg['DisplayBinaryAsHex']?
As far as I know this is correct.
And for $cfg['ProtectBinary'], IMHO it should not be removed so that users have and option to disable editing of binary fields to avoid accidental changes to data (even though they can be edited in hexadecimal form). Also, BLOB data can be very large and if we remove this config. var. then whenever someone will try to edit row then every time that BLOB field data will be displayed (which can be very very large) will have performance issue as well as it can annoy the user.
I agree with your assessment.
Feature Request Link : https://sourceforge.net/p/phpmyadmin/feature-requests/982/
-- Regards, Chirayu Chiripal phpMyAdmin Intern - Google Summer of Code 2014 https://chirayuchiripal.wordpress.com/
-- Regards, Chirayu Chiripal phpMyAdmin Intern - Google Summer of Code 2014 https://chirayuchiripal.wordpress.com/
Hi, while implementing this feature, one of the functions (_displayBinaryAsPrintable()) in DisplayResults.class.php is no more required (not used anywhere else also, checked using ack-grep). Should I remove it or keep it for some future purpose for other developers? -- Regards, Chirayu Chiripal phpMyAdmin Intern - Google Summer of Code 2014 https://chirayuchiripal.wordpress.com/
participants (2)
-
Chirayu Chiripal -
Isaac Bennetch