2014-05-26 17:22 GMT+08:00 Michal Čihař <michal(a)cihar.com>om>: ​That not help me, I want to handle response data, get information and put them to console log... -- Edward Cheng

2014-05-26 17:56 GMT+08:00 Atul Pratap Singh <atulpratapsingh05(a)gmail.com>om>: ​I need global handlers handle my requests(show query result just like click a link), also need my handlers handle response data(update console messages). -- Edward Cheng

2014-05-26 18:19 GMT+08:00 Atul Pratap Singh <atulpratapsingh05(a)gmail.com>om>: ​Yeah, ​I made a console, you can type queries, execute queries, and check logs on it. When you type a query, press ctrl+enter you'll see the result comes out replace your currect page, AJAX.requestHandler will take this job, but console only shows query string, I need handle response data, so I can put results on console logs, and errors and other messages. Thanks :) -- Edward Cheng

On 5/26/14, Edward Cheng <c4150221(a)gmail.com> wrote: For executing and fetching query results, please also take a look at existing system in sql.js where custom handler is written for #sqlqueryform.ajax. So I think you could just pass the query to this existing system and page replacing will happen. About pushing subsequent sql result pages to AJAX.cache, I think it is not required and is not done right now. We currently push to AJAX.cache when user switches between different tabs etc. and not for subsequent sql result pages. So console div would be out of page_content and will not be removed/replaced as queries get executed from the console. For this also, I think you can write a custom handler. -- Atul Pratap Singh http://blog.atulsisodia.in/

Thank you:) 2014-05-26 19:19 GMT+08:00 Atul Pratap singh <atulpratapsingh05(a)gmail.com>om>: atulpratapsingh05(a)gmail.com> wrote: handler itself as you get the response. ------------------------------------------------------------------------------ companies. http://pubads.g.doubleclick.net/gampad/clk?id=145328191&iu=/4140/ostg.c… -- Edward Cheng

Edward, On Fri, May 30, 2014 at 2:02 PM, Edward Cheng <c4150221(a)gmail.com> wrote: As I understand, this mid-handler is your responsehandler that subsequently makes a call to the generic responsehandler of ajax.js. So it is not a real custom handler (that requests + handles response independent of the generic one) Also, as I understand from your code, the proposed console would store a log of run queries and on running a query from console, the results will be displayed in the same way as happens when running a query from SQL tab. Right ? As per this understanding, you need a real custom handler because executing SQL and handling its response in PMA involves many custom checks and calls not only at response stage but also at request stage. For ex:- - checkSqlQuery() - bookmark handling - reloading navigation for certain queries - refreshing main panel for certain queries - triggering grid edit for results etc. see in sql.js near $("#sqlqueryform.ajax").live('submit', function (event) { Or did you plan to duplicate above checks and calls into your midhandler? Also, I don't understand why you need to call the generic response-handler of ajax.js? Remember that we don't need to populate AJAX.cache either. Yes, you need to totally skip the generc/global AJAX handlers, for that you add a "class=ajax" to your form and write a custom handler. -- Regards Atul Pratap Singh http://blog.atulsisodia.in/

On May 30, 2014 6:15:51 PM GMT+05:30, Edward Cheng <c4150221(a)gmail.com> wrote: Ok, so you plan to display query results in the console itself. I misunderstood some details from your proposal and thought that query results will be displayed in the main panel and query logs in the console. My previous reply was according to that understanding. Also, please tell me about the following details.. - I am still unclear about warnings etc. that we display for certain queries like DROP, will we warn the user when executing such queries from console? Or would it be totally like mysql console? - Also in case user puts a USE query in console, do we change the selected database and update the navigation and main panel? Same will be required for ALTER queries etc.. Here I am pointing to the overall relation and synchronization between console and rest of the application. - And would you store the sql query logs only or the sql results history as well? I think as the results may change at any time, storing queries only should be fine. -- Atul Pratap Singh

On May 30, 2014 8:41:05 PM GMT+05:30, Edward Cheng <c4150221(a)gmail.com> wrote: Ok, I will make few comments on the commit at github soon. Bookmarks are a part of sql tab I guess, why storing them here? -- Atul Pratap Singh

2014-05-31 10:29 GMT+08:00 Edward Cheng <c4150221(a)gmail.com>om>: ​Now this feature spends my two days, remove it. I'll make this feature easy to add, if someday comes that shows we need it. -- Edward Cheng