3 Oct
2015
3 Oct
'15
3:14 a.m.
Dear developers,
The following PR is trying to use namespaces and autoloading for pMA:
https://github.com/phpmyadmin/phpmyadmin/pull/11428
This PR seems to be quite stable now. As almost all PHP files had been
updated, this is a huge work to test all cases, all configurations, all
features. Would it be possible to have some testers please?
Thanks to Marc and Isaac who already did a lot of tests.
And thanks to new testers.
Have a nice day,
H.
3 Oct
3 Oct
3:40 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 03/10/2015 09:14, Hugues Peccatte a écrit :
Dear developers,
The following PR is trying to use namespaces and autoloading for
pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
seems to be quite stable now. As almost all PHP files had been
updated, this is a huge work to test all cases, all configurations,
all features. Would it be possible to have some testers please?
At a first (and quick) look
PMA\libraries namespace seems a bit uggly...
'libraries' is a directory, only a layout artefact, why should it be
part of the namespace.
Per PSR-4 definition, namespace should be
"The fully qualified class name MUST have a top-level
namespace name, also known as a "vendor namespace".
So, is PMA the "vendor" ? it seems.
"The fully qualified class name MAY have one or
more sub-namespace names."
I think a second level is needed (but again, "libraries" seems strange
to me... but perhaps only to me)
Notice: it will be nice to move all 3rd party lib to a separate
directory (will make downstream work much easier)
Remi.
Thanks to Marc and Isaac who already did a lot of
tests. And thanks
to new testers.
Have a nice day,
H.
_______________________________________________ Developers mailing
list Developers(a)phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlYPhnsACgkQYUppBSnxahgeqQCgrqY4W1TuTzxvpiwSLcVfiVKq
lUYAoIopoJ4hHCeYEdGD7YFGsPUg6htx
=d2Wp
-----END PGP SIGNATURE-----
3:13 p.m.
Le sam. 3 oct. 2015 à 12:46, Remi Collet <remi(a)fedoraproject.org> a écrit :
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 03/10/2015 09:14, Hugues Peccatte a écrit :
Hi Remi,
Thanks for your feedback.
Why does PMA\libraries seem ugly?
OK, "libraries" is a directory, but all classes are not in libraries,
that's why I decided to set the vendor namespace (PMA) at project root. If
needed, we can imagine to have a specific vendor namespace for libraries,
but why and which one?
I saw your notice about moving 3rd party libraries. But I think this is not
the subject here.
In fact, this is a really huge work that had been done (at least, I think…)
and I think that a lot of subjects could be discussed here. That's why I'ld
like to focus on test and errors.
Had you some time to test the PR?
Thanks,
H.
Dear developers,
The following PR is trying to use namespaces and autoloading for
pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
seems to be quite stable now. As almost all PHP files had been
updated, this is a huge work to test all cases, all configurations,
all features. Would it be possible to have some testers please?
At a first (and quick) look
PMA\libraries namespace seems a bit uggly...
'libraries' is a directory, only a layout artefact, why should it be
part of the namespace.
Per PSR-4 definition, namespace should be
"The fully qualified class name MUST have a top-level
namespace name, also known as a "vendor namespace".
So, is PMA the "vendor" ? it seems.
"The fully qualified class name MAY have one or
more sub-namespace names."
I think a second level is needed (but again, "libraries" seems strange
to me... but perhaps only to me)
Notice: it will be nice to move all 3rd party lib to a separate
directory (will make downstream work much easier)
Remi.
Thanks to Marc and Isaac who already did a lot of
tests. And thanks
to new testers.
Have a nice day,
H.
_______________________________________________ Developers mailing
list Developers(a)phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlYPhnsACgkQYUppBSnxahgeqQCgrqY4W1TuTzxvpiwSLcVfiVKq
lUYAoIopoJ4hHCeYEdGD7YFGsPUg6htx
=d2Wp
-----END PGP SIGNATURE-----
5 Oct
5 Oct
1:46 p.m.
Le sam. 3 oct. 2015 à 21:13, Hugues Peccatte <hugues.peccatte(a)gmail.com> a
écrit :
Le sam. 3 oct. 2015 à 12:46, Remi Collet
<remi(a)fedoraproject.org> a
écrit :
Hi,
Any other feedback please? Or maybe we can merge…
H.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 03/10/2015 09:14, Hugues Peccatte a écrit :
Hi Remi,
Thanks for your feedback.
Why does PMA\libraries seem ugly?
OK, "libraries" is a directory, but all classes are not in libraries,
that's why I decided to set the vendor namespace (PMA) at project root. If
needed, we can imagine to have a specific vendor namespace for libraries,
but why and which one?
I saw your notice about moving 3rd party libraries. But I think this is
not the subject here.
In fact, this is a really huge work that had been done (at least, I
think…) and I think that a lot of subjects could be discussed here. That's
why I'ld like to focus on test and errors.
Had you some time to test the PR?
Thanks,
H.
Dear developers,
The following PR is trying to use namespaces and autoloading for
pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
seems to be quite stable now. As almost all PHP files had been
updated, this is a huge work to test all cases, all configurations,
all features. Would it be possible to have some testers please?
At a first (and quick) look
PMA\libraries namespace seems a bit uggly...
'libraries' is a directory, only a layout artefact, why should it be
part of the namespace.
Per PSR-4 definition, namespace should be
"The fully qualified class name MUST have a top-level
namespace name, also known as a "vendor namespace".
So, is PMA the "vendor" ? it seems.
"The fully qualified class name MAY have one or
more sub-namespace names."
I think a second level is needed (but again, "libraries" seems strange
to me... but perhaps only to me)
Notice: it will be nice to move all 3rd party lib to a separate
directory (will make downstream work much easier)
Remi.
Thanks to Marc and Isaac who already did a lot of
tests. And thanks
to new testers.
Have a nice day,
H.
_______________________________________________ Developers mailing
list Developers(a)phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlYPhnsACgkQYUppBSnxahgeqQCgrqY4W1TuTzxvpiwSLcVfiVKq
lUYAoIopoJ4hHCeYEdGD7YFGsPUg6htx
=d2Wp
-----END PGP SIGNATURE-----
3:46 p.m.
Le 2015-10-05 13:46, Hugues Peccatte a écrit :
Le sam. 3 oct. 2015 à 21:13, Hugues Peccatte
<hugues.peccatte(a)gmail.com
<mailto:hugues.peccatte@gmail.com>> a écrit :
Le sam. 3 oct. 2015 à 12:46, Remi Collet <remi(a)fedoraproject.org
<mailto:remi@fedoraproject.org>> a écrit :
Le 03/10/2015 09:14, Hugues Peccatte a écrit :
Seems ready indeed.
--
Marc Delisle | phpMyAdmin
Dear developers,
The following PR is trying to use namespaces and
autoloading for
pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
seems to be quite stable now. As almost all PHP files had been
updated, this is a huge work to test all cases, all
configurations,
all features. Would it be possible to have some
testers please?
At a first (and quick) look
PMA\libraries namespace seems a bit uggly...
'libraries' is a directory, only a layout artefact, why should it be
part of the namespace.
Per PSR-4 definition, namespace should be
"The fully qualified class name MUST have a top-level
namespace name, also known as a "vendor namespace".
So, is PMA the "vendor" ? it seems.
"The fully qualified class name MAY have one or
more sub-namespace names."
I think a second level is needed (but again, "libraries" seems
strange
to me... but perhaps only to me)
Notice: it will be nice to move all 3rd party lib to a separate
directory (will make downstream work much easier)
Remi.
Thanks to Marc and Isaac who already did a lot of
tests. And
thanks
to new testers.
Have a nice day,
H.
_______________________________________________
Developers mailing
list Developers(a)phpmyadmin.net <mailto:Developers@phpmyadmin.net>
https://lists.phpmyadmin.net/mailman/listinfo/developers
Hi Remi,
Thanks for your feedback.
Why does PMA\libraries seem ugly?
OK, "libraries" is a directory, but all classes are not in
libraries, that's why I decided to set the vendor namespace (PMA) at
project root. If needed, we can imagine to have a specific vendor
namespace for libraries, but why and which one?
I saw your notice about moving 3rd party libraries. But I think this
is not the subject here.
In fact, this is a really huge work that had been done (at least, I
think…) and I think that a lot of subjects could be discussed here.
That's why I'ld like to focus on test and errors.
Had you some time to test the PR?
Thanks,
H.
Hi,
Any other feedback please? Or maybe we can merge…
6 Oct
6 Oct
2:47 p.m.
Le lun. 5 oct. 2015 à 22:07, Marc Delisle <marc(a)infomarc.info> a écrit :
Le 2015-10-05 13:46, Hugues Peccatte a écrit :
Hi,
Thanks for your answer Marc.
I'll merge again master in the branch and then it should be OK. Do you want
me to do the merge (by GitHub)?
H.
Le sam. 3 oct. 2015 à 21:13, Hugues Peccatte
<hugues.peccatte(a)gmail.com
<mailto:hugues.peccatte@gmail.com>> a écrit :
Le sam. 3 oct. 2015 à 12:46, Remi Collet <remi(a)fedoraproject.org
<mailto:remi@fedoraproject.org>> a écrit :
Le 03/10/2015 09:14, Hugues Peccatte a écrit :
Seems ready indeed.
--
Marc Delisle | phpMyAdmin
Dear developers,
The following PR is trying to use namespaces and
autoloading for
pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
seems to be quite stable now. As almost all PHP files had been
updated, this is a huge work to test all cases, all
configurations,
all features. Would it be possible to have some
testers please?
At a first (and quick) look
PMA\libraries namespace seems a bit uggly...
'libraries' is a directory, only a layout artefact, why should it be
part of the namespace.
Per PSR-4 definition, namespace should be
"The fully qualified class name MUST have a top-level
namespace name, also known as a "vendor namespace".
So, is PMA the "vendor" ? it seems.
"The fully qualified class name MAY have one or
more sub-namespace names."
I think a second level is needed (but again, "libraries" seems
strange
to me... but perhaps only to me)
Notice: it will be nice to move all 3rd party lib to a separate
directory (will make downstream work much easier)
Remi.
Thanks to Marc and Isaac who already did a lot of
tests. And
thanks
to new testers.
Have a nice day,
H.
_______________________________________________
Developers mailing
list Developers(a)phpmyadmin.net <mailto:Developers@phpmyadmin.net>
https://lists.phpmyadmin.net/mailman/listinfo/developers
Hi Remi,
Thanks for your feedback.
Why does PMA\libraries seem ugly?
OK, "libraries" is a directory, but all classes are not in
libraries, that's why I decided to set the vendor namespace (PMA) at
project root. If needed, we can imagine to have a specific vendor
namespace for libraries, but why and which one?
I saw your notice about moving 3rd party libraries. But I think this
is not the subject here.
In fact, this is a really huge work that had been done (at least, I
think…) and I think that a lot of subjects could be discussed here.
That's why I'ld like to focus on test and errors.
Had you some time to test the PR?
Thanks,
H.
Hi,
Any other feedback please? Or maybe we can merge…
4:13 p.m.
Le 2015-10-06 14:47, Hugues Peccatte a écrit :
Le lun. 5 oct. 2015 à 22:07, Marc Delisle
<marc(a)infomarc.info
<mailto:marc@infomarc.info>> a écrit :
Le 2015-10-05 13:46, Hugues Peccatte a écrit :
Please do.
--
Marc Delisle | phpMyAdmin
Le sam. 3 oct. 2015 à 21:13, Hugues Peccatte
<hugues.peccatte(a)gmail.com <mailto:hugues.peccatte@gmail.com>
<mailto:hugues.peccatte@gmail.com
<mailto:hugues.peccatte@gmail.com>>> a écrit :
Le sam. 3 oct. 2015 à 12:46, Remi Collet
<remi(a)fedoraproject.org
<mailto:remi@fedoraproject.org>
<mailto:remi@fedoraproject.org
<mailto:remi@fedoraproject.org>>> a écrit :
Le 03/10/2015 09:14, Hugues Peccatte a écrit :
<mailto:Developers@phpmyadmin.net <mailto:Developers@phpmyadmin.net>>
Dear developers,
The following PR is trying to use namespaces and
autoloading for
pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
seems to be quite stable now. As almost all PHP files had been
updated, this is a huge work to test all cases, all
configurations,
all features. Would it be possible to have some
testers please?
At a first (and quick) look
PMA\libraries namespace seems a bit uggly...
'libraries' is a directory, only a layout artefact, why should it be
part of the namespace.
Per PSR-4 definition, namespace should be
"The fully qualified class name MUST have a top-level
namespace name, also known as a "vendor namespace".
So, is PMA the "vendor" ? it seems.
"The fully qualified class name MAY have one or
more sub-namespace names."
I think a second level is needed (but again, "libraries" seems
strange
to me... but perhaps only to me)
Notice: it will be nice to move all 3rd party lib to a separate
directory (will make downstream work much easier)
Remi.
Thanks to Marc and Isaac who already did a lot of
tests. And
thanks
to new testers.
Have a nice day,
H.
> _______________________________________________ Developers mailing
> list Developers(a)phpmyadmin.net <mailto:Developers@phpmyadmin.net>
Hi Remi,
Thanks for your feedback.
Why does PMA\libraries seem ugly?
OK, "libraries" is a directory, but all classes are not in
libraries, that's why I decided to set the vendor namespace
(PMA) at
project root. If needed, we can imagine to
have a specific vendor
namespace for libraries, but why and which one?
I saw your notice about moving 3rd party libraries. But I
think this
is not the subject here.
In fact, this is a really huge work that had been done (at
least, I
think…) and I think that a lot of subjects
could be discussed
here.
That's why I'ld like to focus on test
and errors.
Had you some time to test the PR?
Thanks,
H.
Hi,
Any other feedback please? Or maybe we can merge…
Seems ready indeed.
--
Marc Delisle | phpMyAdmin
Hi,
Thanks for your answer Marc.
I'll merge again master in the branch and then it should be OK. Do you
want me to do the merge (by GitHub)?
7 Oct
7 Oct
2:25 p.m.
Le mar. 6 oct. 2015 à 22:35, Marc Delisle <marc(a)infomarc.info> a écrit :
Le 2015-10-06 14:47, Hugues Peccatte a écrit :
vendor
Please do.
--
Marc Delisle | phpMyAdmin
Hi everyone,
The merge will be done in some minutes. I just wait for the return of
https://travis-ci.org/phpmyadmin/phpmyadmin/builds/84153692
H.
Le lun. 5 oct. 2015 à 22:07, Marc Delisle
<marc(a)infomarc.info
<mailto:marc@infomarc.info>> a écrit :
Le 2015-10-05 13:46, Hugues Peccatte a écrit :
be
Le sam. 3 oct. 2015 à 21:13, Hugues Peccatte
<hugues.peccatte(a)gmail.com <mailto:hugues.peccatte@gmail.com>
<mailto:hugues.peccatte@gmail.com
<mailto:hugues.peccatte@gmail.com>>> a écrit :
Le sam. 3 oct. 2015 à 12:46, Remi Collet
<remi(a)fedoraproject.org
<mailto:remi@fedoraproject.org>
<mailto:remi@fedoraproject.org
<mailto:remi@fedoraproject.org>>> a écrit :
>
> Le 03/10/2015 09:14, Hugues Peccatte a écrit :
>> Dear developers,
>
>> The following PR is trying to use namespaces and autoloading for
>> pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
>> seems to be quite stable now. As almost all PHP files had been
>> updated, this is a huge work to test all cases, all
> configurations,
>> all features. Would it be possible to have some testers please?
>
> At a first (and quick) look
>
> PMA\libraries namespace seems a bit uggly...
>
> 'libraries' is a directory, only a layout artefact, why should it part of
the namespace.
Per PSR-4 definition, namespace should be
"The fully qualified class name MUST have a top-level
namespace name, also known as a "vendor namespace".
So, is PMA the "vendor" ? it seems.
"The fully qualified class name MAY have one or
more sub-namespace names."
I think a second level is needed (but again, "libraries" seems
strange
to me... but perhaps only to me)
Notice: it will be nice to move all 3rd party lib to a separate
directory (will make downstream work much easier)
Remi.
<mailto:Developers@phpmyadmin.net <mailto:Developers@phpmyadmin.net
Thanks to Marc and Isaac who already did a lot of
tests. And
thanks
to new testers.
Have a nice day,
H.
> _______________________________________________ Developers mailing
> list Developers(a)phpmyadmin.net <mailto:Developers@phpmyadmin.net>
Hi Remi,
Thanks for your feedback.
Why does PMA\libraries seem ugly?
OK, "libraries" is a directory, but all classes are not in
libraries, that's why I decided to set the vendor namespace
(PMA) at
> project root. If needed, we can imagine to have a specific
namespace for libraries, but why and which one?
I saw your notice about moving 3rd party libraries. But I
think this
is not the subject here.
In fact, this is a really huge work that had been done (at
least, I
think…) and I think that a lot of subjects
could be discussed
here.
That's why I'ld like to focus on test
and errors.
Had you some time to test the PR?
Thanks,
H.
Hi,
Any other feedback please? Or maybe we can merge…
Seems ready indeed.
--
Marc Delisle | phpMyAdmin
Hi,
Thanks for your answer Marc.
I'll merge again master in the branch and then it should be OK. Do you
want me to do the merge (by GitHub)?
2:48 p.m.
Le mer. 7 oct. 2015 à 20:25, Hugues Peccatte <hugues.peccatte(a)gmail.com> a
écrit :
Le mar. 6 oct. 2015 à 22:35, Marc Delisle
<marc(a)infomarc.info> a écrit :
Merged.
I hope that we won't find to many errors. If you encounter errors, please
tell me.
Hugues.
Le 2015-10-06 14:47, Hugues Peccatte a écrit :
vendor
Please do.
--
Marc Delisle | phpMyAdmin
Hi everyone,
The merge will be done in some minutes. I just wait for the return of
https://travis-ci.org/phpmyadmin/phpmyadmin/builds/84153692
H.
Le lun. 5 oct. 2015 à 22:07, Marc Delisle
<marc(a)infomarc.info
<mailto:marc@infomarc.info>> a écrit :
Le 2015-10-05 13:46, Hugues Peccatte a écrit :
be
Le sam. 3 oct. 2015 à 21:13, Hugues Peccatte
<hugues.peccatte(a)gmail.com <mailto:hugues.peccatte@gmail.com>
<mailto:hugues.peccatte@gmail.com
<mailto:hugues.peccatte@gmail.com>>> a écrit :
Le sam. 3 oct. 2015 à 12:46, Remi Collet
<remi(a)fedoraproject.org
<mailto:remi@fedoraproject.org>
<mailto:remi@fedoraproject.org
<mailto:remi@fedoraproject.org>>> a écrit :
>
> Le 03/10/2015 09:14, Hugues Peccatte a écrit :
>> Dear developers,
>
>> The following PR is trying to use namespaces and autoloading for
>> pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
>> seems to be quite stable now. As almost all PHP files had been
>> updated, this is a huge work to test all cases, all
> configurations,
>> all features. Would it be possible to have some testers please?
>
> At a first (and quick) look
>
> PMA\libraries namespace seems a bit uggly...
>
> 'libraries' is a directory, only a layout artefact, why should it > part of the namespace.
>
> Per PSR-4 definition, namespace should be
>
> "The fully qualified class name MUST have a top-level
> namespace name, also known as a "vendor namespace".
>
> So, is PMA the "vendor" ? it seems.
>
> "The fully qualified class name MAY have one or
> more sub-namespace names."
>
> I think a second level is needed (but again, "libraries" seems
> strange
> to me... but perhaps only to me)
>
> Notice: it will be nice to move all 3rd party lib to a separate
> directory (will make downstream work much easier)
>
> Remi.
>
>> Thanks to Marc and Isaac who already did a lot of tests. And
> thanks
>> to new testers.
>
>> Have a nice day,
>
>> H.
>
>
>> _______________________________________________ Developers
mailing
> list
Developers(a)phpmyadmin.net <mailto:Developers@phpmyadmin.net
<mailto:Developers@phpmyadmin.net <mailto:Developers@phpmyadmin.net
> https://lists.phpmyadmin.net/mailman/listinfo/developers
Hi Remi,
Thanks for your feedback.
Why does PMA\libraries seem ugly?
OK, "libraries" is a directory, but all classes are not in
libraries, that's why I decided to set the vendor namespace
(PMA) at
> project root. If needed, we can imagine to have a specific
namespace for libraries, but why and which one?
I saw your notice about moving 3rd party libraries. But I
think this
is not the subject here.
In fact, this is a really huge work that had been done (at
least, I
think…) and I think that a lot of subjects
could be discussed
here.
That's why I'ld like to focus on test
and errors.
Had you some time to test the PR?
Thanks,
H.
Hi,
Any other feedback please? Or maybe we can merge…
Seems ready indeed.
--
Marc Delisle | phpMyAdmin
Hi,
Thanks for your answer Marc.
I'll merge again master in the branch and then it should be OK. Do you
want me to do the merge (by GitHub)?
3216
days inactive
3220
days old
8 comments
3 participants
participants (3)
-
Hugues Peccatte -
Marc Delisle -
Remi Collet