[Phpmyadmin-devel] MS Excel export

[Michal Čihař]

Hi

On 07.06.2004 17:49 +0200, Garvin Hicking wrote:
> I currently don't have the spreadsheet-class installed, but will do so tonight.
> Your code however looks clean, so I don't think that there'll be problems.
> 
> Love the implementatio, it's a good benefit.
> 
> However I was thinking if we really need a new TempDir setting? Couldn't we
> combine that with SaveDir?

It is used just for temporary files, so it should be separate directory
(and in case php ocassionaly crashes, that directory should be cleaned
up).

> And maybe we should use @include_once when probing for the spreadsheet file no
> not generate errors.

Ooops, I removed @ during testing, adding back.

> And if the class was not found, we could set $xls to a
> string and on the export screen display a link/message that you can use the
> PEAR-class if you want native CSV/XLS export.
                                ^^^^^^^ just XLS, CVS is always native :-))

Okay, I will add one more message.

-- 
Regards
	Michal Čihař
	http://cihar.com