[Phpmyadmin-devel] Scrutinizer's false alarms

[Chirayu Chiripal]

On Tue, May 27, 2014 at 10:45 PM, Hugues Peccatte <hugues.peccatte at gmail.com
> wrote:

> 2014-05-27 18:53 GMT+02:00 Marc Delisle <marc at infomarc.info>:
>
> Hi,
>> I found out that some bug reports by Scrutinizer are wrong. For example,
>> in [0], the PHP Analyzer reports that you cannot assign a return value
>> because mysqli_init() always returns null, which is not the case.
>>
>> [0]
>>
>> https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/dbi/DBIMysqli.class.php?selectedLabels[0]=9&orderField=path&order=asc
>>
>> --
>> Marc Delisle (phpMyAdmin)
>
>
> Hi,
>
> Another one is this one:
> https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/DBQbe.class.php?selectedAuthors%5B0%5D=hugues.peccatte%40gmail.com&orderField=path&order=asc
> Scrutinizer believes that the method isn't doing anything, but it is
> overwriting $_REQUEST. It seems that Scrutinizer doesn't understand this.
>
> H.
>
>

Hi,

There are many more such issues which includes:

1) function duplication in which 2 functions which are completely different
are reported as duplicated ones. For e.g.
https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/indices/152775/duplications/2920437

2)
https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/issues/master/files/libraries/DisplayResults.class.php?selectedAuthors[0]=chirayu.chiripal%40gmail.com&orderField=path&order=asc
The method getMIMEtype cannot be called on $transformation_plugin (of type
string). In the if condition it is checked first that $transformation_plugin
is of type object and then method getMIMEtype is called.

There are more than one instances of reports which are mentioned above.They
need to be reported as false positives.

-- 
Regards,
Chirayu Chiripal
phpMyAdmin Intern - Google Summer of Code 2014
https://chirayuchiripal.wordpress.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140528/8021328c/attachment.html>