[phpMyAdmin Developers] SQL parser handling

[Dan Ungureanu]

On Tue, Feb 9, 2016 at 12:17 PM, Michal Čihař <michal at cihar.com> wrote:

> Hi all
>
> current handlig of SQL parser code is less than optimal - it's developed
> in external repository and at "random" times copied to phpMyAdmin. That
> makes it quite hard to maintain - the fixes made in phpMyAdmin
> repository will be probably lost and it's hard to track what version
> went it.
>
> Therefore I suggest:
>
> - to move sql-parser git repo under phpmyadmin
> - to use sql-parser as submodule in phpmyadmin
>
> This way, all development of SQL parser will be in single Git repository
> where all phpMyAdmin developers have access.
>
> There are alternative approaches to handle this, but I find this best
> fitting our current model (no external dependencies).
>
> [1]:https://github.com/udan11/sql-parser
>
> --
>         Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> _______________________________________________
> Developers mailing list
> Developers at phpmyadmin.net
> https://lists.phpmyadmin.net/mailman/listinfo/developers
>
>
Hello,

The first time I sent my proposal for Google Summer of Code 2015 I tried
finding libraries that would fit phpMyAdmin. Because I found none I thought
that I could create a library on my own hoping that others (not only
phpMyAdmin) would benefit from it and will help developing it (testing,
sending bug reports, etc). I talked with Marc and he seemed to be fine with
this.

After the summer ended, I was planning on talking with Marc to transfer the
library to phpMyAdmin, but I did not get to do that. Hopefully, we can do
this soon.

In my opinion, the best option would be to manage dependencies with
Composer, but I proposed this in the past and people did not consider this
a very good idea. Anyway, I still believe that keeping the library in a
different repository is the best way because:
 - it makes bug fixing easier; no need to merge upstream, older versions of
phpMyAdmin may be easier to patch, etc;
 - the changes to the library don't pollute the change log of phpMyAdmin;
 - it is designed as a "module" to phpMyAdmin and the logic related to SQL
queries is separated;
 - maybe at some time in the future the library will also be used in other
projects.

I am looking forward for more suggestions. During the past couple of weeks
I have been quite inactive, but I am done with exams for now and in the
next days I am hoping to send fixes prepared for most issues that I
assigned to myself.

Best regards,
Dan Ungureanu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.phpmyadmin.net/pipermail/developers/attachments/20160209/8772a2d0/attachment.html>