On Mar 27, 2014, at 7:46 AM, Isaac Bennetch <bennetch@gmail.com> wrote:

On Mar 26, 2014, at 6:56 PM, Marc Delisle <marc@infomarc.info> wrote:

...

Hi,

The favorite tables feature is now in master. The expected place to store favorite tables is in pmadb and this is what it does. However it can also store them in the session if pmadb is not ready for this feature.

I am not sure of the purpose of storing this in the session; on the contrary, it can make the user believe that the favorite tables have been stored, only to see them gone at the next login.

Comments?

I think you're right, in this case it seems quite reasonable on require the phpMyAdmin Configuration Storage. The session storage portion should be removed so we don't confuse and mislead users.

...unless we consider storing it in the local storage (not session, which will expire), that way it is limited to only that computer/browser but will work across login sessions. Do you have an opinion about this?

...

-- Marc Delisle

------------------------------------------------------------------------------ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

Minhaz A V a écrit :

I agree with Issac, it would be better to store this data in local storge. It can be stored for long time and be easily altered by client side scripts making it most suitable.

Isaac did not suggest storing in local storage, but in phpMyAdmin configuration storage [0]. [0] http://docs.phpmyadmin.net/en/latest/setup.html#phpmyadmin-configuration-sto... -- Marc Delisle