[Phpmyadmin-devel] Refactoring tbl_zoom_select.php
Hi Marc, While looking at "tbl_zoom_select.php":- Line 191-201 if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] != 'pma_null')) { $flag = 2; for ($i = 0 ; $i < 4 ; $i++) { if ($inputs[$i] != 'pma_null') { $key = array_search($inputs[$i], $fields_list); $tbl_fields_type[$i] = $fields_type[$key]; $tbl_fields_collation[$i] = $fields_collation[$key]; $tbl_fields_null[$i] = $fields_null[$key]; } } } As the condition would be true in cases when post param $inputs is set and has index 0 or 1 set to some column name. It would mostly happen if a half or full filled search form is submitted, but there seems to be no further use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type gets used afterwards with indexes >= 4. I think as a result after the zoom plot is displayed, clicking at "show search criteria" doesn't show any previously filled criteria. I also didn't understand the use of $flag variable. Thanks -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Le 2012-05-29 10:46, Atul Pratap Singh a écrit :
Hi Marc, While looking at "tbl_zoom_select.php":-
Line 191-201 if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] != 'pma_null')) { $flag = 2; for ($i = 0 ; $i < 4 ; $i++) { if ($inputs[$i] != 'pma_null') { $key = array_search($inputs[$i], $fields_list); $tbl_fields_type[$i] = $fields_type[$key]; $tbl_fields_collation[$i] = $fields_collation[$key]; $tbl_fields_null[$i] = $fields_null[$key]; } } }
As the condition would be true in cases when post param $inputs is set and has index 0 or 1 set to some column name. It would mostly happen if a half or full filled search form is submitted, but there seems to be no further use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type gets used afterwards with indexes >= 4.
Atul, Indeed, $tbl_fields_collation and $tbl_fields_null could be removed.
I think as a result after the zoom plot is displayed, clicking at "show search criteria" doesn't show any previously filled criteria.
Well, I see the chosen two column names, but indeed there seems to be a bug because at least the operator and value should be displayed.
I also didn't understand the use of $flag variable.
This must have been some debugging info, you can safely remove it.
Thanks
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info
On Tue, May 29, 2012 at 10:04 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-05-29 10:46, Atul Pratap Singh a écrit :
Hi Marc, While looking at "tbl_zoom_select.php":-
Line 191-201 if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] != 'pma_null')) { $flag = 2; for ($i = 0 ; $i < 4 ; $i++) { if ($inputs[$i] != 'pma_null') { $key = array_search($inputs[$i], $fields_list); $tbl_fields_type[$i] = $fields_type[$key]; $tbl_fields_collation[$i] = $fields_collation[$key]; $tbl_fields_null[$i] = $fields_null[$key]; } } }
As the condition would be true in cases when post param $inputs is set and has index 0 or 1 set to some column name. It would mostly happen if a half or full filled search form is submitted, but there seems to be no further use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type gets used afterwards with indexes >= 4.
Atul, Indeed, $tbl_fields_collation and $tbl_fields_null could be removed.
I think as a result after the zoom plot is displayed, clicking at "show search criteria" doesn't show any previously filled criteria.
Well, I see the chosen two column names, but indeed there seems to be a bug because at least the operator and value should be displayed.
Ok Marc, I'll remove the bug and also any unused variables.
I also didn't understand the use of $flag variable.
This must have been some debugging info, you can safely remove it.
Thanks
------------------------------------------------------------------------------
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Le 2012-05-29 15:34, Atul Pratap Singh a écrit :
On Tue, May 29, 2012 at 10:04 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-05-29 10:46, Atul Pratap Singh a écrit :
Hi Marc, While looking at "tbl_zoom_select.php":-
Line 191-201 if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] != 'pma_null')) { $flag = 2; for ($i = 0 ; $i < 4 ; $i++) { if ($inputs[$i] != 'pma_null') { $key = array_search($inputs[$i], $fields_list); $tbl_fields_type[$i] = $fields_type[$key]; $tbl_fields_collation[$i] = $fields_collation[$key]; $tbl_fields_null[$i] = $fields_null[$key]; } } }
As the condition would be true in cases when post param $inputs is set and has index 0 or 1 set to some column name. It would mostly happen if a half or full filled search form is submitted, but there seems to be no further use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type gets used afterwards with indexes >= 4.
Atul, Indeed, $tbl_fields_collation and $tbl_fields_null could be removed.
I think as a result after the zoom plot is displayed, clicking at "show search criteria" doesn't show any previously filled criteria.
Well, I see the chosen two column names, but indeed there seems to be a bug because at least the operator and value should be displayed.
Ok Marc, I'll remove the bug and also any unused variables.
The bug was introduced by https://github.com/phpmyadmin/phpmyadmin/commit/9be5d8e02ae431be040e655da0eb.... Beware that js/tbl_zoom_plot.js has been renamed to js/tbl_zoom_plot_jqplot.js when I made the changes from Highcharts to jqplot.
I also didn't understand the use of $flag variable.
This must have been some debugging info, you can safely remove it.
Thanks
------------------------------------------------------------------------------
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info
On Wed, May 30, 2012 at 1:53 AM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-05-29 15:34, Atul Pratap Singh a écrit :
On Tue, May 29, 2012 at 10:04 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-05-29 10:46, Atul Pratap Singh a écrit :
Hi Marc, While looking at "tbl_zoom_select.php":-
Line 191-201 if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] != 'pma_null')) { $flag = 2; for ($i = 0 ; $i < 4 ; $i++) { if ($inputs[$i] != 'pma_null') { $key = array_search($inputs[$i], $fields_list); $tbl_fields_type[$i] = $fields_type[$key]; $tbl_fields_collation[$i] = $fields_collation[$key]; $tbl_fields_null[$i] = $fields_null[$key]; } } }
As the condition would be true in cases when post param $inputs is set and has index 0 or 1 set to some column name. It would mostly happen if a half or full filled search form is submitted, but there seems to be no further use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type gets used afterwards with indexes >= 4.
Atul, Indeed, $tbl_fields_collation and $tbl_fields_null could be removed.
I think as a result after the zoom plot is displayed, clicking at "show search criteria" doesn't show any previously filled criteria.
Well, I see the chosen two column names, but indeed there seems to be a bug because at least the operator and value should be displayed.
Ok Marc, I'll remove the bug and also any unused variables.
The bug was introduced by
https://github.com/phpmyadmin/phpmyadmin/commit/9be5d8e02ae431be040e655da0eb... .
Beware that js/tbl_zoom_plot.js has been renamed to js/tbl_zoom_plot_jqplot.js when I made the changes from Highcharts to jqplot.
Thanks Marc, I have tried to fix the bug for now. Please check [0].
Also, I have noticed that in case of updating the field information using AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box. 1. Open zoom search for a table with at least a field of timestamp type 2. Select the timestamp type column from dropdown. 3. Notice simply an input box without datepicker. [0] https://github.com/zixtor/phpmyadmin/commit/b37066c4a4cf9b19ee98742837b01fb2...
I also didn't understand the use of $flag variable.
This must have been some debugging info, you can safely remove it.
Thanks
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Le 2012-05-30 08:20, Atul Pratap Singh a écrit :
Thanks Marc,
I have tried to fix the bug for now. Please check [0].
Works fine now, thanks.
Also, I have noticed that in case of updating the field information using AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box. 1. Open zoom search for a table with at least a field of timestamp type 2. Select the timestamp type column from dropdown. 3. Notice simply an input box without datepicker.
The bug is not present in upstream QA_3_5 branch. Please use "git bisect" to find its cause, see [0]. [0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit -- Marc Delisle http://infomarc.info
On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-05-30 08:20, Atul Pratap Singh a écrit :
Thanks Marc,
I have tried to fix the bug for now. Please check [0].
Works fine now, thanks.
Also, I have noticed that in case of updating the field information using AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box. 1. Open zoom search for a table with at least a field of timestamp type 2. Select the timestamp type column from dropdown. 3. Notice simply an input box without datepicker.
The bug is not present in upstream QA_3_5 branch. Please use "git bisect" to find its cause, see [0].
[0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit
Ok, I'll do that.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
On Thu, May 31, 2012 at 4:18 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-05-30 08:20, Atul Pratap Singh a écrit :
Thanks Marc,
I have tried to fix the bug for now. Please check [0].
Works fine now, thanks.
Also, I have noticed that in case of updating the field information
using
AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box. 1. Open zoom search for a table with at least a field of timestamp type 2. Select the timestamp type column from dropdown. 3. Notice simply an input box without datepicker.
The bug is not present in upstream QA_3_5 branch. Please use "git bisect" to find its cause, see [0].
[0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit
Ok, I'll do that.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Hi Marc, I noticed that in zoom search the initial display's data labels are not correct in Chromium browser too. Line 533 (tbl_zoom_plot_jqplot.js) // under IE 8, the initial display is mangled; after a manual // resizing, it's ok // under IE 9, everything is fine currentChart = $.jqplot('querychart', series, options); Should I add 'currentChart.resetZoom();' here to automatically reset the zoom plot? -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Le 2012-06-08 05:20, Atul Pratap Singh a écrit :
On Thu, May 31, 2012 at 4:18 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-05-30 08:20, Atul Pratap Singh a écrit :
Thanks Marc,
I have tried to fix the bug for now. Please check [0].
Works fine now, thanks.
Also, I have noticed that in case of updating the field information
using
AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box. 1. Open zoom search for a table with at least a field of timestamp type 2. Select the timestamp type column from dropdown. 3. Notice simply an input box without datepicker.
The bug is not present in upstream QA_3_5 branch. Please use "git bisect" to find its cause, see [0].
[0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit
Ok, I'll do that.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Hi Marc, I noticed that in zoom search the initial display's data labels are not correct in Chromium browser too.
Line 533 (tbl_zoom_plot_jqplot.js) // under IE 8, the initial display is mangled; after a manual // resizing, it's ok // under IE 9, everything is fine currentChart = $.jqplot('querychart', series, options);
Should I add 'currentChart.resetZoom();' here to automatically reset the zoom plot?
Hi Atul, I have to do further testing because I currently have a problem under IE 8 with zoom search, in upstream master. -- Marc Delisle http://infomarc.info
On Fri, Jun 8, 2012 at 5:37 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-08 05:20, Atul Pratap Singh a écrit :
On Thu, May 31, 2012 at 4:18 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc@infomarc.info>
wrote:
Le 2012-05-30 08:20, Atul Pratap Singh a écrit :
Thanks Marc,
I have tried to fix the bug for now. Please check [0].
Works fine now, thanks.
Also, I have noticed that in case of updating the field information
using
AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box. 1. Open zoom search for a table with at least a field of timestamp
type
2. Select the timestamp type column from dropdown. 3. Notice simply an input box without datepicker.
The bug is not present in upstream QA_3_5 branch. Please use "git bisect" to find its cause, see [0].
[0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit
Ok, I'll do that.
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Hi Marc, I noticed that in zoom search the initial display's data labels are not correct in Chromium browser too.
Line 533 (tbl_zoom_plot_jqplot.js) // under IE 8, the initial display is mangled; after a manual // resizing, it's ok // under IE 9, everything is fine currentChart = $.jqplot('querychart', series, options);
Should I add 'currentChart.resetZoom();' here to automatically reset the zoom plot?
Hi Atul, I have to do further testing because I currently have a problem under IE 8 with zoom search, in upstream master.
Ok Marc.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Le 2012-06-08 08:46, Atul Pratap Singh a écrit :
On Fri, Jun 8, 2012 at 5:37 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-08 05:20, Atul Pratap Singh a écrit :
On Thu, May 31, 2012 at 4:18 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc@infomarc.info>
wrote:
Le 2012-05-30 08:20, Atul Pratap Singh a écrit :
> > Thanks Marc, I have tried to fix the bug for now. Please check [0].
Works fine now, thanks.
Also, I have noticed that in case of updating the field information
using
AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box. 1. Open zoom search for a table with at least a field of timestamp
type
2. Select the timestamp type column from dropdown. 3. Notice simply an input box without datepicker.
The bug is not present in upstream QA_3_5 branch. Please use "git bisect" to find its cause, see [0].
[0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit
Ok, I'll do that.
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Hi Marc, I noticed that in zoom search the initial display's data labels are not correct in Chromium browser too.
Line 533 (tbl_zoom_plot_jqplot.js) // under IE 8, the initial display is mangled; after a manual // resizing, it's ok // under IE 9, everything is fine currentChart = $.jqplot('querychart', series, options);
Should I add 'currentChart.resetZoom();' here to automatically reset the zoom plot?
Hi Atul, I have to do further testing because I currently have a problem under IE 8 with zoom search, in upstream master.
Ok Marc.
Atul, messages to phpmyadmin-devel are delayed so you are CC'd in this reply. I have fixed the problem I had under IE 8 and 9 (nothing was happening when selecting a column as a criteria), see commit f6330a3f1773092d2e07c6da65116436e0c96187. Then I have tried your suggestion about adding a resetZoom() but it does not fix the problem under IE 9. Please CC me in your reply. -- Marc Delisle http://infomarc.info
On Sun, Jun 10, 2012 at 5:34 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-08 08:46, Atul Pratap Singh a écrit :
On Fri, Jun 8, 2012 at 5:37 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-08 05:20, Atul Pratap Singh a écrit :
On Thu, May 31, 2012 at 4:18 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc@infomarc.info>
wrote:
Le 2012-05-30 08:20, Atul Pratap Singh a écrit :
>> >> Thanks Marc, > I have tried to fix the bug for now. Please check [0].
Works fine now, thanks.
> > Also, I have noticed that in case of updating the field information using > AJAX (line 91) the class="textfield datetimefield" attribute doesn't work > and a timestamp type field is also displayed with simply an input
box.
> 1. Open zoom search for a table with at least a field of timestamp type > 2. Select the timestamp type column from dropdown. > 3. Notice simply an input box without datepicker.
The bug is not present in upstream QA_3_5 branch. Please use "git bisect" to find its cause, see [0].
[0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit
Ok, I'll do that.
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Hi Marc, I noticed that in zoom search the initial display's data labels are not correct in Chromium browser too.
Line 533 (tbl_zoom_plot_jqplot.js) // under IE 8, the initial display is mangled; after a manual // resizing, it's ok // under IE 9, everything is fine currentChart = $.jqplot('querychart', series, options);
Should I add 'currentChart.resetZoom();' here to automatically reset the zoom plot?
Hi Atul, I have to do further testing because I currently have a problem under IE 8 with zoom search, in upstream master.
Ok Marc.
Atul, messages to phpmyadmin-devel are delayed so you are CC'd in this reply.
I have fixed the problem I had under IE 8 and 9 (nothing was happening when selecting a column as a criteria), see commit f6330a3f1773092d2e07c6da65116436e0c96187.
Then I have tried your suggestion about adding a resetZoom() but it does not fix the problem under IE 9.
Please CC me in your reply.
Marc, Adding a resetZoom() fixed it in chromium and firefox doesn't have the problem I think. About IE 9, it seems it doesn't work in my XP virtual machine. I'll be able to see it soon in IE 9 after installing my Windows 7 copy.
-- Marc Delisle http://infomarc.info
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Le 2012-06-10 09:35, Atul Pratap Singh a écrit :
On Sun, Jun 10, 2012 at 5:34 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-08 08:46, Atul Pratap Singh a écrit :
On Fri, Jun 8, 2012 at 5:37 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-08 05:20, Atul Pratap Singh a écrit :
On Thu, May 31, 2012 at 4:18 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc@infomarc.info>
wrote:
> Le 2012-05-30 08:20, Atul Pratap Singh a écrit : > >>> >>> Thanks Marc, >> I have tried to fix the bug for now. Please check [0]. > > Works fine now, thanks. > >> >> Also, I have noticed that in case of updating the field information > using >> AJAX (line 91) the class="textfield datetimefield" attribute doesn't > work >> and a timestamp type field is also displayed with simply an input
box.
>> 1. Open zoom search for a table with at least a field of timestamp type >> 2. Select the timestamp type column from dropdown. >> 3. Notice simply an input box without datepicker. > > The bug is not present in upstream QA_3_5 branch. Please use "git > bisect" to find its cause, see [0]. > > [0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit > > Ok, I'll do that.
> -- > Marc Delisle > http://infomarc.info > > > >
> Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > >
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Hi Marc, I noticed that in zoom search the initial display's data labels are not correct in Chromium browser too.
Line 533 (tbl_zoom_plot_jqplot.js) // under IE 8, the initial display is mangled; after a manual // resizing, it's ok // under IE 9, everything is fine currentChart = $.jqplot('querychart', series, options);
Should I add 'currentChart.resetZoom();' here to automatically reset the zoom plot?
Hi Atul, I have to do further testing because I currently have a problem under IE 8 with zoom search, in upstream master.
Ok Marc.
Atul, messages to phpmyadmin-devel are delayed so you are CC'd in this reply.
I have fixed the problem I had under IE 8 and 9 (nothing was happening when selecting a column as a criteria), see commit f6330a3f1773092d2e07c6da65116436e0c96187.
Then I have tried your suggestion about adding a resetZoom() but it does not fix the problem under IE 9.
Please CC me in your reply.
Marc, Adding a resetZoom() fixed it in chromium and firefox doesn't have the problem I think.
Atul, so please add the resetZoom() call in your tree.
About IE 9, it seems it doesn't work in my XP virtual machine. I'll be able to see it soon in IE 9 after installing my Windows 7 copy.
-- Marc Delisle http://infomarc.info
On Mon, Jun 11, 2012 at 2:43 AM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-10 09:35, Atul Pratap Singh a écrit :
On Sun, Jun 10, 2012 at 5:34 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-08 08:46, Atul Pratap Singh a écrit :
On Fri, Jun 8, 2012 at 5:37 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-06-08 05:20, Atul Pratap Singh a écrit :
On Thu, May 31, 2012 at 4:18 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
> > > On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc@infomarc.info> wrote: > >> Le 2012-05-30 08:20, Atul Pratap Singh a écrit : >> >>>> >>>> Thanks Marc, >>> I have tried to fix the bug for now. Please check [0]. >> >> Works fine now, thanks. >> >>> >>> Also, I have noticed that in case of updating the field information >> using >>> AJAX (line 91) the class="textfield datetimefield" attribute doesn't >> work >>> and a timestamp type field is also displayed with simply an input box. >>> 1. Open zoom search for a table with at least a field of timestamp type >>> 2. Select the timestamp type column from dropdown. >>> 3. Notice simply an input box without datepicker. >> >> The bug is not present in upstream QA_3_5 branch. Please use "git >> bisect" to find its cause, see [0]. >> >> [0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit >> >> Ok, I'll do that. > >> -- >> Marc Delisle >> http://infomarc.info >> >> >> >>
>> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> >> > > > -- > Atul Pratap Singh > Senior Undergraduate Student > Institute Of Technology, > Banaras Hindu University, Varanasi, > India. > > Hi Marc, I noticed that in zoom search the initial display's data labels are not correct in Chromium browser too.
Line 533 (tbl_zoom_plot_jqplot.js) // under IE 8, the initial display is mangled; after a manual // resizing, it's ok // under IE 9, everything is fine currentChart = $.jqplot('querychart', series, options);
Should I add 'currentChart.resetZoom();' here to automatically reset the zoom plot?
Hi Atul, I have to do further testing because I currently have a problem under IE 8 with zoom search, in upstream master.
Ok Marc.
Atul, messages to phpmyadmin-devel are delayed so you are CC'd in this reply.
I have fixed the problem I had under IE 8 and 9 (nothing was happening when selecting a column as a criteria), see commit f6330a3f1773092d2e07c6da65116436e0c96187.
Then I have tried your suggestion about adding a resetZoom() but it does not fix the problem under IE 9.
Please CC me in your reply.
Marc, Adding a resetZoom() fixed it in chromium and firefox doesn't have the problem I think.
Atul, so please add the resetZoom() call in your tree.
Added.
About IE 9, it seems it doesn't work in my XP virtual machine. I'll be able to see it soon in IE 9 after installing my Windows 7 copy.
-- Marc Delisle http://infomarc.info
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
participants (2)
-
Atul Pratap Singh -
Marc Delisle