Hi,
My first task is to have an interface for input criteria. We discussed earlier to make use of table search page or multi-table query generator for this. I was hoping for some comments regarding this.
The aim is to let the user select *exactly two* columns(along with some criteria) from a table. I prefer the table search page, it is less complicated ( simple form, advanced options ). Also we do not need to consider columns from multiple table so table search page will be more focused. But the selection also depends on where all we want to put the option of "Zoom search" in phpMyAdmin. So should this feature be a separate component or should it be available on table search page/ multi-table query generator (or both) ?
Regards, Ammar Yasir http://ammaryasirr.blogspot.com/
Ammar Yasir a écrit :
Hi,
My first task is to have an interface for input criteria. We discussed earlier to make use of table search page or multi-table query generator for this. I was hoping for some comments regarding this.
The aim is to let the user select _*exactly two*_ columns(along with some criteria) from a table. I prefer the table search page, it is less complicated ( simple form, advanced options ). Also we do not need to consider columns from multiple table so table search page will be more focused. But the selection also depends on where all we want to put the option of "Zoom search" in phpMyAdmin. So should this feature be a separate component or should it be available on table search page/ multi-table query generator (or both) ?
Regards, Ammar Yasir http://ammaryasirr.blogspot.com/
Hi Ammar, my answer is based on the assumption that the table Search page is more known than the multi-table query generator -- it's been my experience so far, anyway.
I suggest to add in table Search, Options section a checkbox "Zoom search"; when checked, another section would reveal itself, containing particular options for this feature.
Also, when checked, the "Select columns" section could be changed to guide the user into selecting exactly two columns. Not sure if the current "select multiple" control is the best in this case, it's up to you to propose something suitable.
However I'm not sure how this would integrate with the multi-table query generator.
Marc Delisle a écrit :
Ammar Yasir a écrit :
Hi,
My first task is to have an interface for input criteria. We discussed earlier to make use of table search page or multi-table query generator for this. I was hoping for some comments regarding this.
The aim is to let the user select _*exactly two*_ columns(along with some criteria) from a table. I prefer the table search page, it is less complicated ( simple form, advanced options ). Also we do not need to consider columns from multiple table so table search page will be more focused. But the selection also depends on where all we want to put the option of "Zoom search" in phpMyAdmin. So should this feature be a separate component or should it be available on table search page/ multi-table query generator (or both) ?
Regards, Ammar Yasir http://ammaryasirr.blogspot.com/
Hi Ammar, my answer is based on the assumption that the table Search page is more known than the multi-table query generator -- it's been my experience so far, anyway.
I suggest to add in table Search, Options section a checkbox "Zoom search"; when checked, another section would reveal itself, containing particular options for this feature.
Or the Zoom search checkbox could be always visible, to better promote it.
Also, when checked, the "Select columns" section could be changed to guide the user into selecting exactly two columns. Not sure if the current "select multiple" control is the best in this case, it's up to you to propose something suitable.
However I'm not sure how this would integrate with the multi-table query generator.
On Wed, May 18, 2011 at 9:10 PM, Marc Delisle marc@infomarc.info wrote:
Marc Delisle a écrit :
Ammar Yasir a écrit :
Hi,
My first task is to have an interface for input criteria. We discussed earlier to make use of table search page or multi-table query generator for this. I was hoping for some comments regarding this.
The aim is to let the user select _*exactly two*_ columns(along with some criteria) from a table. I prefer the table search page, it is less complicated ( simple form, advanced options ). Also we do not need to consider columns from multiple table so table search page will be more focused. But the selection also depends on where all we want to put the option of "Zoom search" in phpMyAdmin. So should this feature be a separate component or should it be available on table search page/ multi-table query generator (or both) ?
Regards, Ammar Yasir http://ammaryasirr.blogspot.com/
Hi Ammar, my answer is based on the assumption that the table Search page is more known than the multi-table query generator -- it's been my experience so far, anyway.
I suggest to add in table Search, Options section a checkbox "Zoom search"; when checked, another section would reveal itself, containing particular options for this feature.
Or the Zoom search checkbox could be always visible, to better promote it.
Maybe we could put two sub tabs on the table_select page. One will allow
for table search and the other for zoom search.
Also, when checked, the "Select columns" section could be changed to guide the user into selecting exactly two columns. Not sure if the current "select multiple" control is the best in this case, it's up to you to propose something suitable.
However I'm not sure how this would integrate with the multi-table query generator.
-- Marc Delisle http://infomarc.info
What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Ammar Yasir a écrit :
On Wed, May 18, 2011 at 9:10 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Marc Delisle a écrit : > Ammar Yasir a écrit : >> Hi, >> >> My first task is to have an interface for input criteria. We discussed >> earlier to make use of table search page or multi-table query generator >> for this. I was hoping for some comments regarding this. >> >> The aim is to let the user select _*exactly two*_ columns(along with >> some criteria) from a table. I prefer the table search page, it is less >> complicated ( simple form, advanced options ). Also we do not need to >> consider columns from multiple table so table search page will be more >> focused. But the selection also depends on where all we want to put the >> option of "Zoom search" in phpMyAdmin. So should this feature be a >> separate component or should it be available on table search page/ >> multi-table query generator (or both) ? >> >> Regards, >> Ammar Yasir >> http://ammaryasirr.blogspot.com/ > > Hi Ammar, > my answer is based on the assumption that the table Search page is more > known than the multi-table query generator -- it's been my experience so > far, anyway. > > I suggest to add in table Search, Options section a checkbox "Zoom > search"; when checked, another section would reveal itself, containing > particular options for this feature. Or the Zoom search checkbox could be always visible, to better promote it.Maybe we could put two sub tabs on the table_select page. One will allow for table search and the other for zoom search.
You can try this, we'll see how it feels. Ensure to avoid duplicating code, for example in the list of columns in "query by example".
> > Also, when checked, the "Select columns" section could be changed to > guide the user into selecting exactly two columns. Not sure if the > current "select multiple" control is the best in this case, it's up to > you to propose something suitable. > > However I'm not sure how this would integrate with the multi-table query > generator. > -- Marc Delisle http://infomarc.info
Hi, I pushed my work. I just tried to add a sub-tab on the table search page, one for the normal search and the other for zoom search. I just wanted to get back feedback on whether the design will be okay to proceed? Please don't mind how I have coded for now, just coded very quickly to get a basic design of the interface. I'll code it properly after suggestions.
Since user needs to select only two columns in the zoom search page, instead of listing out all columns I provided two select boxes where user will select the two columns first and I'll display the field type, collation, operator and value based on that later. Also since we don't need to display the results, the options link on that page was removed.
One more thing: For tabs, if I am not providing any link then the mouse cursor changes to X and they appear as disabled. How to change that?
Regards, Ammar Yasir http://repo.or.cz/w/phpmyadmin/ammaryasirr.git
On Fri, May 20, 2011 at 8:27 PM, Marc Delisle marc@infomarc.info wrote:
Ammar Yasir a écrit :
On Wed, May 18, 2011 at 9:10 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Marc Delisle a écrit : > Ammar Yasir a écrit : >> Hi, >> >> My first task is to have an interface for input criteria. We discussed >> earlier to make use of table search page or multi-table query generator >> for this. I was hoping for some comments regarding this. >> >> The aim is to let the user select _*exactly two*_ columns(alongwith
>> some criteria) from a table. I prefer the table search page, it is less >> complicated ( simple form, advanced options ). Also we do not need to >> consider columns from multiple table so table search page will be more >> focused. But the selection also depends on where all we want to put the >> option of "Zoom search" in phpMyAdmin. So should this feature bea
>> separate component or should it be available on table searchpage/
>> multi-table query generator (or both) ? >> >> Regards, >> Ammar Yasir >> http://ammaryasirr.blogspot.com/ > > Hi Ammar, > my answer is based on the assumption that the table Search page is more > known than the multi-table query generator -- it's been my experience so > far, anyway. > > I suggest to add in table Search, Options section a checkbox "Zoom > search"; when checked, another section would reveal itself, containing > particular options for this feature. Or the Zoom search checkbox could be always visible, to better promote it.Maybe we could put two sub tabs on the table_select page. One will allow for table search and the other for zoom search.
You can try this, we'll see how it feels. Ensure to avoid duplicating code, for example in the list of columns in "query by example".
> > Also, when checked, the "Select columns" section could be changedto
> guide the user into selecting exactly two columns. Not sure if the > current "select multiple" control is the best in this case, it's up to > you to propose something suitable. > > However I'm not sure how this would integrate with the multi-table query > generator. > -- Marc Delisle http://infomarc.info-- Marc Delisle http://infomarc.info
What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Ammar Yasir a écrit :
Hi, I pushed my work. I just tried to add a sub-tab on the table search page, one for the normal search and the other for zoom search. I just wanted to get back feedback on whether the design will be okay to proceed? Please don't mind how I have coded for now, just coded very quickly to get a basic design of the interface. I'll code it properly after suggestions.
Since user needs to select only two columns in the zoom search page, instead of listing out all columns I provided two select boxes where user will select the two columns first and I'll display the field type, collation, operator and value based on that later. Also since we don't need to display the results, the options link on that page was removed.
One more thing: For tabs, if I am not providing any link then the mouse cursor changes to X and they appear as disabled. How to change that?
Regards, Ammar Yasir http://repo.or.cz/w/phpmyadmin/ammaryasirr.git
Ammar, I think that the two-tabbed interface will do the job.
A few remarks:
- you have a few undefined variables; in case you are not seeing them, please use "$cfg['Error_Handler']['display'] = true" in your config.inc.php
- please merge the original master to your repository, today and regularly; from http://wiki.phpmyadmin.net/pma/Git#Publishing_changes_for_merge
You should also regularly merge back the changes done in official repository:
git checkout yourbranch git remote update origin # assuming official repository is called origin git merge origin/master
- in your jQuery you are comparing with "Table Search" and this won't work with localization
- in pmahomme theme, labels "Table Search", "Zoom search" are difficult to read
- the red X comes from the "error" class so try to find out why your element has this class
On Mon, May 23, 2011 at 8:11 PM, Marc Delisle marc@infomarc.info wrote:
Ammar Yasir a écrit :
Hi, I pushed my work. I just tried to add a sub-tab on the table search page, one for the normal search and the other for zoom search. I just wanted to get back feedback on whether the design will be okay to
proceed?
Please don't mind how I have coded for now, just coded very quickly to get a basic design of the interface. I'll code it properly after suggestions.
Since user needs to select only two columns in the zoom search page, instead of listing out all columns I provided two select boxes where user will select the two columns first and I'll display the field type, collation, operator and value based on that later. Also since we don't need to display the results, the options link on that page was removed.
One more thing: For tabs, if I am not providing any link then the mouse cursor changes to X and they appear as disabled. How to change that?
Regards, Ammar Yasir http://repo.or.cz/w/phpmyadmin/ammaryasirr.git
Ammar, I think that the two-tabbed interface will do the job.
A few remarks:
- you have a few undefined variables; in case you are not seeing them,
please use "$cfg['Error_Handler']['display'] = true" in your config.inc.php
- please merge the original master to your repository, today and
regularly; from http://wiki.phpmyadmin.net/pma/Git#Publishing_changes_for_merge
You should also regularly merge back the changes done in official repository:
git checkout yourbranch git remote update origin # assuming official repository is called origin git merge origin/master
- in your jQuery you are comparing with "Table Search" and this won't
work with localization
- in pmahomme theme, labels "Table Search", "Zoom search" are difficult
to read
- the red X comes from the "error" class so try to find out why your
element has this class
-- Marc Delisle http://infomarc.info
Hi,
I pushed my work. I have added a new file tbl_zoom_select.php which contains the interface. I tried to code everything in tbl_search page but the code becomes very complicated and I had to use a lot of If/else conditions, so i think it will become even more complicated when I'll experiment with plotting libraries. With a new form its better to switch between the normal table search and zoom search forms without using jQuery. Also, in this form a user can select two same columns but with different search criteria (for example, a film with rating G and a film with rating PG-13) so the query generation for this case cannot be handled in tbl_select.php. It generates a wrong query, so the query generation part of this interface also works a bit differently. It generates two queries, one for each column criteria. I know some code has to be duplicated, but I think its better to develop it as a different component. Otherwise if there are some modifications in the zoom-search part, a lot of changes have to be done in the tbl_select.php page. Its just what I thought, I'll do the interface again if code duplication is an issue.
Regards, Ammar Yasir http://repo.or.cz/w/phpmyadmin/ammaryasirr.git
What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Ammar Yasir a écrit :
On Mon, May 23, 2011 at 8:11 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Ammar Yasir a écrit : > Hi, > I pushed my work. I just tried to add a sub-tab on the table search > page, one for the normal search and the other for zoom search. I just > wanted to get back feedback on whether the design will be okay to proceed? > Please don't mind how I have coded for now, just coded very quickly to > get a basic design of the interface. I'll code it properly after > suggestions. > > Since user needs to select only two columns in the zoom search page, > instead of listing out all columns I provided two select boxes where > user will select the two columns first and I'll display the field type, > collation, operator and value based on that later. Also since we don't > need to display the results, the options link on that page was removed. > > One more thing: For tabs, if I am not providing any link then the mouse > cursor changes to X and they appear as disabled. How to change that? > > Regards, > Ammar Yasir > http://repo.or.cz/w/phpmyadmin/ammaryasirr.git Ammar, I think that the two-tabbed interface will do the job. A few remarks: - you have a few undefined variables; in case you are not seeing them, please use "$cfg['Error_Handler']['display'] = true" in your config.inc.php - please merge the original master to your repository, today and regularly; from http://wiki.phpmyadmin.net/pma/Git#Publishing_changes_for_merge You should also regularly merge back the changes done in official repository: git checkout yourbranch git remote update origin # assuming official repository is called origin git merge origin/master - in your jQuery you are comparing with "Table Search" and this won't work with localization - in pmahomme theme, labels "Table Search", "Zoom search" are difficult to read - the red X comes from the "error" class so try to find out why your element has this class -- Marc Delisle http://infomarc.infoHi, I pushed my work. I have added a new file tbl_zoom_select.php which contains the interface. I tried to code everything in tbl_search page but the code becomes very complicated and I had to use a lot of If/else conditions, so i think it will become even more complicated when I'll experiment with plotting libraries. With a new form its better to switch between the normal table search and zoom search forms without using jQuery. Also, in this form a user can select two same columns but with different search criteria (for example, a film with rating G and a film with rating PG-13) so the query generation for this case cannot be handled in tbl_select.php. It generates a wrong query, so the query generation part of this interface also works a bit differently. It generates two queries, one for each column criteria. I know some code has to be duplicated, but I think its better to develop it as a different component. Otherwise if there are some modifications in the zoom-search part, a lot of changes have to be done in the tbl_select.php page. Its just what I thought, I'll do the interface again if code duplication is an issue.
Ammar, it's OK to have two components but please refactor common code into functions and put them in a new libraries/tbl_select.lib.php that will be called from both components; otherwise it will be difficult to maintain.
An example of needed refactoring: the "Gets the list and number of fields" section.
Don't forget to follow my advice about merging the changes from the official repository.
On Thu, May 26, 2011 at 5:54 PM, Marc Delisle marc@infomarc.info wrote:
Ammar Yasir a écrit :
On Mon, May 23, 2011 at 8:11 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Ammar Yasir a écrit : > Hi, > I pushed my work. I just tried to add a sub-tab on the tablesearch
> page, one for the normal search and the other for zoom search. Ijust
> wanted to get back feedback on whether the design will be okay to proceed? > Please don't mind how I have coded for now, just coded very quickly to > get a basic design of the interface. I'll code it properly after > suggestions. > > Since user needs to select only two columns in the zoom searchpage,
> instead of listing out all columns I provided two select boxeswhere
> user will select the two columns first and I'll display the field type, > collation, operator and value based on that later. Also since we don't > need to display the results, the options link on that page was removed. > > One more thing: For tabs, if I am not providing any link then the mouse > cursor changes to X and they appear as disabled. How to changethat?
> > Regards, > Ammar Yasir > http://repo.or.cz/w/phpmyadmin/ammaryasirr.git Ammar, I think that the two-tabbed interface will do the job. A few remarks: - you have a few undefined variables; in case you are not seeingthem,
please use "$cfg['Error_Handler']['display'] = true" in your config.inc.php - please merge the original master to your repository, today and regularly; from http://wiki.phpmyadmin.net/pma/Git#Publishing_changes_for_merge You should also regularly merge back the changes done in official repository: git checkout yourbranch git remote update origin # assuming official repository is calledorigin
git merge origin/master - in your jQuery you are comparing with "Table Search" and this won't work with localization - in pmahomme theme, labels "Table Search", "Zoom search" aredifficult
to read - the red X comes from the "error" class so try to find out why your element has this class -- Marc Delisle http://infomarc.infoHi, I pushed my work. I have added a new file tbl_zoom_select.php which contains the interface. I tried to code everything in tbl_search page but the code becomes very complicated and I had to use a lot of If/else conditions, so i think it will become even more complicated when I'll experiment with plotting libraries. With a new form its better to switch between the normal table search and zoom search forms without using jQuery. Also, in this form a user can select two same columns but with different search criteria (for example, a film with rating G and a film with rating PG-13) so the query generation for this case cannot be handled in tbl_select.php. It generates a wrong query, so the query generation part of this interface also works a bit differently. It generates two queries, one for each column criteria. I know some code has to be duplicated, but I think its better to develop it as a different component. Otherwise if there are some modifications in the zoom-search part, a lot of changes have to be done in the tbl_select.php page. Its just what I thought, I'll do the interface again if code duplication is an issue.
Ammar, it's OK to have two components but please refactor common code into functions and put them in a new libraries/tbl_select.lib.php that will be called from both components; otherwise it will be difficult to maintain.
An example of needed refactoring: the "Gets the list and number of fields" section.
I did refactoring in two areas:
1) As you proposed, Getting the list and number of fields. 2) The where clause generation in the query-building part.
Should we also do for the HTML part? Some part of that (for example the foreign keys display part) is common but also has HTML content embedded. Apart from that since the zoom-search form takes the field as input so rest of the form is based on that constraint. So I was thinking that the HTML part can stay as it is.
Don't forget to follow my advice about merging the changes from the
official repository.
-- Marc Delisle http://infomarc.info
vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-05-29 03:11, Ammar Yasir a écrit :
Ammar, it's OK to have two components but please refactor common code into functions and put them in a new libraries/tbl_select.lib.php that will be called from both components; otherwise it will be difficult to maintain.
An example of needed refactoring: the "Gets the list and number of fields" section.
I did refactoring in two areas:
- As you proposed, Getting the list and number of fields.
- The where clause generation in the query-building part.
Should we also do for the HTML part? Some part of that (for example the foreign keys display part) is common but also has HTML content embedded. Apart from that since the zoom-search form takes the field as input so rest of the form is based on that constraint. So I was thinking that the HTML part can stay as it is.
Ammar,
The foreign keys display part is a good example of needed refactoring.
I don't know how much HTML refactoring you are willing to do, but some HTML is easy to refactor, for example: - the section that sets $titles['Browse'] - the beginning of the table with headers Column, Type, etc
In libraries/tbl_select.lib.php, please describe for each function the parameters and return values; see an example in libraries/server_synchronize.lib.php.
About the syntax, please use spaces around operators. Instead of $i-1 use $i - 1
There is a case of undefined variable. To reproduce, on sakila.actor, Search, Table search, last name Wilson, Go:
Notice in ./libraries/tbl_select.lib.php#129 Undefined variable: w
Backtrace
./tbl_select.php#329: PMA_tbl_search_getWhereClause( string , string last_update, string timestamp, string , string =, boolean , )
On Sun, May 29, 2011 at 4:31 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-05-29 03:11, Ammar Yasir a écrit :
Ammar, it's OK to have two components but please refactor common code into functions and put them in a new libraries/tbl_select.lib.php that will be called from both components; otherwise it will be difficult to
maintain.
An example of needed refactoring: the "Gets the list and number of fields" section.
I did refactoring in two areas:
- As you proposed, Getting the list and number of fields.
- The where clause generation in the query-building part.
Should we also do for the HTML part? Some part of that (for example the foreign keys display part) is common but also has HTML content embedded. Apart from that since the zoom-search form takes the field as input so
rest
of the form is based on that constraint. So I was thinking that the HTML part can stay as it is.
Ammar,
The foreign keys display part is a good example of needed refactoring.
I don't know how much HTML refactoring you are willing to do, but some HTML is easy to refactor, for example:
- the section that sets $titles['Browse']
- the beginning of the table with headers Column, Type, etc
Parts refactored are: - Setting titles (titles['Browse']]) - getting fields list (getting column details) - setting sub-tabs (Table search and Zoom search) - setting table header of QBE display - displaying foreign data - search criteria input elements (HTML content generation for the input elements)
In libraries/tbl_select.lib.php, please describe for each function the parameters and return values; see an example in libraries/server_synchronize.lib.php.
About the syntax, please use spaces around operators. Instead of $i-1 use $i - 1
There is a case of undefined variable. To reproduce, on sakila.actor, Search, Table search, last name Wilson, Go:
Notice in ./libraries/tbl_select.lib.php#129 Undefined variable: w
Backtrace
./tbl_select.php#329: PMA_tbl_search_getWhereClause( string , string last_update, string timestamp, string , string =, boolean , )
-- Marc Delisle http://infomarc.info
vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Ammar Yasir a écrit :
Parts refactored are:
- Setting titles (titles['Browse']])
- getting fields list (getting column details)
- setting sub-tabs (Table search and Zoom search)
- setting table header of QBE display
- displaying foreign data
- search criteria input elements (HTML content generation for the input
elements)
Very good!
Another trick you can use: when a function returns an array, like your PMA_tbl_getFields(), to fill all the returned values in one statement you can use this syntax:
list($fields_list, $fields_type, $fields_collation, $fields_null) = PMA_tbl_getFields($table,$db);
In libraries/tbl_select.lib.php, please describe for each function the parameters and return values; see an example in libraries/server_synchronize.lib.php. About the syntax, please use spaces around operators. Instead of $i-1 use $i - 1
There are still a few cases of missing spaces around operators.
On Tue, May 31, 2011 at 10:14 PM, Marc Delisle marc@infomarc.info wrote:
Ammar Yasir a écrit :
Parts refactored are:
- Setting titles (titles['Browse']])
- getting fields list (getting column details)
- setting sub-tabs (Table search and Zoom search)
- setting table header of QBE display
- displaying foreign data
- search criteria input elements (HTML content generation for the input
elements)
Very good!
Another trick you can use: when a function returns an array, like your PMA_tbl_getFields(), to fill all the returned values in one statement you can use this syntax:
list($fields_list, $fields_type, $fields_collation, $fields_null) = PMA_tbl_getFields($table,$db);
I made some more changes. Should I proceed now to try the charting libraries?
In libraries/tbl_select.lib.php, please describe for each functionthe
parameters and return values; see an example in libraries/server_synchronize.lib.php. About the syntax, please use spaces around operators. Instead of $i-1 use $i - 1There are still a few cases of missing spaces around operators.
-- Marc Delisle http://infomarc.info
Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Ammar Yasir a écrit :
On Tue, May 31, 2011 at 10:14 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Ammar Yasir a écrit : > Parts refactored are: > - Setting titles (titles['Browse']]) > - getting fields list (getting column details) > - setting sub-tabs (Table search and Zoom search) > - setting table header of QBE display > - displaying foreign data > - search criteria input elements (HTML content generation for the input > elements) Very good! Another trick you can use: when a function returns an array, like your PMA_tbl_getFields(), to fill all the returned values in one statement you can use this syntax: list($fields_list, $fields_type, $fields_collation, $fields_null) = PMA_tbl_getFields($table,$db);I made some more changes.
OK. There are still a few tab characters (found some in libraries/tbl_select.lib.php).
Should I proceed now to try the charting libraries?
Yes but in your proposal you wrote that you preferred jQuery-SVG so I assume you'll try this one first?
On Wed, Jun 1, 2011 at 1:55 AM, Marc Delisle marc@infomarc.info wrote:
Ammar Yasir a écrit :
On Tue, May 31, 2011 at 10:14 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Ammar Yasir a écrit : > Parts refactored are: > - Setting titles (titles['Browse']]) > - getting fields list (getting column details) > - setting sub-tabs (Table search and Zoom search) > - setting table header of QBE display > - displaying foreign data > - search criteria input elements (HTML content generation for the input > elements) Very good! Another trick you can use: when a function returns an array, likeyour
PMA_tbl_getFields(), to fill all the returned values in one statement you can use this syntax: list($fields_list, $fields_type, $fields_collation, $fields_null) = PMA_tbl_getFields($table,$db);I made some more changes.
OK. There are still a few tab characters (found some in libraries/tbl_select.lib.php).
Should I proceed now to try the charting libraries?
Yes but in your proposal you wrote that you preferred jQuery-SVG so I assume you'll try this one first?
I'll try SVG first. I'm following what others have to say about SVG,
Madhura is using it for his GIS visualization. Tyron proposed real-time charting but I don't think it'll be of much help in our case.
-- Marc Delisle http://infomarc.info
Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Wed, Jun 1, 2011 at 2:10 AM, Ammar Yasir ammaryasir.88@gmail.com wrote:
On Wed, Jun 1, 2011 at 1:55 AM, Marc Delisle marc@infomarc.info wrote:
Ammar Yasir a écrit :
On Tue, May 31, 2011 at 10:14 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Ammar Yasir a écrit : > Parts refactored are: > - Setting titles (titles['Browse']]) > - getting fields list (getting column details) > - setting sub-tabs (Table search and Zoom search) > - setting table header of QBE display > - displaying foreign data > - search criteria input elements (HTML content generation for the input > elements) Very good! Another trick you can use: when a function returns an array, likeyour
PMA_tbl_getFields(), to fill all the returned values in onestatement
you can use this syntax: list($fields_list, $fields_type, $fields_collation, $fields_null) = PMA_tbl_getFields($table,$db);I made some more changes.
OK. There are still a few tab characters (found some in libraries/tbl_select.lib.php).
Should I proceed now to try the charting libraries?
Yes but in your proposal you wrote that you preferred jQuery-SVG so I assume you'll try this one first?
I'll try SVG first. I'm following what others have to say about SVG,
Madhura is using it for his GIS visualization. Tyron proposed real-time charting but I don't think it'll be of much help in our case.
Hi Ammar,
I'm not sure what exactly your requirement is. But pls have a look at the visualization of data at [1] by clicking on the 'Visualize GIS data' link in the 'Query results operations' section towards the bottom of the page. Try out zooming by double clicking and panning by dragging. I believe you are looking for something like this for your zoom search feature.
Hope this is useful.
On Wed, Jun 1, 2011 at 4:30 PM, Madhura Jayaratne madhura.cj@gmail.comwrote:
On Wed, Jun 1, 2011 at 2:10 AM, Ammar Yasir ammaryasir.88@gmail.comwrote:
On Wed, Jun 1, 2011 at 1:55 AM, Marc Delisle marc@infomarc.info wrote:
Ammar Yasir a écrit :
On Tue, May 31, 2011 at 10:14 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Ammar Yasir a écrit : > Parts refactored are: > - Setting titles (titles['Browse']]) > - getting fields list (getting column details) > - setting sub-tabs (Table search and Zoom search) > - setting table header of QBE display > - displaying foreign data > - search criteria input elements (HTML content generation forthe
input > elements) Very good! Another trick you can use: when a function returns an array, likeyour
PMA_tbl_getFields(), to fill all the returned values in onestatement
you can use this syntax: list($fields_list, $fields_type, $fields_collation, $fields_null) = PMA_tbl_getFields($table,$db);I made some more changes.
OK. There are still a few tab characters (found some in libraries/tbl_select.lib.php).
Should I proceed now to try the charting libraries?
Yes but in your proposal you wrote that you preferred jQuery-SVG so I assume you'll try this one first?
I'll try SVG first. I'm following what others have to say about SVG,
Madhura is using it for his GIS visualization. Tyron proposed real-time charting but I don't think it'll be of much help in our case.
Hi Ammar,
I'm not sure what exactly your requirement is. But pls have a look at the visualization of data at [1] by clicking on the 'Visualize GIS data' link in the 'Query results operations' section towards the bottom of the page. Try out zooming by double clicking and panning by dragging. I believe you are looking for something like this for your zoom search feature.
Hope this is useful.
-- Thanks and Regards,
Madhura Jayaratne
[1]
Forgot the URL
[1] http://demo.phpmyadmin.net/gsoc-madhura/index.php?db=opengis&table=world...
Madhura Jayaratne a écrit :
On Wed, Jun 1, 2011 at 4:30 PM, Madhura Jayaratne <madhura.cj@gmail.com mailto:madhura.cj@gmail.com> wrote:
On Wed, Jun 1, 2011 at 2:10 AM, Ammar Yasir <ammaryasir.88@gmail.com <mailto:ammaryasir.88@gmail.com>> wrote: On Wed, Jun 1, 2011 at 1:55 AM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote: Ammar Yasir a écrit : > > > On Tue, May 31, 2011 at 10:14 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>> wrote: > > Ammar Yasir a écrit : > > > Parts refactored are: > > - Setting titles (titles['Browse']]) > > - getting fields list (getting column details) > > - setting sub-tabs (Table search and Zoom search) > > - setting table header of QBE display > > - displaying foreign data > > - search criteria input elements (HTML content generation for the > input > > elements) > > Very good! > > Another trick you can use: when a function returns an array, like your > PMA_tbl_getFields(), to fill all the returned values in one statement > you can use this syntax: > > list($fields_list, $fields_type, $fields_collation, $fields_null) = > PMA_tbl_getFields($table,$db); > > > I made some more changes. OK. There are still a few tab characters (found some in libraries/tbl_select.lib.php). > Should I proceed now to try the charting libraries? Yes but in your proposal you wrote that you preferred jQuery-SVG so I assume you'll try this one first? I'll try SVG first. I'm following what others have to say about SVG, Madhura is using it for his GIS visualization. Tyron proposed real-time charting but I don't think it'll be of much help in our case. Hi Ammar, I'm not sure what exactly your requirement is. But pls have a look at the visualization of data at [1] by clicking on the 'Visualize GIS data' link in the 'Query results operations' section towards the bottom of the page. Try out zooming by double clicking and panning by dragging. I believe you are looking for something like this for your zoom search feature.
Madhura,
I have issues operating panning and zooming. Here is the scenario:
1. Browse world_cities and click Visualize GIS data 2. Click-drag: pans OK 3. Double-click: this is a zoom out, I guess 4. Click-drag: no panning 5. Click "zoom out": data points are enlarging, isn't this a zoom-in?
On Wed, Jun 1, 2011 at 5:30 PM, Marc Delisle marc@infomarc.info wrote:
Madhura Jayaratne a écrit :
On Wed, Jun 1, 2011 at 4:30 PM, Madhura Jayaratne <madhura.cj@gmail.com mailto:madhura.cj@gmail.com> wrote:
On Wed, Jun 1, 2011 at 2:10 AM, Ammar Yasir <ammaryasir.88@gmail.com <mailto:ammaryasir.88@gmail.com>> wrote: On Wed, Jun 1, 2011 at 1:55 AM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote: Ammar Yasir a écrit : > > > On Tue, May 31, 2011 at 10:14 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>> wrote: > > Ammar Yasir a écrit : > > > Parts refactored are: > > - Setting titles (titles['Browse']]) > > - getting fields list (getting column details) > > - setting sub-tabs (Table search and Zoom search) > > - setting table header of QBE display > > - displaying foreign data > > - search criteria input elements (HTML content generation for the > input > > elements) > > Very good! > > Another trick you can use: when a function returns an array, like your > PMA_tbl_getFields(), to fill all the returned values in one statement > you can use this syntax: > > list($fields_list, $fields_type, $fields_collation, $fields_null) = > PMA_tbl_getFields($table,$db); > > > I made some more changes. OK. There are still a few tab characters (found some in libraries/tbl_select.lib.php). > Should I proceed now to try the charting libraries? Yes but in your proposal you wrote that you preferred jQuery-SVG so I assume you'll try this one first? I'll try SVG first. I'm following what others have to say about SVG, Madhura is using it for his GIS visualization. Tyron proposed real-time charting but I don't think it'll be of much help in our case. Hi Ammar, I'm not sure what exactly your requirement is. But pls have a look at the visualization of data at [1] by clicking on the 'Visualize GIS data' link in the 'Query results operations' section towards the bottom of the page. Try out zooming by double clicking and panning by dragging. I believe you are looking for something like this for your zoom search feature.Madhura,
I have issues operating panning and zooming. Here is the scenario:
- Browse world_cities and click Visualize GIS data
- Click-drag: pans OK
- Double-click: this is a zoom out, I guess
- Click-drag: no panning
- Click "zoom out": data points are enlarging, isn't this a zoom-in?
I'm also experiencing the same issues.(Using Firefox 4.0.1)
The arrows are for panning but double clicking on them also makes the points zoom out. Overall svg quality looks fine.
-- Marc Delisle http://infomarc.info
Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Wed, Jun 1, 2011 at 5:30 PM, Marc Delisle marc@infomarc.info wrote:
Madhura Jayaratne a écrit :
On Wed, Jun 1, 2011 at 4:30 PM, Madhura Jayaratne <madhura.cj@gmail.com mailto:madhura.cj@gmail.com> wrote:
On Wed, Jun 1, 2011 at 2:10 AM, Ammar Yasir <ammaryasir.88@gmail.com <mailto:ammaryasir.88@gmail.com>> wrote: On Wed, Jun 1, 2011 at 1:55 AM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote: Ammar Yasir a écrit : > > > On Tue, May 31, 2011 at 10:14 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info> > <mailto:marc@infomarc.info <mailto:marc@infomarc.info>>> wrote: > > Ammar Yasir a écrit : > > > Parts refactored are: > > - Setting titles (titles['Browse']]) > > - getting fields list (getting column details) > > - setting sub-tabs (Table search and Zoom search) > > - setting table header of QBE display > > - displaying foreign data > > - search criteria input elements (HTML content generation for the > input > > elements) > > Very good! > > Another trick you can use: when a function returns an array, like your > PMA_tbl_getFields(), to fill all the returned values in one statement > you can use this syntax: > > list($fields_list, $fields_type, $fields_collation, $fields_null) = > PMA_tbl_getFields($table,$db); > > > I made some more changes. OK. There are still a few tab characters (found some in libraries/tbl_select.lib.php). > Should I proceed now to try the charting libraries? Yes but in your proposal you wrote that you preferred jQuery-SVG so I assume you'll try this one first? I'll try SVG first. I'm following what others have to say about SVG, Madhura is using it for his GIS visualization. Tyron proposed real-time charting but I don't think it'll be of much help in our case. Hi Ammar, I'm not sure what exactly your requirement is. But pls have a look at the visualization of data at [1] by clicking on the 'Visualize GIS data' link in the 'Query results operations' section towards the bottom of the page. Try out zooming by double clicking and panning by dragging. I believe you are looking for something like this for your zoom search feature.Madhura,
I have issues operating panning and zooming. Here is the scenario:
- Browse world_cities and click Visualize GIS data
- Click-drag: pans OK
- Double-click: this is a zoom out, I guess
- Click-drag: no panning
- Click "zoom out": data points are enlarging, isn't this a zoom-in?
Marc,
This is a Firefox compatibility problem. Resolved and pushed to the repo. Demo will take some time to upgrade to the new version. Meanwhile if you have Chrome, you can still experience what it's suppose to do.
Madhura Jayaratne a écrit : (...)
> Hi Ammar, > > I'm not sure what exactly your requirement is. But pls have a look > at the visualization of data at [1] by clicking on the 'Visualize > GIS data' link in the 'Query results operations' section towards the > bottom of the page. Try out zooming by double clicking and panning > by dragging. I believe you are looking for something like this for > your zoom search feature. Madhura, I have issues operating panning and zooming. Here is the scenario: 1. Browse world_cities and click Visualize GIS data 2. Click-drag: pans OK 3. Double-click: this is a zoom out, I guess 4. Click-drag: no panning 5. Click "zoom out": data points are enlarging, isn't this a zoom-in?Marc,
This is a Firefox compatibility problem. Resolved and pushed to the repo. Demo will take some time to upgrade to the new version. Meanwhile if you have Chrome, you can still experience what it's suppose to do.
Madhura, ok, panning and zooming are fine now.
Is the saving feature ready? I tried to save in PNG and got a bunch of binary data on-screen.
Saving in PDF generates Fatal error: Call to undefined method PMA_GIS_Visualization::toFileAsPdf() in /srv/http/pma.cihar.com/gsoc-madhura/libraries/gis_visualization.lib.php on line 161
On Thu, Jun 2, 2011 at 1:42 AM, Marc Delisle marc@infomarc.info wrote:
Madhura Jayaratne a écrit : (...)
> Hi Ammar, > > I'm not sure what exactly your requirement is. But pls have a look > at the visualization of data at [1] by clicking on the'Visualize
> GIS data' link in the 'Query results operations' section towards the > bottom of the page. Try out zooming by double clicking and panning > by dragging. I believe you are looking for something like this for > your zoom search feature. Madhura, I have issues operating panning and zooming. Here is the scenario: 1. Browse world_cities and click Visualize GIS data 2. Click-drag: pans OK 3. Double-click: this is a zoom out, I guess 4. Click-drag: no panning 5. Click "zoom out": data points are enlarging, isn't this a zoom-in?Marc,
This is a Firefox compatibility problem. Resolved and pushed to the repo. Demo will take some time to upgrade to the new version. Meanwhile if you have Chrome, you can still experience what it's suppose to do.
Madhura, ok, panning and zooming are fine now.
Is the saving feature ready? I tried to save in PNG and got a bunch of binary data on-screen.
Saving in PDF generates Fatal error: Call to undefined method PMA_GIS_Visualization::toFileAsPdf() in /srv/http/pma.cihar.com/gsoc-madhura/libraries/gis_visualization.lib.php on line 161
-- Marc Delisle http://infomarc.info
Hi Marc,
In my previous mail to the group, I mentioned that this feature is not yet ready. BTW, this is a feature which is to be delivered in the second half of GSoC (after mid-term eval), according to the schedule. However I started working on it, since it is very much related to what I've done so far. I should be able to get it ready (for all 3 formats, SVG, PNG and PDF) by the end of this week.
On Thu, Jun 2, 2011 at 4:27 AM, Madhura Jayaratne madhura.cj@gmail.com wrote:
On Thu, Jun 2, 2011 at 1:42 AM, Marc Delisle marc@infomarc.info wrote:
Madhura Jayaratne a écrit : (...)
> Hi Ammar, > > I'm not sure what exactly your requirement is. But pls have a look > at the visualization of data at [1] by clicking on the 'Visualize > GIS data' link in the 'Query results operations' section towards the > bottom of the page. Try out zooming by double clicking and panning > by dragging. I believe you are looking for something like this for > your zoom search feature.
Madhura,
I have issues operating panning and zooming. Here is the scenario:
1. Browse world_cities and click Visualize GIS data 2. Click-drag: pans OK 3. Double-click: this is a zoom out, I guess 4. Click-drag: no panning 5. Click "zoom out": data points are enlarging, isn't this a zoom-in?
Marc,
This is a Firefox compatibility problem. Resolved and pushed to the repo. Demo will take some time to upgrade to the new version. Meanwhile if you have Chrome, you can still experience what it's suppose to do.
Madhura, ok, panning and zooming are fine now.
Is the saving feature ready? I tried to save in PNG and got a bunch of binary data on-screen.
Saving in PDF generates Fatal error: Call to undefined method PMA_GIS_Visualization::toFileAsPdf() in /srv/http/pma.cihar.com/gsoc-madhura/libraries/gis_visualization.lib.php on line 161
-- Marc Delisle http://infomarc.info
Hi Marc, In my previous mail to the group, I mentioned that this feature is not yet ready. BTW, this is a feature which is to be delivered in the second half of GSoC (after mid-term eval), according to the schedule. However I started working on it, since it is very much related to what I've done so far. I should be able to get it ready (for all 3 formats, SVG, PNG and PDF) by the end of this week.
Just in case I'm allowed to use Highcharts, could you make your conversion code generic enough so I could use it too? :) And just for your information, the current SVG converter of highcharts uses following post variables to a php file that calls a java tool (source is available btw):
* $tempName string The desired filename without extension * $type string The MIME type for export. * $width int The pixel width of the exported raster image. The height is calculated. * $svg string The SVG source code to convert.
-- Thanks and Regards, Madhura Jayaratne
Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Thu, Jun 2, 2011 at 1:32 PM, Tyron Madlener tyronx@gmail.com wrote:
On Thu, Jun 2, 2011 at 4:27 AM, Madhura Jayaratne madhura.cj@gmail.com wrote:
On Thu, Jun 2, 2011 at 1:42 AM, Marc Delisle marc@infomarc.info wrote:
Madhura Jayaratne a écrit : (...)
> Hi Ammar, > > I'm not sure what exactly your requirement is. But pls havea
look > at the visualization of data at [1] by clicking on the'Visualize > GIS data' link in the 'Query results operations' section towards the > bottom of the page. Try out zooming by double clicking and panning > by dragging. I believe you are looking for something like this for > your zoom search feature.
Madhura, I have issues operating panning and zooming. Here is the scenario: 1. Browse world_cities and click Visualize GIS data 2. Click-drag: pans OK 3. Double-click: this is a zoom out, I guess 4. Click-drag: no panning 5. Click "zoom out": data points are enlarging, isn't this azoom-in?
Marc,
This is a Firefox compatibility problem. Resolved and pushed to the repo. Demo will take some time to upgrade to the new version.
Meanwhile
if you have Chrome, you can still experience what it's suppose to do.
Madhura, ok, panning and zooming are fine now.
Is the saving feature ready? I tried to save in PNG and got a bunch of binary data on-screen.
Saving in PDF generates Fatal error: Call to undefined method PMA_GIS_Visualization::toFileAsPdf() in /srv/http/
pma.cihar.com/gsoc-madhura/libraries/gis_visualization.lib.php
on line 161
-- Marc Delisle http://infomarc.info
Hi Marc, In my previous mail to the group, I mentioned that this feature is not
yet
ready. BTW, this is a feature which is to be delivered in the second half
of
GSoC (after mid-term eval), according to the schedule. However I started working on it, since it is very much related to what I've done so far. I should be able to get it ready (for all 3 formats, SVG, PNG and PDF) by
the
end of this week.
Just in case I'm allowed to use Highcharts, could you make your conversion code generic enough so I could use it too? :) And just for your information, the current SVG converter of highcharts uses following post variables to a php file that calls a java tool (source is available btw):
- $tempName string The desired filename without extension
- $type string The MIME type for export.
- $width int The pixel width of the exported raster image. The height
is calculated.
- $svg string The SVG source code to convert.
Hi Tyron,
For my work I am not doing any conversions as such. I am generating SVGs and PNG separately in their basic forms. It's not that I generate it in one form and converting it to the other.
-
Ammar Yasir -
Ammar Yasir -
Madhura Jayaratne -
Marc Delisle -
Tyron Madlener