[Phpmyadmin-devel] New sprites implementation - Developers - phpmyadmin.net

List overview All Threads
Download

[Phpmyadmin-devel] New sprites implementation

[Phpmyadmin-devel] PMA_getImage()...

[Phpmyadmin-devel] @FIELDS@ ->...

Rouslan Placella

30 Sep 2011 30 Sep '11

3:59 p.m.

Hi there, I've just pushed the new sprites implementation to master and updated the relevant wiki page [1]. Please take the time to read this documentation. Thank you. If you have any feedback on the matter, I'd love to hear it. Rouslan [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage

Reply

Show replies by date

Marc Delisle

1 Oct 1 Oct

7:54 a.m.

Le 2011-09-30 14:59, Rouslan Placella a écrit :

Hi there, I've just pushed the new sprites implementation to master and updated the relevant wiki page [1]. Please take the time to read this documentation. Thank you. If you have any feedback on the matter, I'd love to hear it. Rouslan [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage

Rouslan, after using generate_sprites, all my icons now have a black background. Maybe this is related to the numerous errors I get, such as: identify: invalid colormap index `s_vars.png' @ error/image.c/SyncImage/3899. -- Marc Delisle http://infomarc.info

Reply

Rouslan Placella

9:01 a.m.

On Sat, 2011-10-01 at 06:54 -0400, Marc Delisle wrote:

Le 2011-09-30 14:59, Rouslan Placella a écrit :

Hi there, I've just pushed the new sprites implementation to master and updated the relevant wiki page [1]. Please take the time to read this documentation. Thank you. If you have any feedback on the matter, I'd love to hear it. Rouslan [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage

Rouslan, after using generate_sprites, all my icons now have a black background. Maybe this is related to the numerous errors I get, such as: identify: invalid colormap index `s_vars.png' @ error/image.c/SyncImage/3899.

Hi Marc, Well, that's not good. Although I doubt that the errors from 'identify' have anything to do with the issue, since that program is only used to extract the height and width from image files. Do you get any errors from 'convert'? Anyway, under what OS were you running the script? What does "convert --version" say? Also can you run the below commands and let me know what the output is and what the resulting images look like? cd /path/to/phpmyadmin/ convert -size 16x16 xc:none test1.png convert test1.png themes/pmahomme/img/b_drop.png -composite test2.png identify -ping test1.png identify -ping test2.png Thanks. Rouslan

Reply

Marc Delisle

2 Oct 2 Oct

7:23 a.m.

Le 2011-10-01 08:01, Rouslan Placella a écrit :

On Sat, 2011-10-01 at 06:54 -0400, Marc Delisle wrote:

Le 2011-09-30 14:59, Rouslan Placella a écrit :

Hi there, I've just pushed the new sprites implementation to master and updated the relevant wiki page [1]. Please take the time to read this documentation. Thank you. If you have any feedback on the matter, I'd love to hear it. Rouslan [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage

Rouslan, after using generate_sprites, all my icons now have a black background. Maybe this is related to the numerous errors I get, such as: identify: invalid colormap index `s_vars.png' @ error/image.c/SyncImage/3899.

Hi Marc, Well, that's not good. Although I doubt that the errors from 'identify' have anything to do with the issue, since that program is only used to extract the height and width from image files. Do you get any errors from 'convert'? Anyway, under what OS were you running the script? What does "convert --version" say? Also can you run the below commands and let me know what the output is and what the resulting images look like?

Version: ImageMagick 6.6.1-5 2010-04-28 Q16 http://www.imagemagick.org

cd /path/to/phpmyadmin/ convert -size 16x16 xc:none test1.png convert test1.png themes/pmahomme/img/b_drop.png -composite test2.png identify -ping test1.png

test1.png PNG 16x16 16x16+0+0 16-bit PseudoClass 65536c 229B 0.000u 0:00.000

identify -ping test2.png

test2.png PNG 16x16 16x16+0+0 16-bit DirectClass 1.31KB 0.000u 0:00.000

Thanks. Rouslan ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

-- Marc Delisle http://infomarc.info

Reply

Rouslan Placella

11:23 a.m.

On Sun, 2011-10-02 at 06:23 -0400, Marc Delisle wrote:

Le 2011-10-01 08:01, Rouslan Placella a écrit :

On Sat, 2011-10-01 at 06:54 -0400, Marc Delisle wrote:

Le 2011-09-30 14:59, Rouslan Placella a écrit :

Hi there, I've just pushed the new sprites implementation to master and updated the relevant wiki page [1]. Please take the time to read this documentation. Thank you. If you have any feedback on the matter, I'd love to hear it. Rouslan [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage

Rouslan, after using generate_sprites, all my icons now have a black background. Maybe this is related to the numerous errors I get, such as: identify: invalid colormap index `s_vars.png' @ error/image.c/SyncImage/3899.

Hi Marc, Well, that's not good. Although I doubt that the errors from 'identify' have anything to do with the issue, since that program is only used to extract the height and width from image files. Do you get any errors from 'convert'? Anyway, under what OS were you running the script? What does "convert --version" say? Also can you run the below commands and let me know what the output is and what the resulting images look like?

Version: ImageMagick 6.6.1-5 2010-04-28 Q16 http://www.imagemagick.org

cd /path/to/phpmyadmin/ convert -size 16x16 xc:none test1.png convert test1.png themes/pmahomme/img/b_drop.png -composite test2.png identify -ping test1.png

test1.png PNG 16x16 16x16+0+0 16-bit PseudoClass 65536c 229B 0.000u 0:00.000

identify -ping test2.png

test2.png PNG 16x16 16x16+0+0 16-bit DirectClass 1.31KB 0.000u 0:00.000

But what do test1.png and test2.png look like? Do they have a black background or a transparent one?

> Thanks. > > Rouslan

Reply

Marc Delisle

3 Oct 3 Oct

7:21 a.m.

Le 2011-10-02 10:23, Rouslan Placella a écrit :

On Sun, 2011-10-02 at 06:23 -0400, Marc Delisle wrote:

Le 2011-10-01 08:01, Rouslan Placella a écrit :

On Sat, 2011-10-01 at 06:54 -0400, Marc Delisle wrote:

Le 2011-09-30 14:59, Rouslan Placella a écrit : > Hi there, > > I've just pushed the new sprites implementation to master and updated > the relevant wiki page [1]. Please take the time to read this > documentation. Thank you. > > If you have any feedback on the matter, I'd love to hear it. > > Rouslan > > [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage Rouslan, after using generate_sprites, all my icons now have a black background. Maybe this is related to the numerous errors I get, such as: identify: invalid colormap index `s_vars.png' @ error/image.c/SyncImage/3899.

Hi Marc, Well, that's not good. Although I doubt that the errors from 'identify' have anything to do with the issue, since that program is only used to extract the height and width from image files. Do you get any errors from 'convert'? Anyway, under what OS were you running the script? What does "convert --version" say? Also can you run the below commands and let me know what the output is and what the resulting images look like?

Version: ImageMagick 6.6.1-5 2010-04-28 Q16 http://www.imagemagick.org

cd /path/to/phpmyadmin/ convert -size 16x16 xc:none test1.png convert test1.png themes/pmahomme/img/b_drop.png -composite test2.png identify -ping test1.png

test1.png PNG 16x16 16x16+0+0 16-bit PseudoClass 65536c 229B 0.000u 0:00.000

identify -ping test2.png

test2.png PNG 16x16 16x16+0+0 16-bit DirectClass 1.31KB 0.000u 0:00.000

But what do test1.png and test2.png look like? Do they have a black background or a transparent one?

Sorry, I missed that part of the question. test1.png has a transparent background; test2.png has a black background. -- Marc Delisle http://infomarc.info

Reply

Rouslan Placella

10:01 a.m.

On Mon, 2011-10-03 at 06:21 -0400, Marc Delisle wrote:

Le 2011-10-02 10:23, Rouslan Placella a écrit :

On Sun, 2011-10-02 at 06:23 -0400, Marc Delisle wrote:

Le 2011-10-01 08:01, Rouslan Placella a écrit :

On Sat, 2011-10-01 at 06:54 -0400, Marc Delisle wrote: > Le 2011-09-30 14:59, Rouslan Placella a écrit : >> Hi there, >> >> I've just pushed the new sprites implementation to master and updated >> the relevant wiki page [1]. Please take the time to read this >> documentation. Thank you. >> >> If you have any feedback on the matter, I'd love to hear it. >> >> Rouslan >> >> [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage > > Rouslan, > after using generate_sprites, all my icons now have a black background. > Maybe this is related to the numerous errors I get, such as: > > identify: invalid colormap index `s_vars.png' @ > error/image.c/SyncImage/3899. Hi Marc, Well, that's not good. Although I doubt that the errors from 'identify' have anything to do with the issue, since that program is only used to extract the height and width from image files. Do you get any errors from 'convert'? Anyway, under what OS were you running the script? What does "convert --version" say? Also can you run the below commands and let me know what the output is and what the resulting images look like?

Version: ImageMagick 6.6.1-5 2010-04-28 Q16 http://www.imagemagick.org

cd /path/to/phpmyadmin/ convert -size 16x16 xc:none test1.png convert test1.png themes/pmahomme/img/b_drop.png -composite test2.png identify -ping test1.png

test1.png PNG 16x16 16x16+0+0 16-bit PseudoClass 65536c 229B 0.000u 0:00.000

identify -ping test2.png

test2.png PNG 16x16 16x16+0+0 16-bit DirectClass 1.31KB 0.000u 0:00.000

But what do test1.png and test2.png look like? Do they have a black background or a transparent one?

Sorry, I missed that part of the question. test1.png has a transparent background; test2.png has a black background.

I've tried compiling the exact version of ImageMagick that you are using and I still don't experience your issue. Anyway, it looks like the alpha channel is being discarded for some reason. Could you try the below commands to see if the composition will work by explicitly turning the alpha channel on and let me know what the resulting images look like (and any errors that you might get)? Thanks. cd /path/to/phpmyadmin/ convert -size 16x16 xc:none test1.png convert test1.png themes/pmahomme/img/b_drop.png -composite -alpha on test2.png convert test1.png themes/pmahomme/img/b_drop.png -composite -alpha set test3.png I'm also still wondering if you running the script on linux or msys... Rouslan

Reply

Marc Delisle

10:18 a.m.

Rouslan Placella a écrit :

On Mon, 2011-10-03 at 06:21 -0400, Marc Delisle wrote:

Le 2011-10-02 10:23, Rouslan Placella a écrit :

On Sun, 2011-10-02 at 06:23 -0400, Marc Delisle wrote:

Le 2011-10-01 08:01, Rouslan Placella a écrit : > On Sat, 2011-10-01 at 06:54 -0400, Marc Delisle wrote: >> Le 2011-09-30 14:59, Rouslan Placella a écrit : >>> Hi there, >>> >>> I've just pushed the new sprites implementation to master and updated >>> the relevant wiki page [1]. Please take the time to read this >>> documentation. Thank you. >>> >>> If you have any feedback on the matter, I'd love to hear it. >>> >>> Rouslan >>> >>> [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage >> Rouslan, >> after using generate_sprites, all my icons now have a black background. >> Maybe this is related to the numerous errors I get, such as: >> >> identify: invalid colormap index `s_vars.png' @ >> error/image.c/SyncImage/3899. > Hi Marc, > > Well, that's not good. Although I doubt that the errors from 'identify' > have anything to do with the issue, since that program is only used to > extract the height and width from image files. Do you get any errors > from 'convert'? > > Anyway, under what OS were you running the script? What does "convert > --version" say? Also can you run the below commands and let me know what > the output is and what the resulting images look like? Version: ImageMagick 6.6.1-5 2010-04-28 Q16 http://www.imagemagick.org > cd /path/to/phpmyadmin/ > convert -size 16x16 xc:none test1.png > convert test1.png themes/pmahomme/img/b_drop.png -composite test2.png > identify -ping test1.png test1.png PNG 16x16 16x16+0+0 16-bit PseudoClass 65536c 229B 0.000u 0:00.000 > identify -ping test2.png test2.png PNG 16x16 16x16+0+0 16-bit DirectClass 1.31KB 0.000u 0:00.000

But what do test1.png and test2.png look like? Do they have a black background or a transparent one?

Sorry, I missed that part of the question. test1.png has a transparent background; test2.png has a black background.

I've tried compiling the exact version of ImageMagick that you are using and I still don't experience your issue. Anyway, it looks like the alpha channel is being discarded for some reason. Could you try the below commands to see if the composition will work by explicitly turning the alpha channel on and let me know what the resulting images look like (and any errors that you might get)? Thanks. cd /path/to/phpmyadmin/ convert -size 16x16 xc:none test1.png convert test1.png themes/pmahomme/img/b_drop.png -composite -alpha on test2.png convert test1.png themes/pmahomme/img/b_drop.png -composite -alpha set test3.png

Both test2 and test3 have a black background.

I'm also still wondering if you running the script on linux or msys...

Linux. I believe that this will be a problem only for someone creating/modifying icons so we can wait to see if others have the problem. -- Marc Delisle http://infomarc.info

Reply

Isaac Bennetch

3:49 p.m.

On 10/1/2011 6:54 AM, Marc Delisle wrote:

Le 2011-09-30 14:59, Rouslan Placella a écrit :

Hi there, I've just pushed the new sprites implementation to master and updated the relevant wiki page [1]. Please take the time to read this documentation. Thank you. If you have any feedback on the matter, I'd love to hear it. Rouslan [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage

Rouslan, after using generate_sprites, all my icons now have a black background. Maybe this is related to the numerous errors I get, such as: identify: invalid colormap index `s_vars.png' @ error/image.c/SyncImage/3899.

I've tested this and my ...img/sprites.png file doesn't show any black background. The icons appear correctly. Debian Linux, 2.6.37.2 custom kernel Version: ImageMagick 6.6.0-4 2010-11-16 Q16 http://www.imagemagick.org ~isaac

Reply

Marc Delisle

4 Oct 4 Oct

6:22 a.m.

Le 2011-10-03 14:49, Isaac Bennetch a écrit :

On 10/1/2011 6:54 AM, Marc Delisle wrote:

Le 2011-09-30 14:59, Rouslan Placella a écrit :

Hi there, I've just pushed the new sprites implementation to master and updated the relevant wiki page [1]. Please take the time to read this documentation. Thank you. If you have any feedback on the matter, I'd love to hear it. Rouslan [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage

Rouslan, after using generate_sprites, all my icons now have a black background. Maybe this is related to the numerous errors I get, such as: identify: invalid colormap index `s_vars.png' @ error/image.c/SyncImage/3899.

I've tested this and my ...img/sprites.png file doesn't show any black background. The icons appear correctly. Debian Linux, 2.6.37.2 custom kernel Version: ImageMagick 6.6.0-4 2010-11-16 Q16 http://www.imagemagick.org ~isaac

By the way, I'm on a 64-bit machine. -- Marc Delisle http://infomarc.info

Reply

4723

days inactive

4727

days old

developers@phpmyadmin.net

Manage subscription

9 comments

3 participants

tags (0)

participants (3)

Isaac Bennetch
Marc Delisle
Rouslan Placella