Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: ae625702f1a76333e39b8ee8d023d6d0ce769e8a
https://github.com/phpmyadmin/phpmyadmin/commit/ae625702f1a76333e39b8ee8d02…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-10 (Fri, 05 May 2024) -03:00
Changed paths:
M app/services_controllers.php
M psalm-baseline.xml
M src/Controllers/Setup/ShowConfigController.php
M src/Routing/Routing.php
M tests/unit/Routing/RoutingTest.php
Log Message:
-----------
Refactor Routing::callSetupController() to use ContainerBuilder
Uses the ContainerBuilder to factory the setup controllers.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 9cac3a9bcc60b6c65ff0beaf7e077a729db73cdf
https://github.com/phpmyadmin/phpmyadmin/commit/9cac3a9bcc60b6c65ff0beaf7e0…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-10 (Fri, 05 May 2024) -03:00
Changed paths:
M src/Controllers/Setup/ConfigController.php
M src/Controllers/Setup/FormController.php
M src/Controllers/Setup/HomeController.php
M src/Controllers/Setup/MainController.php
M src/Controllers/Setup/ServersController.php
Log Message:
-----------
Pass ServerRequest object directly to setup controllers
Instead of passing an array of parameters.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 2fe67cc85b406caadaf079525c8686ac6043ee50
https://github.com/phpmyadmin/phpmyadmin/commit/2fe67cc85b406caadaf079525c8…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-10 (Fri, 05 May 2024) -03:00
Changed paths:
A src/Controllers/Setup/ServerDestroyController.php
M phpstan-baseline.neon
M src/Controllers/Setup/MainController.php
M src/Controllers/Setup/ServersController.php
Log Message:
-----------
Extract destroy action from Setup\ServersController
Extracts it into a new controller called Setup\ServerDestroyController.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 52b3ef44959127a30830b0d3e95b171fbbc0611a
https://github.com/phpmyadmin/phpmyadmin/commit/52b3ef44959127a30830b0d3e95…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-10 (Fri, 05 May 2024) -03:00
Changed paths:
A src/Setup/SetupHelper.php
A tests/unit/Setup/SetupHelperTest.php
M phpstan-baseline.neon
M psalm-baseline.xml
M psalm.xml
M src/Config/PageSettings.php
M src/Controllers/Preferences/ExportController.php
M src/Controllers/Preferences/FeaturesController.php
M src/Controllers/Preferences/ImportController.php
M src/Controllers/Preferences/MainPanelController.php
M src/Controllers/Preferences/ManageController.php
M src/Controllers/Preferences/NavigationController.php
M src/Controllers/Preferences/SqlController.php
M src/Controllers/Setup/AbstractController.php
M src/Controllers/Setup/ConfigController.php
M src/Controllers/Setup/FormController.php
M src/Controllers/Setup/HomeController.php
M src/Controllers/Setup/MainController.php
M src/Controllers/Setup/ServerDestroyController.php
M src/Controllers/Setup/ServersController.php
M src/Controllers/Setup/ShowConfigController.php
M src/Controllers/Setup/ValidateController.php
M src/Http/Middleware/SetupPageRedirection.php
M tests/unit/Config/ServerConfigChecksTest.php
Log Message:
-----------
Remove Config\ConfigFile global variables
- Removes the 'cf' and 'ConfigFile' global variables.
- Extracts the ConfigFile creation from SetupPageRedirection middleware
and moves it to the Setup\SetupHelper class.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 32447c6f72080d030d001f9a288467f90be75a44
https://github.com/phpmyadmin/phpmyadmin/commit/32447c6f72080d030d001f9a288…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-10 (Fri, 05 May 2024) -03:00
Changed paths:
M src/Controllers/Setup/ConfigController.php
M src/Controllers/Setup/FormController.php
M src/Controllers/Setup/HomeController.php
M src/Controllers/Setup/MainController.php
M src/Controllers/Setup/ServerDestroyController.php
M src/Controllers/Setup/ServersController.php
M src/Setup/SetupHelper.php
M tests/unit/Setup/SetupHelperTest.php
D src/Controllers/Setup/AbstractController.php
Log Message:
-----------
Remove Controllers\Setup\AbstractController class
Extracts AbstractController::getPages into SetupHelper class.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 0a681ea9ed7dc04701746012636aa20477211105
https://github.com/phpmyadmin/phpmyadmin/commit/0a681ea9ed7dc04701746012636…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-11 (Sat, 05 May 2024) -03:00
Changed paths:
M app/services_controllers.php
M src/Controllers/Setup/ConfigController.php
M src/Controllers/Setup/FormController.php
M src/Controllers/Setup/HomeController.php
M src/Controllers/Setup/MainController.php
M src/Controllers/Setup/ServerDestroyController.php
M src/Controllers/Setup/ServersController.php
Log Message:
-----------
Make all setup controllers implement InvocableController
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 126ac3ac5662ed3171ef3646636348fad3f8e952
https://github.com/phpmyadmin/phpmyadmin/commit/126ac3ac5662ed3171ef3646636…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-11 (Sat, 05 May 2024) -03:00
Changed paths:
M app/services_controllers.php
M phpstan-baseline.neon
M psalm-baseline.xml
M src/Controllers/Setup/ConfigController.php
M src/Controllers/Setup/FormController.php
M src/Controllers/Setup/HomeController.php
M src/Controllers/Setup/MainController.php
M src/Controllers/Setup/ServerDestroyController.php
M src/Controllers/Setup/ServersController.php
M src/Controllers/Setup/ShowConfigController.php
M src/Controllers/Setup/ValidateController.php
Log Message:
-----------
Move check if setup is enabled to each setup controller
Removes it from the Setup\MainController as it will be removed in the
future.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: de7572b9145a5c21b3bd9e150fb2dce39343fcde
https://github.com/phpmyadmin/phpmyadmin/commit/de7572b9145a5c21b3bd9e150fb…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-11 (Sat, 05 May 2024) -03:00
Changed paths:
M psalm-baseline.xml
M src/Controllers/Setup/FormController.php
M src/Controllers/Setup/ServersController.php
D src/Setup/FormProcessing.php
D tests/unit/Setup/FormProcessingTest.php
Log Message:
-----------
Inline and remove the Setup\FormProcessing class
This helps with the response handling.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: c7963eab22df14866efd6af46126a1d0f8958238
https://github.com/phpmyadmin/phpmyadmin/commit/c7963eab22df14866efd6af4612…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-11 (Sat, 05 May 2024) -03:00
Changed paths:
M app/services_controllers.php
M src/Controllers/Setup/ShowConfigController.php
Log Message:
-----------
Remove ResponseRenderer::disable from Setup\ShowConfigController
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 510e442593af5d4702bbb46cdb45ad51f3a8a9d3
https://github.com/phpmyadmin/phpmyadmin/commit/510e442593af5d4702bbb46cdb4…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-13 (Mon, 05 May 2024) -03:00
Changed paths:
A src/Controllers/Setup/ServerDestroyController.php
A src/Setup/SetupHelper.php
A tests/unit/Setup/SetupHelperTest.php
M app/services_controllers.php
M phpstan-baseline.neon
M psalm-baseline.xml
M psalm.xml
M src/Config/PageSettings.php
M src/Controllers/Preferences/ExportController.php
M src/Controllers/Preferences/FeaturesController.php
M src/Controllers/Preferences/ImportController.php
M src/Controllers/Preferences/MainPanelController.php
M src/Controllers/Preferences/ManageController.php
M src/Controllers/Preferences/NavigationController.php
M src/Controllers/Preferences/SqlController.php
M src/Controllers/Setup/ConfigController.php
M src/Controllers/Setup/FormController.php
M src/Controllers/Setup/HomeController.php
M src/Controllers/Setup/MainController.php
M src/Controllers/Setup/ServersController.php
M src/Controllers/Setup/ShowConfigController.php
M src/Controllers/Setup/ValidateController.php
M src/Http/Middleware/SetupPageRedirection.php
M src/Routing/Routing.php
M tests/unit/Config/ServerConfigChecksTest.php
M tests/unit/Routing/RoutingTest.php
D src/Controllers/Setup/AbstractController.php
D src/Setup/FormProcessing.php
D tests/unit/Setup/FormProcessingTest.php
Log Message:
-----------
Merge pull request #19156 from MauricioFauth/setup-controllers
Refactor setup controllers to implement InvocableController
Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: cfdaedb6232f3ce92118387c3ba60efb7aad6edc
https://github.com/phpmyadmin/phpmyadmin/commit/cfdaedb6232f3ce92118387c3ba…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
A src/Exceptions/AuthenticationFailure.php
A tests/unit/Exceptions/AuthenticationFailureTest.php
M docs/faq.rst
M src/Http/Middleware/Authentication.php
M src/Plugins/Auth/AuthenticationConfig.php
M src/Plugins/Auth/AuthenticationCookie.php
M src/Plugins/Auth/AuthenticationHttp.php
M src/Plugins/Auth/AuthenticationSignon.php
M src/Plugins/AuthenticationPlugin.php
M tests/unit/Plugins/Auth/AuthenticationConfigTest.php
M tests/unit/Plugins/Auth/AuthenticationCookieTest.php
M tests/unit/Plugins/Auth/AuthenticationHttpTest.php
M tests/unit/Plugins/Auth/AuthenticationSignonTest.php
M tests/unit/Plugins/AuthenticationPluginTest.php
Log Message:
-----------
Create AuthenticationFailure exception
Refactors the AuthenticationPlugin::showFailure() to receive the new
exception and move the showFailure calls to the Authentication
middleware.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: ad98ad27cbb591b72f4b59f3eada7432792ed9ae
https://github.com/phpmyadmin/phpmyadmin/commit/ad98ad27cbb591b72f4b59f3ead…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
M psalm-baseline.xml
M src/Http/Middleware/Authentication.php
M src/Plugins/Auth/AuthenticationConfig.php
M src/Plugins/Auth/AuthenticationCookie.php
M src/Plugins/Auth/AuthenticationHttp.php
M src/Plugins/Auth/AuthenticationSignon.php
M src/Plugins/AuthenticationPlugin.php
M tests/unit/Plugins/Auth/AuthenticationConfigTest.php
M tests/unit/Plugins/Auth/AuthenticationCookieTest.php
M tests/unit/Plugins/Auth/AuthenticationHttpTest.php
M tests/unit/Plugins/AuthenticationPluginTest.php
Log Message:
-----------
Change AuthenticationPlugin::showFailure() return type
Instead of throwing an ExitException, showFailure() now returns
a Response object.
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: aa70f48537fb6ee8e74f37b1773ff5e0fc8a37c4
https://github.com/phpmyadmin/phpmyadmin/commit/aa70f48537fb6ee8e74f37b1773…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
M src/Http/Middleware/Authentication.php
M src/Plugins/AuthenticationPlugin.php
M tests/unit/Plugins/Auth/AuthenticationCookieTest.php
Log Message:
-----------
Remove callExit() from AuthenticationPlugin::authenticate()
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: d0121dcf5de25d2aabb0112684e041ab98ad7d26
https://github.com/phpmyadmin/phpmyadmin/commit/d0121dcf5de25d2aabb0112684e…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
M src/Plugins/Auth/AuthenticationConfig.php
M src/Plugins/Auth/AuthenticationCookie.php
M src/Plugins/Auth/AuthenticationHttp.php
M src/Plugins/Auth/AuthenticationSignon.php
M src/Plugins/AuthenticationPlugin.php
M tests/unit/Plugins/Auth/AuthenticationConfigTest.php
M tests/unit/Plugins/Auth/AuthenticationCookieTest.php
M tests/unit/Plugins/Auth/AuthenticationHttpTest.php
M tests/unit/Plugins/Auth/AuthenticationSignonTest.php
M tests/unit/Plugins/AuthenticationPluginTest.php
Log Message:
-----------
Remove callExit() from AuthenticationPlugin::showLoginForm()
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 70757ceede8c1e99da2b7d0c93f8b30240ab0bcc
https://github.com/phpmyadmin/phpmyadmin/commit/70757ceede8c1e99da2b7d0c93f…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
M psalm-baseline.xml
M src/Http/Middleware/Authentication.php
M src/Plugins/Auth/AuthenticationCookie.php
M src/Plugins/AuthenticationPlugin.php
M tests/unit/Plugins/Auth/AuthenticationCookieTest.php
Log Message:
-----------
Remove callExit() from AuthenticationCookie::rememberCredentials()
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 02044f216090949fcedc82082720422bc1ec77b8
https://github.com/phpmyadmin/phpmyadmin/commit/02044f216090949fcedc8208272…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
M src/Http/Middleware/Authentication.php
M src/Plugins/AuthenticationPlugin.php
M tests/unit/Plugins/AuthenticationPluginTest.php
Log Message:
-----------
Remove callExit() from AuthenticationPlugin::checkTwoFactor()
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: e435bb7129f5520c2bb4b49463f136d8feecd397
https://github.com/phpmyadmin/phpmyadmin/commit/e435bb7129f5520c2bb4b49463f…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
M src/Plugins/Auth/AuthenticationHttp.php
M tests/unit/Plugins/Auth/AuthenticationCookieTest.php
M tests/unit/Plugins/Auth/AuthenticationHttpTest.php
Log Message:
-----------
Remove callExit() from AuthenticationHttp::authForm()
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: bc00b69050536b569905f49aec1343906afa90de
https://github.com/phpmyadmin/phpmyadmin/commit/bc00b69050536b569905f49aec1…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
M src/Http/Middleware/Authentication.php
M src/Plugins/Auth/AuthenticationCookie.php
M src/Plugins/Auth/AuthenticationSignon.php
M src/Plugins/AuthenticationPlugin.php
Log Message:
-----------
Remove callExit() from AuthenticationPlugin::readCredentials()
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: 6a425a2d00e070b6ceb29387ed4ef73a34db1623
https://github.com/phpmyadmin/phpmyadmin/commit/6a425a2d00e070b6ceb29387ed4…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-09 (Thu, 05 May 2024) -03:00
Changed paths:
M src/Exceptions/AuthenticationFailure.php
M src/Http/Middleware/Authentication.php
M src/Plugins/Auth/AuthenticationCookie.php
M src/Plugins/AuthenticationPlugin.php
M tests/unit/Exceptions/AuthenticationFailureTest.php
M tests/unit/Plugins/Auth/AuthenticationConfigTest.php
M tests/unit/Plugins/Auth/AuthenticationCookieTest.php
M tests/unit/Plugins/Auth/AuthenticationHttpTest.php
M tests/unit/Plugins/Auth/AuthenticationSignonTest.php
Log Message:
-----------
Add better method names for Exceptions\AuthenticationFailure
Signed-off-by: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Commit: b93d1b9b5203f7535f513d5d1bd2093a0a5b3ed3
https://github.com/phpmyadmin/phpmyadmin/commit/b93d1b9b5203f7535f513d5d1bd…
Author: MaurÃcio Meneghini Fauth <mauricio(a)fauth.dev>
Date: 2024-05-11 (Sat, 05 May 2024) -03:00
Changed paths:
A src/Exceptions/AuthenticationFailure.php
A tests/unit/Exceptions/AuthenticationFailureTest.php
M docs/faq.rst
M psalm-baseline.xml
M src/Http/Middleware/Authentication.php
M src/Plugins/Auth/AuthenticationConfig.php
M src/Plugins/Auth/AuthenticationCookie.php
M src/Plugins/Auth/AuthenticationHttp.php
M src/Plugins/Auth/AuthenticationSignon.php
M src/Plugins/AuthenticationPlugin.php
M tests/unit/Plugins/Auth/AuthenticationConfigTest.php
M tests/unit/Plugins/Auth/AuthenticationCookieTest.php
M tests/unit/Plugins/Auth/AuthenticationHttpTest.php
M tests/unit/Plugins/Auth/AuthenticationSignonTest.php
M tests/unit/Plugins/AuthenticationPluginTest.php
Log Message:
-----------
Merge pull request #19154 from MauricioFauth/auth-plugin-response-handling
Remove ResponseRenderer::callExit() calls from auth plugins