[phpmyadmin/phpmyadmin] 63e641: Refactor the DbTableExists class - Git

6 Aug 2023


      Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 63e64107282cc826209124b500c2d3402b1fcd20
https://github.com/phpmyadmin/phpmyadmin/commit/63e64107282cc826209124b500c2...
Author: Maurício Meneghini Fauth mauricio@fauth.dev
Date: 2023-08-06 (Sun, 08 August 2023) -03:00
Changed paths: 
A test/classes/DbTableExistsTest.php
M libraries/classes/Controllers/AbstractController.php
M libraries/classes/Controllers/Database/DesignerController.php
M libraries/classes/Controllers/Database/EventsController.php
M libraries/classes/Controllers/Database/ExportController.php
M libraries/classes/Controllers/Database/ImportController.php
M libraries/classes/Controllers/Database/Operations/CollationController.php
M libraries/classes/Controllers/Database/OperationsController.php
M libraries/classes/Controllers/Database/RoutinesController.php
M libraries/classes/Controllers/Database/SearchController.php
M libraries/classes/Controllers/Database/SqlController.php
M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php
M libraries/classes/Controllers/Database/Structure/RealRowCountController.php
M libraries/classes/Controllers/Database/StructureController.php
M libraries/classes/Controllers/Database/TrackingController.php
M libraries/classes/Controllers/Table/AddFieldController.php
M libraries/classes/Controllers/Table/ChangeController.php
M libraries/classes/Controllers/Table/ChartController.php
M libraries/classes/Controllers/Table/DeleteConfirmController.php
M libraries/classes/Controllers/Table/DropColumnConfirmationController.php
M libraries/classes/Controllers/Table/FindReplaceController.php
M libraries/classes/Controllers/Table/GisVisualizationController.php
M libraries/classes/Controllers/Table/ImportController.php
M libraries/classes/Controllers/Table/IndexRenameController.php
M libraries/classes/Controllers/Table/IndexesController.php
M libraries/classes/Controllers/Table/OperationsController.php
M libraries/classes/Controllers/Table/SearchController.php
M libraries/classes/Controllers/Table/SqlController.php
M libraries/classes/Controllers/Table/Structure/PrimaryController.php
M libraries/classes/Controllers/Table/StructureController.php
M libraries/classes/Controllers/Table/TrackingController.php
M libraries/classes/Controllers/Table/ZoomSearchController.php
M libraries/classes/Controllers/Transformation/WrapperController.php
M libraries/classes/Controllers/Triggers/IndexController.php
M libraries/classes/Controllers/View/CreateController.php
M libraries/classes/Controllers/View/OperationsController.php
M libraries/classes/DbTableExists.php
M libraries/services.php
M libraries/services_controllers.php
M phpstan-baseline.neon
M psalm-baseline.xml
M test/classes/Controllers/Database/EventsControllerTest.php
M test/classes/Controllers/Database/RoutinesControllerTest.php
M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php
M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php
M test/classes/Controllers/Database/StructureControllerTest.php
M test/classes/Controllers/Table/AddFieldControllerTest.php
M test/classes/Controllers/Table/ChangeControllerTest.php
M test/classes/Controllers/Table/ChartControllerTest.php
M test/classes/Controllers/Table/DeleteConfirmControllerTest.php
M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php
M test/classes/Controllers/Table/FindReplaceControllerTest.php
M test/classes/Controllers/Table/GisVisualizationControllerTest.php
M test/classes/Controllers/Table/ImportControllerTest.php
M test/classes/Controllers/Table/IndexRenameControllerTest.php
M test/classes/Controllers/Table/IndexesControllerTest.php
M test/classes/Controllers/Table/OperationsControllerTest.php
M test/classes/Controllers/Table/ReplaceControllerTest.php
M test/classes/Controllers/Table/SearchControllerTest.php
M test/classes/Controllers/Table/SqlControllerTest.php
M test/classes/Controllers/Table/StructureControllerTest.php
M test/classes/Controllers/Table/TrackingControllerTest.php
M test/classes/Controllers/Table/ZoomSearchControllerTest.php
M test/classes/Controllers/Triggers/IndexControllerTest.php
M test/classes/Plugins/Auth/AuthenticationHttpTest.php
Log Message:
-----------
Refactor the DbTableExists class
- Changes static methods to instance methods
- Extract response handling to the controllers
- Add unit tests for the DbTableExists class
- Remove the AbstractController::hasDatabase() method
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: e8ebb663ccceae210ba601d0efbe3ffcbf0f44e8
https://github.com/phpmyadmin/phpmyadmin/commit/e8ebb663ccceae210ba601d0efbe...
Author: Maurício Meneghini Fauth mauricio@fauth.dev
Date: 2023-08-06 (Sun, 08 August 2023) -03:00
Changed paths: 
A test/classes/DbTableExistsTest.php
M libraries/classes/Controllers/AbstractController.php
M libraries/classes/Controllers/Database/DesignerController.php
M libraries/classes/Controllers/Database/EventsController.php
M libraries/classes/Controllers/Database/ExportController.php
M libraries/classes/Controllers/Database/ImportController.php
M libraries/classes/Controllers/Database/Operations/CollationController.php
M libraries/classes/Controllers/Database/OperationsController.php
M libraries/classes/Controllers/Database/RoutinesController.php
M libraries/classes/Controllers/Database/SearchController.php
M libraries/classes/Controllers/Database/SqlController.php
M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php
M libraries/classes/Controllers/Database/Structure/RealRowCountController.php
M libraries/classes/Controllers/Database/StructureController.php
M libraries/classes/Controllers/Database/TrackingController.php
M libraries/classes/Controllers/Table/AddFieldController.php
M libraries/classes/Controllers/Table/ChangeController.php
M libraries/classes/Controllers/Table/ChartController.php
M libraries/classes/Controllers/Table/DeleteConfirmController.php
M libraries/classes/Controllers/Table/DropColumnConfirmationController.php
M libraries/classes/Controllers/Table/FindReplaceController.php
M libraries/classes/Controllers/Table/GisVisualizationController.php
M libraries/classes/Controllers/Table/ImportController.php
M libraries/classes/Controllers/Table/IndexRenameController.php
M libraries/classes/Controllers/Table/IndexesController.php
M libraries/classes/Controllers/Table/OperationsController.php
M libraries/classes/Controllers/Table/SearchController.php
M libraries/classes/Controllers/Table/SqlController.php
M libraries/classes/Controllers/Table/Structure/PrimaryController.php
M libraries/classes/Controllers/Table/StructureController.php
M libraries/classes/Controllers/Table/TrackingController.php
M libraries/classes/Controllers/Table/ZoomSearchController.php
M libraries/classes/Controllers/Transformation/WrapperController.php
M libraries/classes/Controllers/Triggers/IndexController.php
M libraries/classes/Controllers/View/CreateController.php
M libraries/classes/Controllers/View/OperationsController.php
M libraries/classes/DbTableExists.php
M libraries/services.php
M libraries/services_controllers.php
M phpstan-baseline.neon
M psalm-baseline.xml
M test/classes/Controllers/Database/EventsControllerTest.php
M test/classes/Controllers/Database/RoutinesControllerTest.php
M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php
M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php
M test/classes/Controllers/Database/StructureControllerTest.php
M test/classes/Controllers/Table/AddFieldControllerTest.php
M test/classes/Controllers/Table/ChangeControllerTest.php
M test/classes/Controllers/Table/ChartControllerTest.php
M test/classes/Controllers/Table/DeleteConfirmControllerTest.php
M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php
M test/classes/Controllers/Table/FindReplaceControllerTest.php
M test/classes/Controllers/Table/GisVisualizationControllerTest.php
M test/classes/Controllers/Table/ImportControllerTest.php
M test/classes/Controllers/Table/IndexRenameControllerTest.php
M test/classes/Controllers/Table/IndexesControllerTest.php
M test/classes/Controllers/Table/OperationsControllerTest.php
M test/classes/Controllers/Table/ReplaceControllerTest.php
M test/classes/Controllers/Table/SearchControllerTest.php
M test/classes/Controllers/Table/SqlControllerTest.php
M test/classes/Controllers/Table/StructureControllerTest.php
M test/classes/Controllers/Table/TrackingControllerTest.php
M test/classes/Controllers/Table/ZoomSearchControllerTest.php
M test/classes/Controllers/Triggers/IndexControllerTest.php
M test/classes/Plugins/Auth/AuthenticationHttpTest.php
Log Message:
-----------
Merge pull request #18602 from MauricioFauth/db-table-exists-refactor
Refactor the DbTableExists class