Git November 2016

git@phpmyadmin.net

22 participants
263 discussions

[phpmyadmin/phpmyadmin] 9dbe52: Strip null bytes from MySQL username

by Isaac Bennetch

Branch: refs/heads/QA_4_6 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 9dbe520e905344597554b06931bd966ce195b9dc https://github.com/phpmyadmin/phpmyadmin/commit/9dbe520e905344597554b06931b… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/core.lib.php M libraries/plugins/auth/AuthenticationCookie.php M libraries/plugins/auth/AuthenticationHttp.php Log Message: ----------- Strip null bytes from MySQL username In old PHP versions this could lead to allow/deny rules bypass. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 2de86f02af17f49e22d6474542770d72dd4723b3 https://github.com/phpmyadmin/phpmyadmin/commit/2de86f02af17f49e22d64745427… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/ip_allow_deny.lib.php Log Message: ----------- Use hash_equals for comparing username in allow/deny rules The comparison should happen in constant time to avoid possible leak of usernames in rules. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: c83b2b0872c035d2625f631a341cb2009ceb9d22 https://github.com/phpmyadmin/phpmyadmin/commit/c83b2b0872c035d2625f631a341… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/plugins/auth/AuthenticationCookie.php M libraries/plugins/auth/AuthenticationHttp.php Log Message: ----------- Use hash_equals for checking username This makes the comparison happen in constant time and makes it impossible to use it to guess stored usernames. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 61976131350eca8cbba74270a44ea7baa708259f https://github.com/phpmyadmin/phpmyadmin/commit/61976131350eca8cbba74270a44… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/VersionInformation.php Log Message: ----------- Silent errors when getting remote file - both curl and fopen wrappers can emmit errors in cases where remote site is not accessible - do not pass false value to json_decode Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: cf83d6afbe4383e7668c1207be6d5bee0646be04 https://github.com/phpmyadmin/phpmyadmin/commit/cf83d6afbe4383e7668c1207be6… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/export.lib.php Log Message: ----------- Remove debugging code Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: a0ca9394a214afd15a4b883f8953b7b32f3caf04 https://github.com/phpmyadmin/phpmyadmin/commit/a0ca9394a214afd15a4b883f895… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/Error.php M test/classes/ErrorTest.php Log Message: ----------- Strip path even if openbasedir restrictions apply This really should not be the case here as what we get here is code executed by PHP, so it should have already passed openbasedir restrictions. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 6e3282e15856192d484f2c56a7ae83796bf2e716 https://github.com/phpmyadmin/phpmyadmin/commit/6e3282e15856192d484f2c56a7a… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M js/microhistory.js Log Message: ----------- Store copy of hash instead of working on live object This avoids possible race conditions when doing the checks. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: b63bd9977c436f6ad564d429e663bb580bb4e730 https://github.com/phpmyadmin/phpmyadmin/commit/b63bd9977c436f6ad564d429e66… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/navigation/NavigationHeader.php Log Message: ----------- Stricter validation of NavigationLogoLink It now has to be URL including scheme. Otherwise it's not really possible to validate it for being just http/https. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 3ef6201bd6d43eed7f360bb2ead22ef7c484381e https://github.com/phpmyadmin/phpmyadmin/commit/3ef6201bd6d43eed7f360bb2ead… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M js/config.js Log Message: ----------- Fix hash validation - use copy of hash to avoid race condition - stricter regex to match whole string Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 45e33d63a252011b02b55b74432c4a90484eaa5e https://github.com/phpmyadmin/phpmyadmin/commit/45e33d63a252011b02b55b74432… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/DbQbe.php M libraries/SavedSearches.php Log Message: ----------- Limit maximal number of rows in QBE User would be lost in them anyway by that count and it prevents DOS. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: d62494cd8c99185077f516be76093f4cb4a32837 https://github.com/phpmyadmin/phpmyadmin/commit/d62494cd8c99185077f516be760… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M ChangeLog M libraries/core.lib.php M po/sl.po M setup/lib/ConfigGenerator.php M show_config_errors.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: ba82f0000c7837bd3b834b24660325652ec27675 https://github.com/phpmyadmin/phpmyadmin/commit/ba82f0000c7837bd3b834b24660… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M index.php M js/functions.js M libraries/Advisor.php M libraries/Footer.php M libraries/Util.php M libraries/navigation/NavigationHeader.php M libraries/plugins/auth/AuthenticationCookie.php M test/classes/AdvisorTest.php M test/classes/FooterTest.php M themes.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: d5c6801a8580f221fc64471016b06cc4dae9ffba https://github.com/phpmyadmin/phpmyadmin/commit/d5c6801a8580f221fc64471016b… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-24 (Wed, 24 Aug 2016) Changed paths: M ChangeLog M libraries/DisplayResults.php M libraries/navigation/NavigationHeader.php M libraries/plugins/transformations/abs/TextImageLinkTransformationsPlugin.php M libraries/plugins/transformations/abs/TextLinkTransformationsPlugin.php M libraries/sanitizing.lib.php M libraries/special_schema_links.lib.php M po/el.po M po/ia.po M po/pa.po M po/pt_BR.po M po/sl.po M po/uk.po M test/classes/DisplayResultsTest.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: c4714b003c21948e13eb0162c5c951d5e84a1c75 https://github.com/phpmyadmin/phpmyadmin/commit/c4714b003c21948e13eb0162c5c… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-24 (Wed, 24 Aug 2016) Changed paths: M ChangeLog M index.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 0a20356ec4110e682b5bbb219f5f08db10bc418c https://github.com/phpmyadmin/phpmyadmin/commit/0a20356ec4110e682b5bbb219f5… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-25 (Thu, 25 Aug 2016) Changed paths: M ChangeLog M js/get_image.js.php M js/get_scripts.js.php M js/whitelist.php M libraries/Config.php M libraries/Table.php M po/pt.po Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 283f5d10ce65e0656f98335bd1f2767fba3be6db https://github.com/phpmyadmin/phpmyadmin/commit/283f5d10ce65e0656f98335bd1f… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M import.php Log Message: ----------- Fix possible DOS on too big skip value - loop only as long as long we have data to skip - convert skip parameter to integer Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: dcc9f8585c49ce2258d40aea511b524488bbce05 https://github.com/phpmyadmin/phpmyadmin/commit/dcc9f8585c49ce2258d40aea511… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M .gitignore M ChangeLog M js/functions.js M js/sql.js M libraries/Advisor.php M libraries/Linter.php M libraries/Util.php M libraries/common.inc.php M libraries/dbi/DBIMysqli.php M libraries/navigation/nodes/Node.php M libraries/sanitizing.lib.php M po/pt_BR.po M templates/columns_definitions/transformation_option.phtml M test/bootstrap-dist.php M test/libraries/common/PMA_formatNumberByteDown_test.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 7ddcbc0de6283f42fc0592901d88ee53b457bee9 https://github.com/phpmyadmin/phpmyadmin/commit/7ddcbc0de6283f42fc0592901d8… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M libraries/tbl_partition_definition.inc.php Log Message: ----------- Validate (sub)partion count from request before use Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 733a5d582193d32c5435bd6324316c9da1b01678 https://github.com/phpmyadmin/phpmyadmin/commit/733a5d582193d32c5435bd63243… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M libraries/ErrorHandler.php M libraries/Message.php M libraries/plugins/AuthenticationPlugin.php Log Message: ----------- Avoid rendering BB code when showing PHP/MySQL errors Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: d01c078b7d48c8f7d4f0784cb4b04ae933a6d23b https://github.com/phpmyadmin/phpmyadmin/commit/d01c078b7d48c8f7d4f0784cb4b… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M libraries/DatabaseInterface.php M libraries/Error.php M libraries/ErrorHandler.php M libraries/session.inc.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 4c34f140779711e1511c721a262028a929a81f91 https://github.com/phpmyadmin/phpmyadmin/commit/4c34f140779711e1511c721a262… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M libraries/DatabaseInterface.php M libraries/Error.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: dac36c3cd889f87165ae776e3929fe9f946f67ad https://github.com/phpmyadmin/phpmyadmin/commit/dac36c3cd889f87165ae776e392… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M index.php M libraries/core.lib.php M test/libraries/core/PMA_isAllowedDomain_test.php Log Message: ----------- Stricter URL validation - do not use empty() as empty('0') is true - do not lowercase the strings, use them as they are - lowercase all domains in our codebase - do not allow to specify port Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 9f0c4c37f3067abcaa7a40b9ef907e343ee62de4 https://github.com/phpmyadmin/phpmyadmin/commit/9f0c4c37f3067abcaa7a40b9ef9… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M test/classes/MessageTest.php Log Message: ----------- Fix test failures with recent changes to Message class Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 2f2e3565ba1e85072d2c1a1f0a06b84bebce8f9f https://github.com/phpmyadmin/phpmyadmin/commit/2f2e3565ba1e85072d2c1a1f0a0… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M libraries/ip_allow_deny.lib.php Log Message: ----------- Use hash_equals when comparing IPv6 allow rules Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: c4613745f398f0fdd8bb238ce7f02eea58d7125d https://github.com/phpmyadmin/phpmyadmin/commit/c4613745f398f0fdd8bb238ce7f… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M po/ru.po M po/sk.po Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 3d99185919cdca3ea31caafc7421c507086bdb9c https://github.com/phpmyadmin/phpmyadmin/commit/3d99185919cdca3ea31caafc742… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M ChangeLog M libraries/Util.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 2559dc3a62a416eba8284542303173127feeb767 https://github.com/phpmyadmin/phpmyadmin/commit/2559dc3a62a416eba8284542303… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-16 (Fri, 16 Sep 2016) Changed paths: M ChangeLog M import.php M js/config.js M js/functions.js M js/messages.php M js/tbl_structure.js M libraries/DatabaseInterface.php M libraries/VersionInformation.php M libraries/dbi/DBIDummy.php M libraries/import.lib.php M libraries/sanitizing.lib.php M libraries/server_user_groups.lib.php M libraries/sql-parser/src/Components/AlterOperation.php M libraries/sql-parser/src/Components/CreateDefinition.php M libraries/sql-parser/src/Components/IntoKeyword.php M libraries/sql-parser/src/Components/OptionsArray.php M libraries/sql-parser/src/Components/PartitionDefinition.php M libraries/sql-parser/src/Contexts/ContextMySql50000.php M libraries/sql-parser/src/Contexts/ContextMySql50100.php M libraries/sql-parser/src/Contexts/ContextMySql50500.php M libraries/sql-parser/src/Contexts/ContextMySql50600.php M libraries/sql-parser/src/Contexts/ContextMySql50700.php M libraries/sql-parser/src/Statement.php M libraries/sql-parser/src/Statements/CreateStatement.php M libraries/sql-parser/src/Statements/InsertStatement.php M libraries/sql-parser/src/Statements/ReplaceStatement.php M libraries/sql-parser/src/Statements/SetStatement.php M libraries/sql-parser/src/Utils/CLI.php M libraries/sql-parser/src/Utils/Formatter.php M libraries/sql.lib.php M po/az.po M po/hu.po M po/id.po M po/ja.po M po/sk.po M po/zh_CN.po M test/libraries/PMA_sql_test.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 161e408ab760e9be8a58bfdf7ce26881a0570798 https://github.com/phpmyadmin/phpmyadmin/commit/161e408ab760e9be8a58bfdf7ce… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M ChangeLog M doc/setup.rst M doc/transformations.rst M js/common.js M js/export.js M js/functions.js M js/messages.php M js/rte.js M js/tbl_change.js M libraries/DatabaseInterface.php M libraries/Table.php M libraries/export.lib.php M libraries/insert_edit.lib.php M libraries/rte/rte_export.lib.php M libraries/rte/rte_list.lib.php M libraries/rte/rte_routines.lib.php M libraries/rte/rte_words.lib.php M libraries/server_privileges.lib.php M libraries/tbl_info.inc.php M po/de.po M po/nl.po M tbl_operations.php M test/classes/TableTest.php M test/libraries/PMA_export_test.php M test/libraries/PMA_insert_edit_test.php M test/libraries/PMA_server_privileges_test.php M themes/original/css/common.css.php M themes/pmahomme/css/common.css.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: fbad6b9b4d175aa82cd35972aa2dcd9ef3ec4346 https://github.com/phpmyadmin/phpmyadmin/commit/fbad6b9b4d175aa82cd35972aa2… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M libraries/plugins/AuthenticationPlugin.php M libraries/plugins/auth/AuthenticationConfig.php M libraries/plugins/auth/AuthenticationCookie.php M libraries/plugins/auth/AuthenticationHttp.php Log Message: ----------- Verify value of access_time to avoid unwanted session extension We need to ansure the access_time parameter is in valid range to avoid possibility of remotely extending session validity. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 3df5113a8c472567308c913b8a6e68f24a6b1f57 https://github.com/phpmyadmin/phpmyadmin/commit/3df5113a8c472567308c913b8a6… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M ChangeLog M doc/config.rst M js/tbl_structure.js M libraries/Util.php M libraries/config.default.php M libraries/controllers/table/TableSearchController.php M libraries/rte/rte_routines.lib.php M libraries/sql-parser/src/Components/OptionsArray.php M libraries/sql-parser/src/Statements/CreateStatement.php M libraries/sql-parser/src/Statements/InsertStatement.php M libraries/sql-parser/src/Utils/Formatter.php M libraries/sql.lib.php M libraries/tbl_info.inc.php M po/ca.po M po/de.po M po/ja.po M po/ko.po M po/pt_BR.po M po/ru.po M po/sl.po Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: f87358dff730e7a5ada13922108151a9eee107cf https://github.com/phpmyadmin/phpmyadmin/commit/f87358dff730e7a5ada13922108… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-02 (Sun, 02 Oct 2016) Changed paths: M prefs_manage.php Log Message: ----------- Don't assume the default arg_separator in URL Respect the value for arg_separator.input too. Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 17b34be04f5cc2a5f83d73eba7cd41cbc3ebb7b2 https://github.com/phpmyadmin/phpmyadmin/commit/17b34be04f5cc2a5f83d73eba7c… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M libraries/core.lib.php M test/libraries/core/PMA_safeUnserialize_test.php Log Message: ----------- Correctly parse string length when checking serialized data Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: a7a541347b5f5037207a01a2a20a8c13076efce8 https://github.com/phpmyadmin/phpmyadmin/commit/a7a541347b5f5037207a01a2a20… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M prefs_manage.php Log Message: ----------- Merge branch 'QA_4_6-security' of github.com:phpmyadmin/phpmyadmin-security into QA_4_6-security Commit: 69951525318b246193d82ad7e101748a24a18e93 https://github.com/phpmyadmin/phpmyadmin/commit/69951525318b246193d82ad7e10… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M ChangeLog M doc/config.rst M import.php M js/codemirror/addon/lint/sql-lint.js M libraries/Config.php M libraries/Util.php M libraries/server_privileges.lib.php M libraries/sql-parser/src/Component.php M libraries/sql-parser/src/Components/AlterOperation.php M libraries/sql-parser/src/Components/Array2d.php M libraries/sql-parser/src/Components/ArrayObj.php A libraries/sql-parser/src/Components/CaseExpression.php M libraries/sql-parser/src/Components/Condition.php M libraries/sql-parser/src/Components/CreateDefinition.php M libraries/sql-parser/src/Components/DataType.php M libraries/sql-parser/src/Components/Expression.php M libraries/sql-parser/src/Components/ExpressionArray.php M libraries/sql-parser/src/Components/FunctionCall.php M libraries/sql-parser/src/Components/IntoKeyword.php M libraries/sql-parser/src/Components/JoinKeyword.php M libraries/sql-parser/src/Components/Key.php M libraries/sql-parser/src/Components/Limit.php M libraries/sql-parser/src/Components/OptionsArray.php M libraries/sql-parser/src/Components/OrderKeyword.php M libraries/sql-parser/src/Components/ParameterDefinition.php M libraries/sql-parser/src/Components/PartitionDefinition.php M libraries/sql-parser/src/Components/Reference.php M libraries/sql-parser/src/Components/RenameOperation.php M libraries/sql-parser/src/Components/SetOperation.php M libraries/sql-parser/src/Components/UnionKeyword.php M libraries/sql-parser/src/Context.php M libraries/sql-parser/src/Contexts/ContextMySql50000.php M libraries/sql-parser/src/Contexts/ContextMySql50100.php M libraries/sql-parser/src/Contexts/ContextMySql50500.php M libraries/sql-parser/src/Contexts/ContextMySql50600.php M libraries/sql-parser/src/Contexts/ContextMySql50700.php M libraries/sql-parser/src/Exceptions/LexerException.php M libraries/sql-parser/src/Exceptions/ParserException.php M libraries/sql-parser/src/Lexer.php M libraries/sql-parser/src/Parser.php M libraries/sql-parser/src/Statement.php M libraries/sql-parser/src/Statements/AlterStatement.php M libraries/sql-parser/src/Statements/AnalyzeStatement.php M libraries/sql-parser/src/Statements/BackupStatement.php M libraries/sql-parser/src/Statements/CallStatement.php M libraries/sql-parser/src/Statements/CheckStatement.php M libraries/sql-parser/src/Statements/ChecksumStatement.php M libraries/sql-parser/src/Statements/CreateStatement.php M libraries/sql-parser/src/Statements/DeleteStatement.php M libraries/sql-parser/src/Statements/DropStatement.php M libraries/sql-parser/src/Statements/ExplainStatement.php M libraries/sql-parser/src/Statements/InsertStatement.php M libraries/sql-parser/src/Statements/MaintenanceStatement.php M libraries/sql-parser/src/Statements/NotImplementedStatement.php M libraries/sql-parser/src/Statements/OptimizeStatement.php M libraries/sql-parser/src/Statements/RenameStatement.php M libraries/sql-parser/src/Statements/RepairStatement.php M libraries/sql-parser/src/Statements/ReplaceStatement.php M libraries/sql-parser/src/Statements/RestoreStatement.php M libraries/sql-parser/src/Statements/SelectStatement.php M libraries/sql-parser/src/Statements/SetStatement.php M libraries/sql-parser/src/Statements/ShowStatement.php M libraries/sql-parser/src/Statements/TransactionStatement.php M libraries/sql-parser/src/Statements/TruncateStatement.php M libraries/sql-parser/src/Statements/UpdateStatement.php M libraries/sql-parser/src/Token.php M libraries/sql-parser/src/TokensList.php M libraries/sql-parser/src/UtfString.php M libraries/sql-parser/src/Utils/BufferedQuery.php M libraries/sql-parser/src/Utils/CLI.php M libraries/sql-parser/src/Utils/Error.php M libraries/sql-parser/src/Utils/Formatter.php M libraries/sql-parser/src/Utils/Misc.php M libraries/sql-parser/src/Utils/Query.php M libraries/sql-parser/src/Utils/Routine.php M libraries/sql-parser/src/Utils/Table.php M libraries/sql-parser/src/Utils/Tokens.php M libraries/sql.lib.php M po/id.po M po/mk.po M po/sk.po M po/zh_CN.po R scripts/remove_control_m.sh R scripts/revision-info M server_privileges.php M tbl_export.php M themes/original/css/common.css.php M themes/pmahomme/css/common.css.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 3b8fc504d2a3c1da692cfe703d43d6d81cdc5778 https://github.com/phpmyadmin/phpmyadmin/commit/3b8fc504d2a3c1da692cfe703d4… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M libraries/tracking.lib.php Log Message: ----------- Manage new-lines and extra whitespaces properly Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: d74714c45ec246d179aa4b19d81c30903cdff876 https://github.com/phpmyadmin/phpmyadmin/commit/d74714c45ec246d179aa4b19d81… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M libraries/Tracker.php Log Message: ----------- Manage new-lines and extra whitespaces properly Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 47078395c2aea3d63f1b72d2d26afbd85e2f12f5 https://github.com/phpmyadmin/phpmyadmin/commit/47078395c2aea3d63f1b72d2d26… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M ChangeLog M README.rst M doc/setup.rst M index.php M js/console.js M js/pmd/move.js M js/tbl_change.js M libraries/Advisor.php M libraries/Table.php M libraries/common.inc.php M libraries/config/ConfigFile.php M libraries/config/Validator.php M libraries/plugins/export/ExportSql.php M libraries/relation.lib.php M libraries/replication.inc.php M libraries/server_privileges.lib.php M libraries/sql.lib.php M po/af.po M po/ar.po M po/az.po M po/be.po M po/be(a)latin.po M po/bg.po M po/bn.po M po/br.po M po/brx.po M po/bs.po M po/ca.po M po/ckb.po M po/cs.po M po/cy.po M po/da.po M po/de.po M po/el.po M po/en_GB.po M po/eo.po M po/es.po M po/et.po M po/eu.po M po/fa.po M po/fi.po M po/fr.po M po/fy.po M po/gl.po M po/gu.po M po/he.po M po/hi.po M po/hr.po M po/hu.po M po/hy.po M po/ia.po M po/id.po M po/it.po M po/ja.po M po/ka.po M po/kk.po M po/km.po M po/kn.po M po/ko.po M po/ksh.po M po/ky.po M po/li.po M po/lt.po M po/lv.po M po/mk.po M po/ml.po M po/mn.po M po/ms.po M po/nb.po M po/ne.po M po/nl.po M po/pa.po M po/phpmyadmin.pot M po/pl.po M po/pt.po M po/pt_BR.po M po/ro.po M po/ru.po M po/si.po M po/sk.po M po/sl.po M po/sq.po M po/sr.po M po/sr(a)latin.po M po/sv.po M po/ta.po M po/te.po M po/th.po M po/tk.po M po/tr.po M po/tt.po M po/ug.po M po/uk.po M po/ur.po M po/uz.po M po/uz(a)latin.po M po/vi.po M po/vls.po M po/zh_CN.po M po/zh_TW.po M prefs_manage.php M server_replication.php M tbl_export.php M tbl_operations.php M test/classes/TableTest.php M test/classes/config/ConfigFileTest.php M test/classes/plugin/export/ExportSqlTest.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: b31c304459c5da18db59f55d1a2c8c77fed74d1f https://github.com/phpmyadmin/phpmyadmin/commit/b31c304459c5da18db59f55d1a2… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M ChangeLog M js/console.js M js/functions.js M js/messages.php M js/pmd/move.js M js/tbl_change.js M libraries/DisplayResults.php M libraries/Table.php M libraries/sql-parser/src/Components/CreateDefinition.php M libraries/sql-parser/src/Components/Expression.php M libraries/sql-parser/src/Components/JoinKeyword.php M libraries/sql-parser/src/Context.php M libraries/sql-parser/src/Contexts/ContextMySql50000.php M libraries/sql-parser/src/Contexts/ContextMySql50100.php M libraries/sql-parser/src/Contexts/ContextMySql50500.php M libraries/sql-parser/src/Contexts/ContextMySql50600.php M libraries/sql-parser/src/Contexts/ContextMySql50700.php M libraries/sql-parser/src/Lexer.php M libraries/sql-parser/src/Parser.php M libraries/sql-parser/src/Statements/SelectStatement.php M libraries/sql-parser/src/Token.php R phpdox.xml M po/sl.po Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 8119464150081bcc18641281d62991bdff5feff7 https://github.com/phpmyadmin/phpmyadmin/commit/8119464150081bcc18641281d62… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-11-08 (Tue, 08 Nov 2016) Changed paths: M libraries/core.lib.php M test/libraries/core/PMA_sanitizeMySQLHost_test.php Log Message: ----------- Handle multiple `:p` while sanitizing MySQL hosts Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 636a38cf8a3572219c84e893ca5061eafffad7c5 https://github.com/phpmyadmin/phpmyadmin/commit/636a38cf8a3572219c84e893ca5… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-11-08 (Tue, 08 Nov 2016) Changed paths: M ChangeLog M doc/faq.rst M js/functions.js M js/makegrid.js M js/messages.php M js/tbl_change.js M libraries/Footer.php M libraries/Table.php M libraries/pmd_common.php M po/af.po M po/ar.po M po/az.po M po/be.po M po/be(a)latin.po M po/bg.po M po/bn.po M po/br.po M po/brx.po M po/bs.po M po/ca.po M po/ckb.po M po/cs.po M po/cy.po M po/da.po M po/de.po M po/el.po M po/en_GB.po M po/eo.po M po/es.po M po/et.po M po/eu.po M po/fa.po M po/fi.po M po/fr.po M po/fy.po M po/gl.po M po/gu.po M po/he.po M po/hi.po M po/hr.po M po/hu.po M po/hy.po M po/ia.po M po/id.po M po/it.po M po/ja.po M po/ka.po M po/kk.po M po/km.po M po/kn.po M po/ko.po M po/ksh.po M po/ky.po M po/li.po M po/lt.po M po/lv.po M po/mk.po M po/ml.po M po/mn.po M po/ms.po M po/nb.po M po/ne.po M po/nl.po M po/pa.po M po/phpmyadmin.pot M po/pl.po M po/pt.po M po/pt_BR.po M po/ro.po M po/ru.po M po/si.po M po/sk.po M po/sl.po M po/sq.po M po/sr.po M po/sr(a)latin.po M po/sv.po M po/ta.po M po/te.po M po/th.po M po/tk.po M po/tr.po M po/tt.po M po/ug.po M po/uk.po M po/ur.po M po/uz.po M po/uz(a)latin.po M po/vi.po M po/vls.po M po/zh_CN.po M po/zh_TW.po M templates/table/relation/common_form.phtml M templates/table/relation/foreign_key_row.phtml M test/classes/TableTest.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 970de0ac7abe8a4d81333dac3329720f4263654a https://github.com/phpmyadmin/phpmyadmin/commit/970de0ac7abe8a4d81333dac332… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-11-10 (Thu, 10 Nov 2016) Changed paths: M ChangeLog M browse_foreigners.php M db_operations.php M db_tracking.php M import.php M js/pmd/history.js M libraries/DatabaseInterface.php M libraries/DbSearch.php M libraries/DisplayResults.php M libraries/Menu.php M libraries/Partition.php M libraries/RecentFavoriteTable.php M libraries/SavedSearches.php M libraries/SystemDatabase.php M libraries/Table.php M libraries/Tracker.php M libraries/Util.php M libraries/bookmark.lib.php M libraries/central_columns.lib.php M libraries/common.inc.php M libraries/controllers/server/ServerVariablesController.php M libraries/controllers/table/TableSearchController.php M libraries/controllers/table/TableStructureController.php M libraries/create_addfield.lib.php M libraries/db_designer.lib.php M libraries/db_table_exists.lib.php M libraries/dbi/DBIDummy.php M libraries/dbi/DBIExtension.php M libraries/dbi/DBIMysql.php M libraries/dbi/DBIMysqli.php M libraries/display_export.lib.php M libraries/export.lib.php M libraries/import.lib.php M libraries/insert_edit.lib.php M libraries/mysql_charsets.lib.php M libraries/navigation/Navigation.php M libraries/navigation/NavigationTree.php M libraries/navigation/nodes/Node.php M libraries/navigation/nodes/NodeDatabase.php M libraries/navigation/nodes/NodeTable.php M libraries/operations.lib.php M libraries/plugins/export/ExportSql.php M libraries/plugins/export/ExportXml.php M libraries/plugins/import/ImportCsv.php M libraries/plugins/import/ImportLdi.php M libraries/plugins/schema/pdf/Pdf.php M libraries/pmd_common.php M libraries/relation.lib.php M libraries/relation_cleanup.lib.php M libraries/replication.inc.php M libraries/replication_gui.lib.php M libraries/rte/rte_events.lib.php M libraries/rte/rte_list.lib.php M libraries/rte/rte_routines.lib.php M libraries/rte/rte_triggers.lib.php M libraries/rte/rte_words.lib.php M libraries/server_privileges.lib.php M libraries/server_status_monitor.lib.php M libraries/server_user_groups.lib.php M libraries/sql-parser/src/Components/CreateDefinition.php M libraries/sql-parser/src/Parser.php M libraries/sql-parser/src/Statement.php M libraries/sql-parser/src/Utils/Query.php M libraries/sql.lib.php M libraries/tracking.lib.php M libraries/transformations.lib.php M libraries/user_preferences.lib.php M phpunit.xml.dist M po/af.po M po/ar.po M po/az.po M po/be.po M po/be(a)latin.po M po/bg.po M po/bn.po M po/br.po M po/brx.po M po/bs.po M po/ca.po M po/ckb.po M po/cs.po M po/cy.po M po/da.po M po/de.po M po/el.po M po/en_GB.po M po/eo.po M po/es.po M po/et.po M po/eu.po M po/fa.po M po/fi.po M po/fr.po M po/fy.po M po/gl.po M po/gu.po M po/he.po M po/hi.po M po/hr.po M po/hu.po M po/hy.po M po/ia.po M po/id.po M po/it.po M po/ja.po M po/ka.po M po/kk.po M po/km.po M po/kn.po M po/ko.po M po/ksh.po M po/ky.po M po/li.po M po/lt.po M po/lv.po M po/mk.po M po/ml.po M po/mn.po M po/ms.po M po/nb.po M po/ne.po M po/nl.po M po/pa.po M po/phpmyadmin.pot M po/pl.po M po/pt.po M po/pt_BR.po M po/ro.po M po/ru.po M po/si.po M po/sk.po M po/sl.po M po/sq.po M po/sr.po M po/sr(a)latin.po M po/sv.po M po/ta.po M po/te.po M po/th.po M po/tk.po M po/tr.po M po/tt.po M po/ug.po M po/uk.po M po/ur.po M po/uz.po M po/uz(a)latin.po M po/vi.po M po/vls.po M po/zh_CN.po M po/zh_TW.po M test/classes/DbSearchTest.php M test/classes/TableTest.php M test/classes/ThemeManagerTest.php M test/classes/TrackerTest.php M test/classes/controllers/TableSearchControllerTest.php M test/classes/navigation/NavigationTest.php M test/classes/navigation/NodeTest.php M test/classes/plugin/export/ExportHtmlwordTest.php M test/classes/plugin/export/ExportLatexTest.php M test/classes/plugin/export/ExportOdsTest.php M test/classes/plugin/export/ExportOdtTest.php M test/classes/plugin/export/ExportSqlTest.php M test/classes/plugin/export/ExportTexytextTest.php M test/classes/plugin/export/ExportXmlTest.php M test/classes/plugin/import/ImportLdiTest.php M test/classes/plugin/import/ImportOdsTest.php M test/libraries/PMA_PMD_common_test.php M test/libraries/PMA_central_columns_test.php M test/libraries/PMA_designer_test.php M test/libraries/PMA_insert_edit_test.php M test/libraries/PMA_server_privileges_test.php M test/libraries/PMA_server_user_groups_test.php M test/libraries/PMA_user_preferences_test.php M test/libraries/common/PMA_quoting_slashing_test.php M test/libraries/rte/PMA_EVN_getQueryFromRequest_test.php M test/libraries/rte/PMA_RTN_getQueryFromRequest_test.php M user_password.php Log Message: ----------- Merge branch 'QA_4_6' into QA_4_6-security Commit: 5daee71272efd87a24fe58f90303e82a5b6caf6d https://github.com/phpmyadmin/phpmyadmin/commit/5daee71272efd87a24fe58f9030… Author: Isaac Bennetch <bennetch(a)gmail.com> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: M ChangeLog M README M doc/conf.py M libraries/Config.php Log Message: ----------- 4.6.5 release and ChangeLog Signed-off-by: Isaac Bennetch <bennetch(a)gmail.com> Commit: 253894e2995ae4175f4429bf5cdaedfb6a722988 https://github.com/phpmyadmin/phpmyadmin/commit/253894e2995ae4175f4429bf5cd… Author: Isaac Bennetch <bennetch(a)gmail.com> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: M ChangeLog M README M doc/conf.py M import.php M index.php M js/config.js M js/microhistory.js M libraries/Config.php M libraries/DbQbe.php M libraries/Error.php M libraries/ErrorHandler.php M libraries/Message.php M libraries/SavedSearches.php M libraries/Tracker.php M libraries/VersionInformation.php M libraries/core.lib.php M libraries/export.lib.php M libraries/ip_allow_deny.lib.php M libraries/plugins/AuthenticationPlugin.php M libraries/plugins/auth/AuthenticationConfig.php M libraries/plugins/auth/AuthenticationCookie.php M libraries/plugins/auth/AuthenticationHttp.php M libraries/tbl_partition_definition.inc.php M libraries/tracking.lib.php M prefs_manage.php M test/classes/ErrorTest.php M test/classes/MessageTest.php M test/libraries/core/PMA_isAllowedDomain_test.php M test/libraries/core/PMA_safeUnserialize_test.php M test/libraries/core/PMA_sanitizeMySQLHost_test.php Log Message: ----------- Resolve merge conflicts with ChangeLog Signed-off-by: Isaac Bennetch <bennetch(a)gmail.com> Commit: b1136b88b16ec398ab4422bb3c3d55c17f6afc45 https://github.com/phpmyadmin/phpmyadmin/commit/b1136b88b16ec398ab4422bb3c3… Author: Isaac Bennetch <bennetch(a)gmail.com> Date: 2016-11-25 (Fri, 25 Nov 2016) Changed paths: M ChangeLog M README M doc/conf.py M libraries/Config.php Log Message: ----------- Prepare for 4.6.6-dev Signed-off-by: Isaac Bennetch <bennetch(a)gmail.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/637d55bb4459...b1136b88b16e

7 years, 9 months

[phpmyadmin/phpmyadmin] 4141d6: Strip null bytes from MySQL username

by Isaac Bennetch

Branch: refs/heads/MAINT_4_4_15 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 4141d694eb212b676ccc768e61b4d4085566f0ed https://github.com/phpmyadmin/phpmyadmin/commit/4141d694eb212b676ccc768e61b… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/core.lib.php M libraries/plugins/auth/AuthenticationCookie.class.php M libraries/plugins/auth/AuthenticationHttp.class.php Log Message: ----------- Strip null bytes from MySQL username In old PHP versions this could lead to allow/deny rules bypass. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 259694af9a3ce80bd17db04f46fb631693d929b8 https://github.com/phpmyadmin/phpmyadmin/commit/259694af9a3ce80bd17db04f46f… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/ip_allow_deny.lib.php Log Message: ----------- Use hash_equals for comparing username in allow/deny rules The comparison should happen in constant time to avoid possible leak of usernames in rules. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: f02555fe948c655877d318f82073cc83e333d99c https://github.com/phpmyadmin/phpmyadmin/commit/f02555fe948c655877d318f8207… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php M libraries/plugins/auth/AuthenticationHttp.class.php Log Message: ----------- Use hash_equals for checking username This makes the comparison happen in constant time and makes it impossible to use it to guess stored usernames. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 6735d83e10ae33a20153eb5516fb2f1963a594a7 https://github.com/phpmyadmin/phpmyadmin/commit/6735d83e10ae33a20153eb5516f… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/VersionInformation.php Log Message: ----------- Silent errors when getting remote file - both curl and fopen wrappers can emmit errors in cases where remote site is not accessible - do not pass false value to json_decode Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: ebcd746a2fc8b356e36c92fa6960d5f7256ebff0 https://github.com/phpmyadmin/phpmyadmin/commit/ebcd746a2fc8b356e36c92fa696… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/export.lib.php Log Message: ----------- Remove debugging code Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 5f40a46d24068484a5afe0bbb4ce4e5c8a6c6094 https://github.com/phpmyadmin/phpmyadmin/commit/5f40a46d24068484a5afe0bbb4c… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/Error.class.php M test/classes/PMA_Error_test.php Log Message: ----------- Strip path even if openbasedir restrictions apply This really should not be the case here as what we get here is code executed by PHP, so it should have already passed openbasedir restrictions. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 55c26d0065e83b9899ba90afb49dd72415c8d7f5 https://github.com/phpmyadmin/phpmyadmin/commit/55c26d0065e83b9899ba90afb49… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M js/ajax.js Log Message: ----------- Store copy of hash instead of working on live object This avoids possible race conditions when doing the checks. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 9b8094bb0d61da59f80a2f927011068c8e0f3069 https://github.com/phpmyadmin/phpmyadmin/commit/9b8094bb0d61da59f80a2f92701… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/navigation/NavigationHeader.class.php Log Message: ----------- Stricter validation of NavigationLogoLink It now has to be URL including scheme. Otherwise it's not really possible to validate it for being just http/https. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 94736885a66a5b28665d252d3062824fca99dd01 https://github.com/phpmyadmin/phpmyadmin/commit/94736885a66a5b28665d252d306… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M js/config.js Log Message: ----------- Fix hash validation - use copy of hash to avoid race condition - stricter regex to match whole string Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: fa3bcffd4e2e6d0d7f41f2ec0db2fe8d50a0635d https://github.com/phpmyadmin/phpmyadmin/commit/fa3bcffd4e2e6d0d7f41f2ec0db… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/DBQbe.class.php M libraries/SavedSearches.class.php Log Message: ----------- Limit maximal number of rows in QBE User would be lost in them anyway by that count and it prevents DOS. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 18fdcd066467259a4fb866961dde73f7902c5e8c https://github.com/phpmyadmin/phpmyadmin/commit/18fdcd066467259a4fb866961dd… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-24 (Wed, 24 Aug 2016) Changed paths: M ChangeLog M index.php Log Message: ----------- Do not show warning about short blowfish_secret if none is set With empty blowfish_secret user would always get both warnings... Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 38e4f77a8b0010a774d18cac4d41b104bff4bc53 https://github.com/phpmyadmin/phpmyadmin/commit/38e4f77a8b0010a774d18cac4d4… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M import.php Log Message: ----------- Fix possible DOS on too big skip value - loop only as long as long we have data to skip - convert skip parameter to integer Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 499a61c7d831f424c1e68f734b587e6baa395634 https://github.com/phpmyadmin/phpmyadmin/commit/499a61c7d831f424c1e68f734b5… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M index.php M libraries/core.lib.php Log Message: ----------- Stricter URL validation - do not use empty() as empty('0') is true - do not lowercase the strings, use them as they are - lowercase all domains in our codebase - do not allow to specify port Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 2cb51d22dba43f4a5d57d76ad8c734422db7c916 https://github.com/phpmyadmin/phpmyadmin/commit/2cb51d22dba43f4a5d57d76ad8c… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M libraries/ip_allow_deny.lib.php Log Message: ----------- Use hash_equals when comparing IPv6 allow rules Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 8ee12d39e568d46b358601be1217e5087f4acf75 https://github.com/phpmyadmin/phpmyadmin/commit/8ee12d39e568d46b358601be121… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M libraries/plugins/AuthenticationPlugin.class.php M libraries/plugins/auth/AuthenticationConfig.class.php M libraries/plugins/auth/AuthenticationCookie.class.php M libraries/plugins/auth/AuthenticationHttp.class.php Log Message: ----------- Verify value of access_time to avoid unwanted session extension We need to ansure the access_time parameter is in valid range to avoid possibility of remotely extending session validity. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: e3f2c744916ebdd355f365eb350eed078e2542d7 https://github.com/phpmyadmin/phpmyadmin/commit/e3f2c744916ebdd355f365eb350… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-02 (Sun, 02 Oct 2016) Changed paths: M prefs_manage.php Log Message: ----------- Don't assume the default arg_separator in URL Respect the value for arg_separator.input too. Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 1fc004d1730b3ca1b857d005de8a3d00d50cfdb4 https://github.com/phpmyadmin/phpmyadmin/commit/1fc004d1730b3ca1b857d005de8… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M libraries/core.lib.php M test/libraries/core/PMA_safeUnserialize_test.php Log Message: ----------- Correctly parse string length when checking serialized data Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 6d7113776ce6384838b00112f821366a1b92de48 https://github.com/phpmyadmin/phpmyadmin/commit/6d7113776ce6384838b00112f82… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M prefs_manage.php Log Message: ----------- Merge branch 'MAINT_4_4_15-security' of github.com:phpmyadmin/phpmyadmin-security into MAINT_4_4_15-security Commit: 9d0b1915d61e7289d234d26e6bdba021027fda87 https://github.com/phpmyadmin/phpmyadmin/commit/9d0b1915d61e7289d234d26e6bd… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M libraries/tracking.lib.php Log Message: ----------- Manage new-lines and extra whitespaces properly Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: d69375ff75bf58cbc35130081973a9ecfaec7d52 https://github.com/phpmyadmin/phpmyadmin/commit/d69375ff75bf58cbc3513008197… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M libraries/Tracker.class.php Log Message: ----------- Manage new-lines and extra whitespaces properly Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: a9e3827b190c386fc6cc0389668545ff0e2b4fdb https://github.com/phpmyadmin/phpmyadmin/commit/a9e3827b190c386fc6cc0389668… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-11-08 (Tue, 08 Nov 2016) Changed paths: M libraries/core.lib.php M test/libraries/core/PMA_sanitizeMySQLHost_test.php Log Message: ----------- Handle multiple `p:` while sanitizing MySQL hosts Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 0748384685693e3ecf97b021ccab075e295d4d65 https://github.com/phpmyadmin/phpmyadmin/commit/0748384685693e3ecf97b021cca… Author: Isaac Bennetch <bennetch(a)gmail.com> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: M ChangeLog M README M doc/conf.py M libraries/Config.class.php Log Message: ----------- 4.4.15.9 release and ChangeLog Signed-off-by: Isaac Bennetch <bennetch(a)gmail.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/39864227e7c3...074838468569

7 years, 9 months

[phpmyadmin/phpmyadmin] 285e56: Strip null bytes from MySQL username

by Isaac Bennetch

Branch: refs/heads/MAINT_4_0_10 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 285e5623b638cb414b3c3e5ab7c0f3126d616b54 https://github.com/phpmyadmin/phpmyadmin/commit/285e5623b638cb414b3c3e5ab7c… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/core.lib.php M libraries/plugins/auth/AuthenticationCookie.class.php M libraries/plugins/auth/AuthenticationHttp.class.php Log Message: ----------- Strip null bytes from MySQL username In old PHP versions this could lead to allow/deny rules bypass. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 58245cb1cc25a1b167941cf30a4cc742a27c0b5b https://github.com/phpmyadmin/phpmyadmin/commit/58245cb1cc25a1b167941cf30a4… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/ip_allow_deny.lib.php Log Message: ----------- Use hash_equals for comparing username in allow/deny rules The comparison should happen in constant time to avoid possible leak of usernames in rules. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 6117ad5cef7bbe3ff080efb557bbafaff757e0ea https://github.com/phpmyadmin/phpmyadmin/commit/6117ad5cef7bbe3ff080efb557b… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php M libraries/plugins/auth/AuthenticationHttp.class.php Log Message: ----------- Use hash_equals for checking username This makes the comparison happen in constant time and makes it impossible to use it to guess stored usernames. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: f2add98bd93fa96da130214e78eacb01893aa89a https://github.com/phpmyadmin/phpmyadmin/commit/f2add98bd93fa96da130214e78e… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/Error.class.php M test/classes/PMA_Error_test.php Log Message: ----------- Strip path even if openbasedir restrictions apply This really should not be the case here as what we get here is code executed by PHP, so it should have already passed openbasedir restrictions. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: c2f7a898ddf69422af218718d20c7eb6af62cb88 https://github.com/phpmyadmin/phpmyadmin/commit/c2f7a898ddf69422af218718d20… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M js/ajax.js Log Message: ----------- Store copy of hash instead of working on live object This avoids possible race conditions when doing the checks. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 096856c70c1b8b1b9a94a54ee780f7be623fd1c5 https://github.com/phpmyadmin/phpmyadmin/commit/096856c70c1b8b1b9a94a54ee78… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/navigation/NavigationHeader.class.php Log Message: ----------- Stricter validation of NavigationLogoLink It now has to be URL including scheme. Otherwise it's not really possible to validate it for being just http/https. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: b2605ebba6ca729fd0157a0774d173e3ec04eabb https://github.com/phpmyadmin/phpmyadmin/commit/b2605ebba6ca729fd0157a0774d… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M js/config.js Log Message: ----------- Fix hash validation - use copy of hash to avoid race condition - stricter regex to match whole string Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 67700620db6b494c9ecab9f4268d30cf4afb01b3 https://github.com/phpmyadmin/phpmyadmin/commit/67700620db6b494c9ecab9f4268… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-18 (Thu, 18 Aug 2016) Changed paths: M libraries/DBQbe.class.php Log Message: ----------- Limit maximal number of rows in QBE User would be lost in them anyway by that count and it prevents DOS. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: d37abc38daca9c1ebc074e3b4e9b2bdfc1cf523d https://github.com/phpmyadmin/phpmyadmin/commit/d37abc38daca9c1ebc074e3b4e9… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-08-24 (Wed, 24 Aug 2016) Changed paths: M ChangeLog M index.php Log Message: ----------- Do not show warning about short blowfish_secret if none is set With empty blowfish_secret user would always get both warnings... Fixes #12485 Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 0c3dfd186c281710516805f97a9875149abeb3ce https://github.com/phpmyadmin/phpmyadmin/commit/0c3dfd186c281710516805f97a9… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M import.php Log Message: ----------- Fix possible DOS on too big skip value - loop only as long as long we have data to skip - convert skip parameter to integer Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: af7c58939155d407233c8c3bf6f2ad3e540f489a https://github.com/phpmyadmin/phpmyadmin/commit/af7c58939155d407233c8c3bf6f… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M index.php M libraries/core.lib.php Log Message: ----------- Stricter URL validation - do not use empty() as empty('0') is true - do not lowercase the strings, use them as they are - lowercase all domains in our codebase - do not allow to specify port Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 63b7f6c0a94af5d7402c4f198846dc0c066f5413 https://github.com/phpmyadmin/phpmyadmin/commit/63b7f6c0a94af5d7402c4f19884… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M libraries/ip_allow_deny.lib.php Log Message: ----------- Use hash_equals when comparing IPv6 allow rules Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 773f126c89aca6588258753218e600c5764857c2 https://github.com/phpmyadmin/phpmyadmin/commit/773f126c89aca6588258753218e… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-02 (Sun, 02 Oct 2016) Changed paths: M prefs_manage.php Log Message: ----------- Don't assume the default arg_separator in URL Respect the value for arg_separator.input too. Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 5e108a340f3eac6b6c488439343b6c1a7454787c https://github.com/phpmyadmin/phpmyadmin/commit/5e108a340f3eac6b6c488439343… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M libraries/core.lib.php M test/libraries/core/PMA_safeUnserialize_test.php Log Message: ----------- Correctly parse string length when checking serialized data Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: be5196ba44e6f029de11abe32cea72161c698533 https://github.com/phpmyadmin/phpmyadmin/commit/be5196ba44e6f029de11abe32ce… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M prefs_manage.php Log Message: ----------- Merge branch 'MAINT_4_0_10-security' of github.com:phpmyadmin/phpmyadmin-security into MAINT_4_0_10-security Commit: 54875fffc12da0f1c0c2b6042e638b08fc337e2a https://github.com/phpmyadmin/phpmyadmin/commit/54875fffc12da0f1c0c2b6042e6… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M tbl_tracking.php Log Message: ----------- Manage new-lines and extra whitespaces properly Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 337b38044ddfe74d334831390c6cb40cd2f001f1 https://github.com/phpmyadmin/phpmyadmin/commit/337b38044ddfe74d334831390c6… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M libraries/Tracker.class.php Log Message: ----------- Manage new-lines and extra whitespaces properly Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 670359777263517b92908677fafc7e8dcd377ec5 https://github.com/phpmyadmin/phpmyadmin/commit/670359777263517b92908677faf… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-11-08 (Tue, 08 Nov 2016) Changed paths: M libraries/core.lib.php M test/libraries/core/PMA_sanitizeMySQLHost_test.php Log Message: ----------- Handle multiple `:p` while sanitizing MySQL hosts Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com> Commit: 8783113cec408ad9a81f17e3a97db6c4732e6164 https://github.com/phpmyadmin/phpmyadmin/commit/8783113cec408ad9a81f17e3a97… Author: Isaac Bennetch <bennetch(a)gmail.com> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: M ChangeLog M README M doc/conf.py M libraries/Config.class.php Log Message: ----------- 4.0.10.18 release and ChangeLog Signed-off-by: Isaac Bennetch <bennetch(a)gmail.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/5ba96c8804d9...8783113cec40

7 years, 9 months

[phpmyadmin/phpmyadmin] 96f61e: Translated using Weblate (Czech)

by Weblate

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 96f61e40485f37cb339e0a352faada6483cc041b https://github.com/phpmyadmin/phpmyadmin/commit/96f61e40485f37cb339e0a352fa… Author: ratajs <simonrataj(a)seznam.cz> Date: 2016-11-25 (Fri, 25 Nov 2016) Changed paths: M po/cs.po Log Message: ----------- Translated using Weblate (Czech) Currently translated at 92.6% (2996 of 3232 strings) [CI skip] Commit: 6b55f1b19c3e5d8bcbdb24c9f82a8b06cc45866b https://github.com/phpmyadmin/phpmyadmin/commit/6b55f1b19c3e5d8bcbdb24c9f82… Author: Carlos Ferreira <c.ferreira(a)acsiiweb.com> Date: 2016-11-25 (Fri, 25 Nov 2016) Changed paths: M po/fr.po Log Message: ----------- Translated using Weblate (French) Currently translated at 99.7% (3225 of 3232 strings) [CI skip] Commit: 80c0b4fd66f8320730bcb0fb6a00ee5a83382fe0 https://github.com/phpmyadmin/phpmyadmin/commit/80c0b4fd66f8320730bcb0fb6a0… Author: Weblate <noreply(a)weblate.org> Date: 2016-11-25 (Fri, 25 Nov 2016) Changed paths: M libraries/server_privileges.lib.php A templates/privileges/add_user_fieldset.phtml A templates/privileges/delete_user_fieldset.phtml Log Message: ----------- Merge remote-tracking branch 'origin/master' Compare: https://github.com/phpmyadmin/phpmyadmin/compare/2cd98b59187b...80c0b4fd66f8

7 years, 9 months

[phpmyadmin/phpmyadmin] 2cd98b: Refactor get html for add user and delete user to ...

by Deven Bansod

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2cd98b59187b24b65a53b057f7a68f43436f849f https://github.com/phpmyadmin/phpmyadmin/commit/2cd98b59187b24b65a53b057f7a… Author: Deven Bansod <devenbansod.bits(a)gmail.com> Date: 2016-11-25 (Fri, 25 Nov 2016) Changed paths: M libraries/server_privileges.lib.php A templates/privileges/add_user_fieldset.phtml A templates/privileges/delete_user_fieldset.phtml Log Message: ----------- Refactor get html for add user and delete user to use template Signed-off-by: Deven Bansod <devenbansod.bits(a)gmail.com>

7 years, 9 months

[phpmyadmin/phpmyadmin] 637d55: Translated using Weblate (French)

by Carlos Ferreira

Branch: refs/heads/QA_4_6 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 637d55bb4459ffceae9a5d0be36ab022ac583e10 https://github.com/phpmyadmin/phpmyadmin/commit/637d55bb4459ffceae9a5d0be36… Author: Carlos Ferreira <c.ferreira(a)acsiiweb.com> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: M po/fr.po Log Message: ----------- Translated using Weblate (French) Currently translated at 100.0% (3222 of 3222 strings) [CI skip]

7 years, 9 months

[phpmyadmin/phpmyadmin] 1a27a8: Translated using Weblate (French)

by Marc Delisle

Branch: refs/heads/QA_4_6 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 1a27a8eeff3501964a77d248ed02e4d90ad64f50 https://github.com/phpmyadmin/phpmyadmin/commit/1a27a8eeff3501964a77d248ed0… Author: Marc Delisle <marc(a)infomarc.info> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: M po/fr.po Log Message: ----------- Translated using Weblate (French) Currently translated at 99.6% (3210 of 3222 strings) [CI skip]

7 years, 9 months

[phpmyadmin/website] aa17bc: Add more prominent GitHub link

by Michal Čihař

Branch: refs/heads/master Home: https://github.com/phpmyadmin/website Commit: aa17bc446665535f694e4368c2f7cabb8dfdbf99 https://github.com/phpmyadmin/website/commit/aa17bc446665535f694e4368c2f7ca… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: M pmaweb/templates/base.html Log Message: ----------- Add more prominent GitHub link Fixes #40 Signed-off-by: Michal Čihař <michal(a)cihar.com>

7 years, 9 months

[phpmyadmin/planet] 91489d: Add more prominent GitHub link

by Michal Čihař

Branch: refs/heads/master Home: https://github.com/phpmyadmin/planet Commit: 91489db479dc7b5bf65e10fafad813d0a90dc8f8 https://github.com/phpmyadmin/planet/commit/91489db479dc7b5bf65e10fafad813d… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: M theme/index.html.tmpl Log Message: ----------- Add more prominent GitHub link See https://github.com/phpmyadmin/website/issues/40 Signed-off-by: Michal Čihař <michal(a)cihar.com>

7 years, 9 months

[phpmyadmin/scripts] 68ecee: Add favicon for develdocs

by Michal Čihař

Branch: refs/heads/master Home: https://github.com/phpmyadmin/scripts Commit: 68eceeb180c29ad043eb415d87e25d909a0bb066 https://github.com/phpmyadmin/scripts/commit/68eceeb180c29ad043eb415d87e25d… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-11-24 (Thu, 24 Nov 2016) Changed paths: A develdocs/output/favicon.ico Log Message: ----------- Add favicon for develdocs Fixes #43 Signed-off-by: Michal Čihař <michal(a)cihar.com>

7 years, 9 months

← Newer
1
...
6
7
8
9
10
11
12
...
27
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Git November 2016