May 2014 - Git - lists.phpmyadmin.net

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] b82e70: Share post connect code between DBIs
by Michal Čihař 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: b82e706dcbfc6dac284fcc504f4e5fb3d48ffdcb https://github.com/phpmyadmin/phpmyadmin/commit/b82e706dcbfc6dac284fcc504f4… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/DatabaseInterface.class.php M libraries/dbi/DBIDrizzle.class.php M libraries/dbi/DBIMysql.class.php M libraries/dbi/DBIMysqli.class.php Log Message: ----------- Share post connect code between DBIs Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 9e8505: Factor out socket/port parsing for connecting data...
by Michal Čihař 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 9e8505ff5eeadec568de6bc395016c7cef966eec https://github.com/phpmyadmin/phpmyadmin/commit/9e8505ff5eeadec568de6bc3950… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/DatabaseInterface.class.php M libraries/dbi/DBIDrizzle.class.php M libraries/dbi/DBIMysql.class.php M libraries/dbi/DBIMysqli.class.php Log Message: ----------- Factor out socket/port parsing for connecting database Almost same code was used in three DBIs, so let's share it. Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] a391dd: Use dot notation
by Marc Delisle 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a391dd93ab7c942d70895b5f38f3c9807f16bb8d https://github.com/phpmyadmin/phpmyadmin/commit/a391dd93ab7c942d70895b5f38f… Author: Marc Delisle <marc(a)infomarc.info> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M js/tbl_change.js Log Message: ----------- Use dot notation Signed-off-by: Marc Delisle <marc(a)infomarc.info> Commit: bd73eb3068c28f5b2a715d68edb9b8acfa85e2a0 https://github.com/phpmyadmin/phpmyadmin/commit/bd73eb3068c28f5b2a715d68edb… Author: Marc Delisle <marc(a)infomarc.info> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/DatabaseInterface.class.php M libraries/dbi/DBIDrizzle.class.php M libraries/dbi/DBIMysql.class.php M libraries/dbi/DBIMysqli.class.php Log Message: ----------- Merge branch 'master' of https://github.com/phpmyadmin/phpmyadmin Compare: https://github.com/phpmyadmin/phpmyadmin/compare/39339112f397...bd73eb3068c2

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 393391: Fix access to global variable
by Michal Čihař 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 39339112f397704c092c75c963df4d993dd561a8 https://github.com/phpmyadmin/phpmyadmin/commit/39339112f397704c092c75c963d… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/dbi/DBIMysqli.class.php Log Message: ----------- Fix access to global variable Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 69a9cb: Share logic for calling postConnect method
by Michal Čihař 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 69a9cb1e584f5dcaa8becc69722d2a1e7eb5e944 https://github.com/phpmyadmin/phpmyadmin/commit/69a9cb1e584f5dcaa8becc69722… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/DatabaseInterface.class.php M libraries/dbi/DBIDrizzle.class.php M libraries/dbi/DBIMysql.class.php M libraries/dbi/DBIMysqli.class.php Log Message: ----------- Share logic for calling postConnect method This should be called on success, when we're creating primary connection. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 44432097074d3cb019d776319782676541ea98c4 https://github.com/phpmyadmin/phpmyadmin/commit/44432097074d3cb019d77631978… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/DatabaseInterface.class.php Log Message: ----------- Do not call DBI->postConnect for control link It used to just return, so there is no sense in calling it at all. Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/963197cad111...44432097074d

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 963197: Function was used before it was defined
by Marc Delisle 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 963197cad1119ec0e2fc8b38200f381e6b4a0031 https://github.com/phpmyadmin/phpmyadmin/commit/963197cad1119ec0e2fc8b38200… Author: Marc Delisle <marc(a)infomarc.info> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M js/functions.js Log Message: ----------- Function was used before it was defined Signed-off-by: Marc Delisle <marc(a)infomarc.info>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 05533d: Use dot notation
by Marc Delisle 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 05533da471bc70b278813a3498c41cb40010e724 https://github.com/phpmyadmin/phpmyadmin/commit/05533da471bc70b278813a3498c… Author: Marc Delisle <marc(a)infomarc.info> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M js/functions.js Log Message: ----------- Use dot notation Signed-off-by: Marc Delisle <marc(a)infomarc.info> Commit: d3e552591300446f212772429e3b708773f4b721 https://github.com/phpmyadmin/phpmyadmin/commit/d3e552591300446f212772429e3… Author: Marc Delisle <marc(a)infomarc.info> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/DatabaseInterface.class.php M libraries/dbi/DBIDrizzle.class.php M libraries/dbi/DBIDummy.class.php M libraries/dbi/DBIExtension.int.php M libraries/dbi/DBIMysql.class.php M libraries/dbi/DBIMysqli.class.php Log Message: ----------- Merge branch 'master' of https://github.com/phpmyadmin/phpmyadmin Compare: https://github.com/phpmyadmin/phpmyadmin/compare/60ea7a18d7c1...d3e552591300

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] f6ffaa: This code has no effect
by Michal Čihař 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: f6ffaa1e27f22b41d3e2b545d2e1579470686765 https://github.com/phpmyadmin/phpmyadmin/commit/f6ffaa1e27f22b41d3e2b545d2e… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/dbi/DBIDrizzle.class.php Log Message: ----------- This code has no effect Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 60ea7a18d7c176035d5ab64f724047a2da603316 https://github.com/phpmyadmin/phpmyadmin/commit/60ea7a18d7c176035d5ab64f724… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/dbi/DBIDummy.class.php M libraries/dbi/DBIExtension.int.php Log Message: ----------- Remove insertId from the interface and dummy DBIs Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/510825c97e5b...60ea7a18d7c1

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 510825: Share implementation of insertId among DBIs
by Michal Čihař 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 510825c97e5baa7fb6468b382a224c21e704826b https://github.com/phpmyadmin/phpmyadmin/commit/510825c97e5baa7fb6468b382a2… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/DatabaseInterface.class.php M libraries/dbi/DBIDrizzle.class.php M libraries/dbi/DBIMysql.class.php M libraries/dbi/DBIMysqli.class.php Log Message: ----------- Share implementation of insertId among DBIs There is no need to have the method implemented three times. Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 69beff: Simplify code for getting field flags
by Michal Čihař 09 May '14

09 May '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 69beffffee402549d9c64916dac9912618bd9812 https://github.com/phpmyadmin/phpmyadmin/commit/69beffffee402549d9c64916dac… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-05-09 (Fri, 09 May 2014) Changed paths: M libraries/dbi/DBIMysqli.class.php Log Message: ----------- Simplify code for getting field flags Let's define array of flag names, so that we don't have to duplicate the code for each flag. Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0