June 2016 - Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] c00fe2: Fix listing routines for non privileged user
by Michal Čihař 17 Jun '16

17 Jun '16

Branch: refs/heads/QA_4_6 Home: https://github.com/phpmyadmin/phpmyadmin Commit: c00fe2cbfda2c3881cac764e23815dd198ad22d2 https://github.com/phpmyadmin/phpmyadmin/commit/c00fe2cbfda2c3881cac764e238… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-17 (Fri, 17 Jun 2016) Changed paths: M ChangeLog M libraries/rte/rte_list.lib.php Log Message: ----------- Fix listing routines for non privileged user We first need to check if we can read the definition before parsing it. Fixes #12310 Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] c00fe2: Fix listing routines for non privileged user
by Michal Čihař 17 Jun '16

17 Jun '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c00fe2cbfda2c3881cac764e23815dd198ad22d2 https://github.com/phpmyadmin/phpmyadmin/commit/c00fe2cbfda2c3881cac764e238… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-17 (Fri, 17 Jun 2016) Changed paths: M ChangeLog M libraries/rte/rte_list.lib.php Log Message: ----------- Fix listing routines for non privileged user We first need to check if we can read the definition before parsing it. Fixes #12310 Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: c3ae85b2e14e08b1ccb68ec33fce443297f67da9 https://github.com/phpmyadmin/phpmyadmin/commit/c3ae85b2e14e08b1ccb68ec33fc… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-17 (Fri, 17 Jun 2016) Changed paths: M ChangeLog M libraries/rte/rte_list.lib.php Log Message: ----------- Merge branch 'QA_4_6' Compare: https://github.com/phpmyadmin/phpmyadmin/compare/eb942e68b934...c3ae85b2e14e

1 0

[phpmyadmin/phpmyadmin] 80c7b8: Add missing escaping
by Michal Čihař 16 Jun '16

16 Jun '16

Branch: refs/heads/QA_4_6 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 80c7b8a56104ef9a8f862135dce3db07775b227d https://github.com/phpmyadmin/phpmyadmin/commit/80c7b8a56104ef9a8f862135dce… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/Index.php Log Message: ----------- Add missing escaping Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] 80c7b8: Add missing escaping
by Michal Čihař 16 Jun '16

16 Jun '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 80c7b8a56104ef9a8f862135dce3db07775b227d https://github.com/phpmyadmin/phpmyadmin/commit/80c7b8a56104ef9a8f862135dce… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/Index.php Log Message: ----------- Add missing escaping Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: eb942e68b934df501b39a04cd73ec9210828e273 https://github.com/phpmyadmin/phpmyadmin/commit/eb942e68b934df501b39a04cd73… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/Index.php Log Message: ----------- Merge branch 'QA_4_6' Compare: https://github.com/phpmyadmin/phpmyadmin/compare/bc339b55f01c...eb942e68b934

1 0

[phpmyadmin/phpmyadmin] bc339b: These are strings, handle them according to that
by Michal Čihař 16 Jun '16

16 Jun '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: bc339b55f01c77fe562b4fe5eb92ec8a878b8b16 https://github.com/phpmyadmin/phpmyadmin/commit/bc339b55f01c77fe562b4fe5eb9… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M tbl_replace.php Log Message: ----------- These are strings, handle them according to that Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] 2a4a07: Simplify Index::isPackaged
by Michal Čihař 16 Jun '16

16 Jun '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2a4a07365006dd6b4642270572c09391ba73f616 https://github.com/phpmyadmin/phpmyadmin/commit/2a4a07365006dd6b4642270572c… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/Index.php Log Message: ----------- Simplify Index::isPackaged We really do not use most of the functionality, so let it do only what we need. Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] d3aa8c: Call htmlspecialchars as we do not need to process...
by Michal Čihař 16 Jun '16

16 Jun '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: d3aa8c5fb66bd8c81610bcfd802b30a4fe4f5d19 https://github.com/phpmyadmin/phpmyadmin/commit/d3aa8c5fb66bd8c81610bcfd802… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/Message.php Log Message: ----------- Call htmlspecialchars as we do not need to process complex types here Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] efac71: The Html methods accept strings only
by Michal Čihař 16 Jun '16

16 Jun '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: efac710526c3aacb4730566c73ced03a8695b77c https://github.com/phpmyadmin/phpmyadmin/commit/efac710526c3aacb4730566c73c… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/Message.php Log Message: ----------- The Html methods accept strings only Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: a87c1644356dd33f2642893a863b009e2ebea361 https://github.com/phpmyadmin/phpmyadmin/commit/a87c1644356dd33f2642893a863… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M view_operations.php Log Message: ----------- Actually get warning messages to display Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: a7cd19355474c1a9ea7609c90fdc5d44173b49a1 https://github.com/phpmyadmin/phpmyadmin/commit/a7cd19355474c1a9ea7609c90fd… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/Message.php M libraries/insert_edit.lib.php M tbl_operations.php M tbl_replace.php M test/classes/MessageTest.php M view_operations.php Log Message: ----------- Make it clear whether addMessages expects string or Message object With this, it's way easier to anaylize code for potential problems with escaping. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 19f76066f2aa0385dd3438f186063ad99e7c8c4a https://github.com/phpmyadmin/phpmyadmin/commit/19f76066f2aa0385dd3438f1860… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/DisplayResults.php M libraries/Message.php M libraries/Util.php M libraries/central_columns.lib.php M libraries/display_export.lib.php M libraries/sql.lib.php M test/bootstrap-dist.php M test/classes/MessageTest.php Log Message: ----------- Separate adding string and Message objects to Message This way we can rely on type checking and avoid potential problems with escaping. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 54a76de3d83f9ee39e554c818e3584c3a3a8cf5e https://github.com/phpmyadmin/phpmyadmin/commit/54a76de3d83f9ee39e554c818e3… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M import.php M libraries/Message.php M libraries/rte/rte_events.lib.php M libraries/rte/rte_routines.lib.php M libraries/rte/rte_triggers.lib.php M test/classes/MessageTest.php Log Message: ----------- 'Replace addString calls with correct method based on content Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 9869a95641bfd630562749bfebf98fecaf8d60b8 https://github.com/phpmyadmin/phpmyadmin/commit/9869a95641bfd630562749bfebf… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M import.php M libraries/DisplayResults.php M libraries/Message.php M libraries/Util.php M libraries/central_columns.lib.php M libraries/display_export.lib.php M libraries/rte/rte_events.lib.php M libraries/rte/rte_routines.lib.php M libraries/rte/rte_triggers.lib.php M libraries/sql.lib.php M test/classes/MessageTest.php Log Message: ----------- Simplify Message adding methods The methods are now called based on added type: - addHtml adds HTML code as is - addText adds text after escaping it - addMessage adds Message instance Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/c6a6bbfb2f6f...9869a95641bf

1 0

[phpmyadmin/phpmyadmin] c6a6bb: Fix test expectations to match current code
by Michal Čihař 16 Jun '16

16 Jun '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c6a6bbfb2f6f64cc786f1dee0ed9de8b2eacf973 https://github.com/phpmyadmin/phpmyadmin/commit/c6a6bbfb2f6f64cc786f1dee0ed… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M test/libraries/PMA_user_preferences_test.php Log Message: ----------- Fix test expectations to match current code Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] bba718: Fix type comment
by Michal Čihař 16 Jun '16

16 Jun '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: bba718fa7a6eef13c030b498271d65417b240e36 https://github.com/phpmyadmin/phpmyadmin/commit/bba718fa7a6eef13c030b498271… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-06-16 (Thu, 16 Jun 2016) Changed paths: M libraries/DisplayResults.php Log Message: ----------- Fix type comment Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0