November 2017 - Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] e0ac6c: Better name for twofactor configuration endpoint
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: e0ac6c888d20c13b577d51bedc5fcc35cfeca32f https://github.com/phpmyadmin/phpmyadmin/commit/e0ac6c888d20c13b577d51bedc5… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/user_preferences.inc.php R prefs_second.php A prefs_twofactor.php R templates/prefs_second.twig R templates/prefs_second_configure.twig R templates/prefs_second_confirm.twig A templates/prefs_twofactor.twig A templates/prefs_twofactor_configure.twig A templates/prefs_twofactor_confirm.twig Log Message: ----------- Better name for twofactor configuration endpoint Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 223e4f72effffdbd303634e0fa912c97ac0a57bd https://github.com/phpmyadmin/phpmyadmin/commit/223e4f72effffdbd303634e0fa9… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/classes/TwoFactor.php M prefs_twofactor.php M templates/prefs_twofactor.twig Log Message: ----------- List missing deps on twofactor configuration page Fixes #13827 Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/c7e07822019c...223e4f72efff

1 0

[phpmyadmin/phpmyadmin] c7e078: Do not show verify button on invalid 2fa
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c7e07822019c93c7b04b2d0ca94524a0cfc3d7c6 https://github.com/phpmyadmin/phpmyadmin/commit/c7e07822019c93c7b04b2d0ca94… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/TwoFactor/Invalid.php M libraries/classes/Plugins/TwoFactorPlugin.php M templates/login/twofactor.twig Log Message: ----------- Do not show verify button on invalid 2fa Fixes #13832 Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] 9d99c6: Remove not needed condition
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 9d99c637e4734a2f8bd5df4566958c3a5c003301 https://github.com/phpmyadmin/phpmyadmin/commit/9d99c637e4734a2f8bd5df45669… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/classes/Scripts.php Log Message: ----------- Remove not needed condition It is always true. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: e572e43f03c0f1fc925ddd607a0ba8a7e18b4487 https://github.com/phpmyadmin/phpmyadmin/commit/e572e43f03c0f1fc925ddd607a0… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/classes/Scripts.php Log Message: ----------- Avoid using mbstring function on filename We do not have multibyte filenames... Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/3a00028ecbf4...e572e43f03c0

1 0

[phpmyadmin/phpmyadmin] 3a0002: Generate scripts as an array and concatenate once
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 3a00028ecbf484afa5635f110d5783a9b8a85af5 https://github.com/phpmyadmin/phpmyadmin/commit/3a00028ecbf484afa5635f110d5… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/classes/Scripts.php Log Message: ----------- Generate scripts as an array and concatenate once This avoids recalculating the result string several times. Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] a923d1: Fix gitnore file to ignore only files at current l...
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a923d1483d62e3175c85a04ff0235c80f6f88bcb https://github.com/phpmyadmin/phpmyadmin/commit/a923d1483d62e3175c85a04ff02… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M themes/.gitignore Log Message: ----------- Fix gitnore file to ignore only files at current level Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 502e1edd064a0cf23f8246a00a0a297ac3b0c459 https://github.com/phpmyadmin/phpmyadmin/commit/502e1edd064a0cf23f8246a00a0… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: A themes/pmahomme/css/icons.css.php Log Message: ----------- Add icons css This should have been part of fd9150460ee12fe3d0678bbad13360735f631a7e, but was ommited due to too aggressive .gitignore, which was fixed in a923d1483d62e3175c85a04ff0235c80f6f88bcb. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 0aed31b8549e6a78d3c04ab0add96ad5ffcb13d1 https://github.com/phpmyadmin/phpmyadmin/commit/0aed31b8549e6a78d3c04ab0add… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M js/ajax.js M js/db_search.js M js/error_report.js M js/functions.js M js/menu-resizer.js M js/pmd/history.js M js/server_status_monitor.js M js/server_status_processes.js Log Message: ----------- Remove extension from js images API Now when we use CSS classes, it's up to themes to define this. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: bed6fb4ebdc5f83ed30fe3e83e380baf24ed2fa5 https://github.com/phpmyadmin/phpmyadmin/commit/bed6fb4ebdc5f83ed30fe3e83e3… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M index.php M libraries/classes/CentralColumns.php M libraries/classes/Config/FormDisplayTemplate.php M libraries/classes/Console.php M libraries/classes/Controllers/Server/ServerDatabasesController.php M libraries/classes/Controllers/Table/TableSearchController.php M libraries/classes/Controllers/Table/TableStructureController.php M libraries/classes/Display/Export.php M libraries/classes/Display/Results.php M libraries/classes/Footer.php M libraries/classes/Header.php M libraries/classes/Index.php M libraries/classes/InsertEdit.php M libraries/classes/Menu.php M libraries/classes/Message.php M libraries/classes/Navigation/NavigationHeader.php M libraries/classes/Navigation/NavigationTree.php M libraries/classes/Navigation/Nodes/Node.php M libraries/classes/Navigation/Nodes/NodeColumn.php M libraries/classes/Navigation/Nodes/NodeColumnContainer.php M libraries/classes/Navigation/Nodes/NodeDatabase.php M libraries/classes/Navigation/Nodes/NodeDatabaseChild.php M libraries/classes/Navigation/Nodes/NodeDatabaseContainer.php M libraries/classes/Navigation/Nodes/NodeEvent.php M libraries/classes/Navigation/Nodes/NodeEventContainer.php M libraries/classes/Navigation/Nodes/NodeFunction.php M libraries/classes/Navigation/Nodes/NodeFunctionContainer.php M libraries/classes/Navigation/Nodes/NodeIndex.php M libraries/classes/Navigation/Nodes/NodeIndexContainer.php M libraries/classes/Navigation/Nodes/NodeProcedure.php M libraries/classes/Navigation/Nodes/NodeProcedureContainer.php M libraries/classes/Navigation/Nodes/NodeTable.php M libraries/classes/Navigation/Nodes/NodeTableContainer.php M libraries/classes/Navigation/Nodes/NodeTrigger.php M libraries/classes/Navigation/Nodes/NodeTriggerContainer.php M libraries/classes/Navigation/Nodes/NodeView.php M libraries/classes/Navigation/Nodes/NodeViewContainer.php M libraries/classes/Normalization.php M libraries/classes/Operations.php M libraries/classes/RecentFavoriteTable.php M libraries/classes/Rte/RteList.php M libraries/classes/Sanitize.php M libraries/classes/Server/Privileges.php M libraries/classes/Server/Status/Advisor.php M libraries/classes/Server/Status/Monitor.php M libraries/classes/Server/Status/Processes.php M libraries/classes/Server/UserGroups.php M libraries/classes/Sql.php M libraries/classes/Tracking.php M libraries/classes/Util.php M libraries/user_preferences.inc.php M tbl_change.php M templates/database/create_table.twig M templates/database/structure/print_view_data_dictionary_link.twig M templates/database/structure/structure_table_row.twig M templates/database/structure/tracking_icon.twig M templates/display/import/options.twig M templates/privileges/add_user_fieldset.twig M templates/privileges/delete_user_fieldset.twig M templates/server/databases/create.twig M templates/server/databases/databases_footer.twig M templates/server/databases/table_header.twig M templates/server/databases/table_row.twig M templates/server/engines/engine.twig M templates/server/sub_page_header.twig M templates/server/variables/link_template.twig M templates/server/variables/variable_row.twig M templates/table/relation/foreign_key_row.twig M templates/table/search/input_box.twig M templates/table/secondary_tabs.twig M templates/table/structure/actions_in_table_structure.twig M templates/table/structure/add_column.twig M templates/table/structure/check_all_table_column.twig M templates/table/structure/display_structure.twig M templates/table/structure/display_table_stats.twig M templates/table/structure/optional_action_links.twig M test/classes/Controllers/Server/ServerVariablesControllerTest.php M test/classes/Display/CreateTableTest.php M test/classes/Server/PrivilegesTest.php M test/classes/UtilTest.php Log Message: ----------- Avois passing extension to Util::getImage We do not use it anyway for quite some time and this way it's less processing to generate the img tag. Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/fd9150460ee1...bed6fb4ebdc5

1 0

[phpmyadmin/phpmyadmin] fecf2d: Remove unused info icon
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: fecf2de315554adabdc30e15eefa6cafa01ad6c0 https://github.com/phpmyadmin/phpmyadmin/commit/fecf2de315554adabdc30e15eef… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: R themes/original/img/b_info.png R themes/pmahomme/img/b_info.png Log Message: ----------- Remove unused info icon Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 37abef47151abbc569fae05d41d2a7005eb708ff https://github.com/phpmyadmin/phpmyadmin/commit/37abef47151abbc569fae05d41d… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M templates/server/databases/create.twig R themes/original/img/s_error2.png R themes/pmahomme/img/s_error2.png Log Message: ----------- Use just one error icon The other really does not fit the theme and there is no reason to have two. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 0d18161310b628d348161ed66256e363e5956b6f https://github.com/phpmyadmin/phpmyadmin/commit/0d18161310b628d348161ed6625… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M js/functions.js Log Message: ----------- Remove unused code Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: fd9150460ee12fe3d0678bbad13360735f631a7e https://github.com/phpmyadmin/phpmyadmin/commit/fd9150460ee12fe3d0678bbad13… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M js/functions.js M libraries/classes/Theme.php M libraries/classes/Util.php M test/classes/Config/FormDisplayTemplateTest.php M test/classes/FooterTest.php M test/classes/InsertEditTest.php M test/classes/MessageTest.php M test/classes/Plugins/Auth/AuthenticationConfigTest.php M test/classes/ThemeTest.php M test/classes/UtilTest.php M test/selenium/TestBase.php Log Message: ----------- Use fully CSS based icons - themes can easier customize their look - this better deals with previous JS code who relied on sprites (fixes #13815) Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/49a1b0e7436a...fd9150460ee1

1 0

[phpmyadmin/phpmyadmin] 49a1b0: Move session cleanup to post login
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 49a1b0e7436ac5d493862b1aa417f6df2986c1f3 https://github.com/phpmyadmin/phpmyadmin/commit/49a1b0e7436ac5d493862b1aa41… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/AuthenticationPlugin.php Log Message: ----------- Move session cleanup to post login It was really misplaced in 951e8ac753b4e395b3f21813d559f31fecf9614f it did cleanup session with every request. Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/localized_docs] 6b61dd: Translated using Weblate (Estonian)
by Kristjan Räts 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/localized_docs Commit: 6b61dd8d8529fe6c74527a6c95ec4bf72c186a72 https://github.com/phpmyadmin/localized_docs/commit/6b61dd8d8529fe6c74527a6… Author: Kristjan Räts <kristjanrats(a)gmail.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M po/et.mo M po/et.po Log Message: ----------- Translated using Weblate (Estonian) Currently translated at 25.1% (623 of 2473 strings) [CI skip]

1 0

[phpmyadmin/phpmyadmin] fd7a4d: Correctly unset session on logout
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: fd7a4db3b7192e5959349ac12b7b8b83f14f4dbf https://github.com/phpmyadmin/phpmyadmin/commit/fd7a4db3b7192e5959349ac12b7… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/plugins/AuthenticationPlugin.php Log Message: ----------- Correctly unset session on logout Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 80db5c457a14c8edfd0e7b0ef1b792b86579ef02 https://github.com/phpmyadmin/phpmyadmin/commit/80db5c457a14c8edfd0e7b0ef1b… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/classes/Plugins/AuthenticationPlugin.php Log Message: ----------- Merge branch 'QA_4_7' Compare: https://github.com/phpmyadmin/phpmyadmin/compare/951e8ac753b4...80db5c457a14

1 0

[phpmyadmin/phpmyadmin] fd7a4d: Correctly unset session on logout
by Michal Čihař 27 Nov '17

27 Nov '17

Branch: refs/heads/QA_4_7 Home: https://github.com/phpmyadmin/phpmyadmin Commit: fd7a4db3b7192e5959349ac12b7b8b83f14f4dbf https://github.com/phpmyadmin/phpmyadmin/commit/fd7a4db3b7192e5959349ac12b7… Author: Michal Čihař <michal(a)cihar.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libraries/plugins/AuthenticationPlugin.php Log Message: ----------- Correctly unset session on logout Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0