November 2021 - Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] d7ced9: Fix db selection when nav tree is disabled
by Maurício Meneghini Fauth 21 Nov '21

21 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: d7ced91ae2307760416a5f0ed85e4f707cb197a6 https://github.com/phpmyadmin/phpmyadmin/commit/d7ced91ae2307760416a5f0ed85… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-21 (Sun, 11 November 2021) -03:00 Changed paths: M ChangeLog M libraries/classes/Navigation/NavigationTree.php M templates/navigation/tree/database_select.twig Log Message: ----------- Fix db selection when nav tree is disabled $cfg['ShowDatabasesNavigationAsTree'] = false; Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 51a9540db46b384f9530acb5b114cc327ec44427 https://github.com/phpmyadmin/phpmyadmin/commit/51a9540db46b384f9530acb5b11… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-21 (Sun, 11 November 2021) -03:00 Changed paths: M ChangeLog M libraries/classes/Navigation/NavigationTree.php M templates/navigation/tree/database_select.twig Log Message: ----------- Merge pull request #17198 from mauriciofauth/nav-db-select-fix Fix db selection when nav tree is disabled Commit: 400146006610cb7dab2e80fcb2a6417973549f8c https://github.com/phpmyadmin/phpmyadmin/commit/400146006610cb7dab2e80fcb2a… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-21 (Sun, 11 November 2021) -03:00 Changed paths: M ChangeLog M libraries/classes/Navigation/NavigationTree.php M psalm-baseline.xml M templates/navigation/tree/database_select.twig Log Message: ----------- Merge branch 'QA_5_1' Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] d7ced9: Fix db selection when nav tree is disabled
by Maurício Meneghini Fauth 21 Nov '21

21 Nov '21

Branch: refs/heads/QA_5_1 Home: https://github.com/phpmyadmin/phpmyadmin Commit: d7ced91ae2307760416a5f0ed85e4f707cb197a6 https://github.com/phpmyadmin/phpmyadmin/commit/d7ced91ae2307760416a5f0ed85… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-21 (Sun, 11 November 2021) -03:00 Changed paths: M ChangeLog M libraries/classes/Navigation/NavigationTree.php M templates/navigation/tree/database_select.twig Log Message: ----------- Fix db selection when nav tree is disabled $cfg['ShowDatabasesNavigationAsTree'] = false; Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 51a9540db46b384f9530acb5b114cc327ec44427 https://github.com/phpmyadmin/phpmyadmin/commit/51a9540db46b384f9530acb5b11… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-21 (Sun, 11 November 2021) -03:00 Changed paths: M ChangeLog M libraries/classes/Navigation/NavigationTree.php M templates/navigation/tree/database_select.twig Log Message: ----------- Merge pull request #17198 from mauriciofauth/nav-db-select-fix Fix db selection when nav tree is disabled

1 0

[phpmyadmin/phpmyadmin] 06abe1: Update po files
by phpMyAdmin bot 21 Nov '21

21 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 06abe1688c189d230cae8ce267934cf46bd9eb22 https://github.com/phpmyadmin/phpmyadmin/commit/06abe1688c189d230cae8ce2679… Author: phpMyAdmin bot <bot(a)phpmyadmin.net> Date: 2021-11-21 (Sun, 11 November 2021) +00:00 Changed paths: M po/af.po M po/am.po M po/ar.po M po/ar_LY.po M po/az.po M po/be.po M po/be(a)latin.po M po/ber.po M po/bg.po M po/bn.po M po/br.po M po/brx.po M po/bs.po M po/ca.po M po/ckb.po M po/cs.po M po/cy.po M po/da.po M po/de.po M po/el.po M po/en_GB.po M po/eo.po M po/es.po M po/et.po M po/eu.po M po/fa.po M po/fi.po M po/fil.po M po/fr.po M po/fy.po M po/gl.po M po/gu.po M po/he.po M po/hi.po M po/hr.po M po/hu.po M po/hy.po M po/ia.po M po/id.po M po/ig.po M po/it.po M po/ja.po M po/ka.po M po/kab.po M po/kk.po M po/km.po M po/kn.po M po/ko.po M po/ksh.po M po/ku.po M po/ky.po M po/li.po M po/lt.po M po/lv.po M po/mk.po M po/ml.po M po/mn.po M po/ms.po M po/my.po M po/nb.po M po/ne.po M po/nl.po M po/nn.po M po/pa.po M po/phpmyadmin.pot M po/pl.po M po/pt.po M po/pt_BR.po M po/rcf.po M po/ro.po M po/ru.po M po/si.po M po/sk.po M po/sl.po M po/sq.po M po/sr.po M po/sr(a)latin.po M po/sv.po M po/ta.po M po/te.po M po/th.po M po/tk.po M po/tr.po M po/tt.po M po/tzm.po M po/ug.po M po/uk.po M po/ur.po M po/uz.po M po/uz(a)latin.po M po/vi.po M po/vls.po M po/zh_CN.po M po/zh_TW.po Log Message: ----------- Update po files [ci skip] Signed-off-by: phpMyAdmin bot <bot(a)phpmyadmin.net>

1 0

[phpmyadmin/sql-parser] f45b16: Fix some errors found by PHPStan
by Maurício Meneghini Fauth 20 Nov '21

20 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/sql-parser Commit: f45b16cc27185f440e0a168b83ba6919355a2741 https://github.com/phpmyadmin/sql-parser/commit/f45b16cc27185f440e0a168b83b… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M phpstan-baseline.neon M psalm-baseline.xml M src/Tools/TestGenerator.php M src/Utils/Tokens.php M tests/Components/CreateDefinitionTest.php M tests/Lexer/TokensListTest.php Log Message: ----------- Fix some errors found by PHPStan Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/sql-parser] d8c0b8: Bump PHPStan to v1.2
by Maurício Meneghini Fauth 19 Nov '21

19 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/sql-parser Commit: d8c0b83f4d68e892ee29a68d6dad171e9f5e6574 https://github.com/phpmyadmin/sql-parser/commit/d8c0b83f4d68e892ee29a68d6da… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M composer.json M phpstan-baseline.neon M phpstan.neon.dist Log Message: ----------- Bump PHPStan to v1.2 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] b65151: Convert connection collation select to Bootstrap
by Maurício Meneghini Fauth 19 Nov '21

19 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: b65151fa8c2a6128bf2019efeb053347c0db1367 https://github.com/phpmyadmin/phpmyadmin/commit/b65151fa8c2a6128bf2019efeb0… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M templates/home/index.twig Log Message: ----------- Convert connection collation select to Bootstrap Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 4f1de3: Remove phpMyAdmin repo from composer.json on Scrutinizer CI
by Maurício Meneghini Fauth 19 Nov '21

19 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 4f1de3e3380b583fe15ad9d4603f809dd8cb53be https://github.com/phpmyadmin/phpmyadmin/commit/4f1de3e3380b583fe15ad9d4603… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M .scrutinizer.yml Log Message: ----------- Remove phpMyAdmin repo from composer.json on Scrutinizer CI Scrutinizer CI builds are failing because its CA certificates are outdated. Bumps Node to v12 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 7afaaaf67253d9d4d6fbb2b6812e8f93542883de https://github.com/phpmyadmin/phpmyadmin/commit/7afaaaf67253d9d4d6fbb2b6812… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M .scrutinizer.yml Log Message: ----------- Merge pull request #17195 from mauriciofauth/scrutinizer-ci-fix Remove phpMyAdmin repo from `composer.json` on Scrutinizer CI Fixes #17167

1 0

[phpmyadmin/phpmyadmin] 51f401: Refactor destroy controller (#17194)
by Kamil Tekiela 19 Nov '21

19 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 51f4017b32ef686aeefd037cb9456705658d075a https://github.com/phpmyadmin/phpmyadmin/commit/51f4017b32ef686aeefd037cb94… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M js/src/server/databases.js M libraries/classes/Controllers/Server/Databases/DestroyController.php M psalm-baseline.xml M test/classes/Controllers/Server/Databases/DestroyControllerTest.php Log Message: ----------- Refactor destroy controller (#17194) * Remove redundant conditions They were always true. First, the variable is set to -1. If the variable is -1, then set it to Message. If the variable is Message then set the JSON array. All of this is redundant. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * $sqlQuery is not used anywhere Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Enforce $selected to be an array I can't remove it as it is a global. Previously, it was set to a POST variable. Since we validate that the variable is set and is not null, we can use the value from $params. If we validate that it's also an array we can replace for loop with foreach. There is no passing by reference, so this change should be safe. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Replace $rebuildDatabaseList with input validation The validation message says 'No databases selected.' so I assume that we should check that we actually got at least one entry in the list. If that is true, then the $rebuildDatabaseList is not needed and the condition redundant. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * drop_selected_dbs is always set and is redundant I am not sure if this is necessary. The AJAX request sends a value of "1" but the code doesn't really do anything with it other than checking if it is actually set. Is there some other path possible? Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Flatten the array with a single element Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove redundant isset The variable is set, so !isset === is_null. Why check for null if we can check just for !is_array. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Update psalm-baseline.xml Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Adhere to the coding standard Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] e91d25: Add button to view all themes
by Maurício Meneghini Fauth 19 Nov '21

19 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: e91d25803590c50cafb672f48864fa76e0526d12 https://github.com/phpmyadmin/phpmyadmin/commit/e91d25803590c50cafb672f4886… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M templates/home/index.twig Log Message: ----------- Add button to view all themes Related to 2cdce1d6fb0a4116e69bd5572d6ff912404c54ae Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] b86b70: Improve type definitions of Scripts class
by Maurício Meneghini Fauth 18 Nov '21

18 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: b86b70d63917691f9fe3849b4d000f82a6710c6b https://github.com/phpmyadmin/phpmyadmin/commit/b86b70d63917691f9fe3849b4d0… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-18 (Thu, 11 November 2021) -03:00 Changed paths: M libraries/classes/Console.php M libraries/classes/Scripts.php M psalm-baseline.xml Log Message: ----------- Improve type definitions of Scripts class Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0