Git

Download

git@phpmyadmin.net

November 2022

27 participants
151 discussions

[phpmyadmin/phpmyadmin] 128211: Remove Core::fatalError call from SchemaExportController
by Maurício Meneghini Fauth 31 Oct '22

31 Oct '22

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 128211ccc97d419a37f10bd873db12d45a93e653 https://github.com/phpmyadmin/phpmyadmin/commit/128211ccc97d419a37f10bd873d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: M libraries/classes/Controllers/SchemaExportController.php M libraries/services_controllers.php Log Message: ----------- Remove Core::fatalError call from SchemaExportController Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 62530b48a5c22e8cf5acf5302455fa9d1c64167e https://github.com/phpmyadmin/phpmyadmin/commit/62530b48a5c22e8cf5acf530245… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: M libraries/classes/Controllers/SchemaExportController.php M libraries/classes/Export.php Log Message: ----------- Replace Core::fatalError with an exception in Export::processExportSchema() Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 3121dae621f31a3e314ab6d6503606eb420d7f62 https://github.com/phpmyadmin/phpmyadmin/commit/3121dae621f31a3e314ab6d6503… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: M libraries/classes/Common.php Log Message: ----------- Replace Core::fatalError() calls from the Common class Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 103968f352a74435329dd671a9134762d5c04fd0 https://github.com/phpmyadmin/phpmyadmin/commit/103968f352a74435329dd671a91… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: M libraries/classes/Common.php M libraries/classes/Core.php M libraries/classes/DatabaseInterface.php M libraries/classes/Session.php M libraries/classes/Util.php M test/classes/CoreTest.php Log Message: ----------- Replace fatalError() with exception in Core::warnMissingExtension() Also moves some other calls to Core::warnMissingExtension() to the Common::checkRequiredPhpExtensions() method. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 66e2650e065e21029ef56e0bb47f2e6b0faf8d2e https://github.com/phpmyadmin/phpmyadmin/commit/66e2650e065e21029ef56e0bb47… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Controllers/Import/ImportController.php M libraries/classes/Controllers/Setup/FormController.php M libraries/classes/Controllers/Setup/MainController.php M libraries/classes/Controllers/Setup/ValidateController.php M libraries/classes/Controllers/Table/GetFieldController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Routing.php M test/classes/Controllers/AbstractControllerTest.php Log Message: ----------- Replace Core::fatalError() calls in controllers Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 640ecc5c08757db555ce9b1f5af46d8421e012ac https://github.com/phpmyadmin/phpmyadmin/commit/640ecc5c08757db555ce9b1f5af… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: M libraries/classes/Core.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/CoreTest.php Log Message: ----------- Remove $message_args param from Core::fatalError() Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: de03f00cae41b5dc9062526751fedfc97946d3d5 https://github.com/phpmyadmin/phpmyadmin/commit/de03f00cae41b5dc9062526751f… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Core.php M libraries/classes/Plugins.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Session.php M test/classes/CoreTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php Log Message: ----------- Remove Core::fatalError method Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: c88152cf5935f8dad8abaa63a4326276d0d085eb https://github.com/phpmyadmin/phpmyadmin/commit/c88152cf5935f8dad8abaa63a43… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: A libraries/classes/Exceptions/MissingExtensionException.php M libraries/classes/Common.php M libraries/classes/Controllers/SchemaExportController.php M libraries/classes/Core.php M libraries/classes/Export.php Log Message: ----------- Use more specific exceptions for some errors Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: bfe59e6e41eb07addde7fec1b5b19d2be7d3d6c4 https://github.com/phpmyadmin/phpmyadmin/commit/bfe59e6e41eb07addde7fec1b5b… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-10-31 (Mon, 10 October 2022) -03:00 Changed paths: A libraries/classes/Exceptions/MissingExtensionException.php M libraries/classes/Common.php M libraries/classes/Config.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Controllers/Import/ImportController.php M libraries/classes/Controllers/SchemaExportController.php M libraries/classes/Controllers/Setup/FormController.php M libraries/classes/Controllers/Setup/MainController.php M libraries/classes/Controllers/Setup/ValidateController.php M libraries/classes/Controllers/Table/GetFieldController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Core.php M libraries/classes/DatabaseInterface.php M libraries/classes/Export.php M libraries/classes/Plugins.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Routing.php M libraries/classes/Session.php M libraries/classes/Util.php M libraries/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/AbstractControllerTest.php M test/classes/CoreTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php Log Message: ----------- Merge pull request #17837 from MauricioFauth/core-fatal-error-removal Replace `PhpMyAdmin\Core::fatalError()` method calls

1 0

Jump to page: