- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 63e641: Refactor the DbTableExists class
by Maurício Meneghini Fauth 06 Aug '23

06 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 63e64107282cc826209124b500c2d3402b1fcd20 https://github.com/phpmyadmin/phpmyadmin/commit/63e64107282cc826209124b500c… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: A test/classes/DbTableExistsTest.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/Database/DesignerController.php M libraries/classes/Controllers/Database/EventsController.php M libraries/classes/Controllers/Database/ExportController.php M libraries/classes/Controllers/Database/ImportController.php M libraries/classes/Controllers/Database/Operations/CollationController.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Database/RoutinesController.php M libraries/classes/Controllers/Database/SearchController.php M libraries/classes/Controllers/Database/SqlController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/Structure/RealRowCountController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Database/TrackingController.php M libraries/classes/Controllers/Table/AddFieldController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ChartController.php M libraries/classes/Controllers/Table/DeleteConfirmController.php M libraries/classes/Controllers/Table/DropColumnConfirmationController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/GisVisualizationController.php M libraries/classes/Controllers/Table/ImportController.php M libraries/classes/Controllers/Table/IndexRenameController.php M libraries/classes/Controllers/Table/IndexesController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/SqlController.php M libraries/classes/Controllers/Table/Structure/PrimaryController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Table/TrackingController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Controllers/Triggers/IndexController.php M libraries/classes/Controllers/View/CreateController.php M libraries/classes/Controllers/View/OperationsController.php M libraries/classes/DbTableExists.php M libraries/services.php M libraries/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Database/EventsControllerTest.php M test/classes/Controllers/Database/RoutinesControllerTest.php M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php M test/classes/Controllers/Database/StructureControllerTest.php M test/classes/Controllers/Table/AddFieldControllerTest.php M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/Controllers/Table/ChartControllerTest.php M test/classes/Controllers/Table/DeleteConfirmControllerTest.php M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php M test/classes/Controllers/Table/FindReplaceControllerTest.php M test/classes/Controllers/Table/GisVisualizationControllerTest.php M test/classes/Controllers/Table/ImportControllerTest.php M test/classes/Controllers/Table/IndexRenameControllerTest.php M test/classes/Controllers/Table/IndexesControllerTest.php M test/classes/Controllers/Table/OperationsControllerTest.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Controllers/Table/SqlControllerTest.php M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/Controllers/Table/TrackingControllerTest.php M test/classes/Controllers/Table/ZoomSearchControllerTest.php M test/classes/Controllers/Triggers/IndexControllerTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php Log Message: ----------- Refactor the DbTableExists class - Changes static methods to instance methods - Extract response handling to the controllers - Add unit tests for the DbTableExists class - Remove the AbstractController::hasDatabase() method Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: e8ebb663ccceae210ba601d0efbe3ffcbf0f44e8 https://github.com/phpmyadmin/phpmyadmin/commit/e8ebb663ccceae210ba601d0efb… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: A test/classes/DbTableExistsTest.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/Database/DesignerController.php M libraries/classes/Controllers/Database/EventsController.php M libraries/classes/Controllers/Database/ExportController.php M libraries/classes/Controllers/Database/ImportController.php M libraries/classes/Controllers/Database/Operations/CollationController.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Database/RoutinesController.php M libraries/classes/Controllers/Database/SearchController.php M libraries/classes/Controllers/Database/SqlController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/Structure/RealRowCountController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Database/TrackingController.php M libraries/classes/Controllers/Table/AddFieldController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ChartController.php M libraries/classes/Controllers/Table/DeleteConfirmController.php M libraries/classes/Controllers/Table/DropColumnConfirmationController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/GisVisualizationController.php M libraries/classes/Controllers/Table/ImportController.php M libraries/classes/Controllers/Table/IndexRenameController.php M libraries/classes/Controllers/Table/IndexesController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/SqlController.php M libraries/classes/Controllers/Table/Structure/PrimaryController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Table/TrackingController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Controllers/Triggers/IndexController.php M libraries/classes/Controllers/View/CreateController.php M libraries/classes/Controllers/View/OperationsController.php M libraries/classes/DbTableExists.php M libraries/services.php M libraries/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Database/EventsControllerTest.php M test/classes/Controllers/Database/RoutinesControllerTest.php M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php M test/classes/Controllers/Database/StructureControllerTest.php M test/classes/Controllers/Table/AddFieldControllerTest.php M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/Controllers/Table/ChartControllerTest.php M test/classes/Controllers/Table/DeleteConfirmControllerTest.php M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php M test/classes/Controllers/Table/FindReplaceControllerTest.php M test/classes/Controllers/Table/GisVisualizationControllerTest.php M test/classes/Controllers/Table/ImportControllerTest.php M test/classes/Controllers/Table/IndexRenameControllerTest.php M test/classes/Controllers/Table/IndexesControllerTest.php M test/classes/Controllers/Table/OperationsControllerTest.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Controllers/Table/SqlControllerTest.php M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/Controllers/Table/TrackingControllerTest.php M test/classes/Controllers/Table/ZoomSearchControllerTest.php M test/classes/Controllers/Triggers/IndexControllerTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php Log Message: ----------- Merge pull request #18602 from MauricioFauth/db-table-exists-refactor Refactor the DbTableExists class

1 0

[phpmyadmin/phpmyadmin] bfc385: Create Http\Response::write() method to write to the body
by Maurício Meneghini Fauth 05 Aug '23

05 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: bfc3852e612120627edace7543167f96a3cdf8f5 https://github.com/phpmyadmin/phpmyadmin/commit/bfc3852e612120627edace75431… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-05 (Sat, 08 August 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/Controllers/JavaScriptMessagesController.php M libraries/classes/Controllers/Setup/MainController.php M libraries/classes/Http/Response.php M libraries/classes/Routing/Routing.php M test/classes/Http/ResponseTest.php Log Message: ----------- Create Http\Response::write() method to write to the body This method helps when data is written to the body of the response and the response object is returned immediately. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] d89bb2: Replace some 'echo' with ResponseRenderer::addHTML() method
by Maurício Meneghini Fauth 05 Aug '23

05 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: d89bb277d057062696d77e0032f8b087181db144 https://github.com/phpmyadmin/phpmyadmin/commit/d89bb277d057062696d77e0032f… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-04 (Fri, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/ChangeLogController.php M libraries/classes/Controllers/Database/CentralColumnsController.php M libraries/classes/Controllers/Database/TrackingController.php M libraries/classes/Controllers/Preferences/ManageController.php M libraries/classes/Controllers/Preferences/TwoFactorController.php M libraries/classes/Controllers/View/CreateController.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Tracking/Tracking.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Plugins/Auth/AuthenticationCookieTest.php Log Message: ----------- Replace some 'echo' with ResponseRenderer::addHTML() method Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] f3b57f: Change export to server file to use redirection after save
by Maurício Meneghini Fauth 05 Aug '23

05 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: f3b57f6278ff0c1749235938d1eb71fdc6eebba6 https://github.com/phpmyadmin/phpmyadmin/commit/f3b57f6278ff0c1749235938d1e… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-04 (Fri, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Export/Export.php M phpstan-baseline.neon M psalm-baseline.xml M templates/export.twig M test/classes/Export/ExportTest.php Log Message: ----------- Change export to server file to use redirection after save Removes the need of calling other controllers. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 234809d47cf39dc05f5344f7ee157686f7ac3871 https://github.com/phpmyadmin/phpmyadmin/commit/234809d47cf39dc05f5344f7ee1… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-04 (Fri, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Export/Export.php M phpstan-baseline.neon M psalm-baseline.xml M templates/export.twig M test/classes/Export/ExportTest.php Log Message: ----------- Merge pull request #18599 from MauricioFauth/export-show-page-redirect Change export to server file to use redirection after save

1 0

[phpmyadmin/phpmyadmin] eff687: Fix PHPUnit 10.3 soft deprecations
by Maurício Meneghini Fauth 04 Aug '23

04 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: eff6872c83edbe4f3074ce3a779fe39b8432414f https://github.com/phpmyadmin/phpmyadmin/commit/eff6872c83edbe4f3074ce3a779… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-04 (Fri, 08 August 2023) -03:00 Changed paths: M phpstan-baseline.neon M psalm-baseline.xml M test/classes/AbstractNetworkTestCase.php M test/classes/Config/FormDisplayTest.php M test/classes/ConfigStorage/RelationCleanupTest.php M test/classes/ConfigStorage/RelationTest.php M test/classes/ConfigStorage/UserGroupsTest.php M test/classes/Controllers/Database/MultiTableQuery/TablesControllerTest.php M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M test/classes/Controllers/Database/StructureControllerTest.php M test/classes/Controllers/Server/PluginsControllerTest.php M test/classes/Controllers/Server/Privileges/AccountLockControllerTest.php M test/classes/Controllers/Server/Privileges/AccountUnlockControllerTest.php M test/classes/Controllers/Server/VariablesControllerTest.php M test/classes/Controllers/Table/FindReplaceControllerTest.php M test/classes/Controllers/Table/IndexesControllerTest.php M test/classes/Controllers/Table/RelationControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Controllers/Triggers/IndexControllerTest.php M test/classes/Database/CentralColumnsTest.php M test/classes/Database/Designer/CommonTest.php M test/classes/Database/DesignerTest.php M test/classes/Database/EventsTest.php M test/classes/Database/RoutinesTest.php M test/classes/Database/SearchTest.php M test/classes/DatabaseInterfaceTest.php M test/classes/Dbal/MysqliResultTest.php M test/classes/Export/OptionsTest.php M test/classes/InsertEditTest.php M test/classes/Navigation/NavigationTest.php M test/classes/Navigation/Nodes/NodeDatabaseChildTest.php M test/classes/Navigation/Nodes/NodeTest.php M test/classes/NormalizationTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php M test/classes/Plugins/Export/ExportHtmlwordTest.php M test/classes/Plugins/Export/ExportLatexTest.php M test/classes/Plugins/Export/ExportMediawikiTest.php M test/classes/Plugins/Export/ExportOdsTest.php M test/classes/Plugins/Export/ExportOdtTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Export/ExportTexytextTest.php M test/classes/Plugins/Export/ExportXmlTest.php M test/classes/Plugins/Import/ImportLdiTest.php M test/classes/Server/Privileges/AccountLockingTest.php M test/classes/Server/PrivilegesTest.php M test/classes/Setup/FormProcessingTest.php M test/classes/SystemDatabaseTest.php M test/classes/Table/IndexesTest.php M test/classes/TableTest.php M test/classes/Theme/ThemeManagerTest.php M test/classes/Tracking/TrackerTest.php M test/classes/Tracking/TrackingTest.php M test/classes/TransformationsTest.php M test/classes/UserPreferencesTest.php M test/classes/UtilTest.php M test/classes/Utils/ForeignKeyTest.php M test/classes/Utils/GisTest.php M test/classes/VersionInformationTest.php Log Message: ----------- Fix PHPUnit 10.3 soft deprecations Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 6df6a5: Update Psalm baseline
by Maurício Meneghini Fauth 31 Jul '23

31 Jul '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 6df6a543e78c81dd601afad9062386f84dda88b2 https://github.com/phpmyadmin/phpmyadmin/commit/6df6a543e78c81dd601afad9062… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-31 (Mon, 07 July 2023) -03:00 Changed paths: M composer.json M psalm-baseline.xml Log Message: ----------- Update Psalm baseline Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 45b58d: Refactor JavaScriptMessagesController to return a Response object
by Maurício Meneghini Fauth 30 Jul '23

30 Jul '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 45b58d7eea6a002de8ac4e4630723ee11987814e https://github.com/phpmyadmin/phpmyadmin/commit/45b58d7eea6a002de8ac4e46307… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-30 (Sun, 07 July 2023) -03:00 Changed paths: M libraries/classes/Controllers/JavaScriptMessagesController.php M libraries/services_controllers.php M test/classes/Controllers/JavaScriptMessagesControllerTest.php Log Message: ----------- Refactor JavaScriptMessagesController to return a Response object Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] a55a4c: Extract dbi calls from body_for_table_summary template
by Maurício Meneghini Fauth 29 Jul '23

29 Jul '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a55a4cba2b6418576327bc76af3ec56839cb53d1 https://github.com/phpmyadmin/phpmyadmin/commit/a55a4cba2b6418576327bc76af3… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-28 (Fri, 07 July 2023) -03:00 Changed paths: M libraries/classes/Controllers/Database/StructureController.php M phpstan-baseline.neon M templates/database/structure/body_for_table_summary.twig Log Message: ----------- Extract dbi calls from body_for_table_summary template Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 44f7e9: Remove the public/show_config_errors.php file
by Maurício Meneghini Fauth 29 Jul '23

29 Jul '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 44f7e93b36bd93bd471603a3effac8dc0ce2b397 https://github.com/phpmyadmin/phpmyadmin/commit/44f7e93b36bd93bd471603a3eff… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-28 (Fri, 07 July 2023) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Sanitize.php M phpstan-baseline.neon M psalm.xml M scripts/check-release-excludes.sh D public/show_config_errors.php Log Message: ----------- Remove the public/show_config_errors.php file A better and safer way of showing the configuration errors should be developed. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: d9d47ba3ab5f3aca120decc1dd1a6a49ba4322df https://github.com/phpmyadmin/phpmyadmin/commit/d9d47ba3ab5f3aca120decc1dd1… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-28 (Fri, 07 July 2023) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Sanitize.php M phpstan-baseline.neon M psalm.xml M scripts/check-release-excludes.sh D public/show_config_errors.php Log Message: ----------- Merge pull request #18587 from MauricioFauth/show-config-errors-file-removal Remove the public/show_config_errors.php file

1 0

[phpmyadmin/phpmyadmin] ecf1c7: Wrap the Application::run() code with a HTTP handler
by Maurício Meneghini Fauth 27 Jul '23

27 Jul '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: ecf1c78ae8dd6f831fd2ac57ab6556eb8e36cca0 https://github.com/phpmyadmin/phpmyadmin/commit/ecf1c78ae8dd6f831fd2ac57ab6… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-26 (Wed, 07 July 2023) -03:00 Changed paths: M composer.json M libraries/classes/Application.php M libraries/services.php M test/classes/ApplicationTest.php Log Message: ----------- Wrap the Application::run() code with a HTTP handler - Uses laminas-httphandlerrunner to emit the Response object Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: fb39be0a779e4dda96030ba030ae1279fd3cc19c https://github.com/phpmyadmin/phpmyadmin/commit/fb39be0a779e4dda96030ba030a… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-26 (Wed, 07 July 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/Routing/Routing.php Log Message: ----------- Refactor the Routing::callControllerForRoute() method Changes the method to return a Response object when possible. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 6597dee72406c985fca6e51f118051ab40e62fbb https://github.com/phpmyadmin/phpmyadmin/commit/6597dee72406c985fca6e51f118… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-26 (Wed, 07 July 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/Routing/Routing.php Log Message: ----------- Refactor the Routing::callSetupController() method Changes the method so it return a Response object when possible. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 2c90f397e1a4dcef27f06733e0d1bbceecc7496f https://github.com/phpmyadmin/phpmyadmin/commit/2c90f397e1a4dcef27f06733e0d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-26 (Wed, 07 July 2023) -03:00 Changed paths: M libraries/classes/Controllers/Setup/MainController.php M libraries/classes/Header.php M libraries/classes/Routing/Routing.php Log Message: ----------- Refactor the Setup\MainController controller Changes the __invoke() method so it returns a Response object. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: c7b92d2de9dd1c54a8ad99f2585c227df836484d https://github.com/phpmyadmin/phpmyadmin/commit/c7b92d2de9dd1c54a8ad99f2585… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-07-27 (Thu, 07 July 2023) -03:00 Changed paths: M composer.json M libraries/classes/Application.php M libraries/classes/Controllers/Setup/MainController.php M libraries/classes/Header.php M libraries/classes/Routing/Routing.php M libraries/services.php M test/classes/ApplicationTest.php Log Message: ----------- Merge pull request #18576 from MauricioFauth/app-http-handler Wrap the Application::run() code with a HTTP handler

1 0