- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 4ec3b9: Improve boolean conditions with arrays (#18417)
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 4ec3b99ba37eebe3da3c041c375e1c1ffcd3bb54 https://github.com/phpmyadmin/phpmyadmin/commit/4ec3b99ba37eebe3da3c041c375… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Charsets.php M libraries/classes/Charsets/Collation.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Config/Settings.php M libraries/classes/Config/Settings/Server.php M libraries/classes/ConfigStorage/Relation.php M libraries/classes/Controllers/Database/ExportController.php M libraries/classes/Controllers/Database/ImportController.php M libraries/classes/Controllers/Database/Structure/DropFormController.php M libraries/classes/Controllers/Database/Structure/DropTableController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/ErrorReportController.php M libraries/classes/Controllers/Server/ExportController.php M libraries/classes/Controllers/Server/ImportController.php M libraries/classes/Controllers/Table/ExportController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/ImportController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/Structure/MoveColumnsController.php M libraries/classes/Controllers/Table/Structure/ReservedWordCheckController.php M libraries/classes/Controllers/Table/Structure/SaveController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Qbe.php M libraries/classes/Database/Routines.php M libraries/classes/DatabaseInterface.php M libraries/classes/ErrorReport.php M libraries/classes/Html/Generator.php M libraries/classes/Normalization.php M libraries/classes/Pdf.php M libraries/classes/Plugins/Export/ExportXml.php M libraries/classes/Plugins/Import/ImportCsv.php M libraries/classes/Plugins/Import/ImportMediawiki.php M libraries/classes/Plugins/Import/ImportShp.php M libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php M libraries/classes/RecentFavoriteTable.php M libraries/classes/Replication/ReplicationInfo.php M libraries/classes/Session.php M libraries/classes/Setup/ConfigGenerator.php M libraries/classes/Sql.php M libraries/classes/Table.php M libraries/classes/Table/Search.php M libraries/classes/Util.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/AbstractNetworkTestCase.php Log Message: ----------- Improve boolean conditions with arrays (#18417) * Remove empty() on array Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove boolean count() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> --------- Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] 2e3de2: Fix #18396
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2e3de28080ec58951208268480146e81c034fa7d https://github.com/phpmyadmin/phpmyadmin/commit/2e3de28080ec589512082684801… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-09 (Tue, 05 May 2023) +01:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php Log Message: ----------- Fix #18396 Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 64b0fd54c71dff7c8558277d9fdc058896696048 https://github.com/phpmyadmin/phpmyadmin/commit/64b0fd54c71dff7c8558277d9fd… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php Log Message: ----------- Merge pull request #18397 from kamil-tekiela/Fix-18396 Fix #18396 - Export page always exports data

1 0

[phpmyadmin/phpmyadmin] 94eee8: Remove unused param (#18398)
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 94eee89a60a2961b40514f7e872de6a0bd3c0d49 https://github.com/phpmyadmin/phpmyadmin/commit/94eee89a60a2961b40514f7e872… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Export.php M psalm-baseline.xml Log Message: ----------- Remove unused param (#18398) * Update phpstan-baseline.neon Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Removed unused param Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Narrow return type Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> --------- Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] 0d13a6: Table small fixes (#18405)
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 0d13a6bfad88edad788ecd4e00ed2a021242f69b https://github.com/phpmyadmin/phpmyadmin/commit/0d13a6bfad88edad788ecd4e00e… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Table.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Table small fixes (#18405) * Replace isset with null coalesce Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove @var annotation Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove unused argument Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Update baselines Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> --------- Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] 151939: Simplify Font::getCharLists()
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 15193944995199355f456b99f2fa3af40280cfc0 https://github.com/phpmyadmin/phpmyadmin/commit/15193944995199355f456b99f2f… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-11 (Thu, 05 May 2023) +01:00 Changed paths: M libraries/classes/Font.php Log Message: ----------- Simplify Font::getCharLists() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 5137d5711e4e09e9759b7135b62e870152ac4040 https://github.com/phpmyadmin/phpmyadmin/commit/5137d5711e4e09e9759b7135b62… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Font.php Log Message: ----------- Merge pull request #18408 from kamil-tekiela/Simplify-getCharLists Simplify Font::getCharLists()

1 0

[phpmyadmin/phpmyadmin] 4a4f8a: Remove useless foreach
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 4a4f8ae0633db6904ed49ea2293932eb88db6391 https://github.com/phpmyadmin/phpmyadmin/commit/4a4f8ae0633db6904ed49ea2293… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-11 (Thu, 05 May 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeRowsController.php M libraries/classes/Controllers/Table/ExportRowsController.php Log Message: ----------- Remove useless foreach Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 58c3e059c20a7eaf4255257a932cf309afcb8c9b https://github.com/phpmyadmin/phpmyadmin/commit/58c3e059c20a7eaf4255257a932… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Controllers/Table/ChangeRowsController.php M libraries/classes/Controllers/Table/ExportRowsController.php Log Message: ----------- Merge pull request #18407 from kamil-tekiela/Useless-foreach Remove useless foreach

1 0

[phpmyadmin/phpmyadmin] d5cce5: Fix property initializations
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: d5cce547e73bddfd7eeae7019409e4d2f0150bc2 https://github.com/phpmyadmin/phpmyadmin/commit/d5cce547e73bddfd7eeae701940… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-11 (Thu, 05 May 2023) +01:00 Changed paths: M libraries/classes/Config/Forms/BaseFormList.php M libraries/classes/Footer.php M libraries/classes/Header.php M libraries/classes/Plugins/Schema/Eps/Eps.php M libraries/classes/ResponseRenderer.php M libraries/classes/Theme/ThemeManager.php M test/classes/Stubs/ResponseRenderer.php Log Message: ----------- Fix property initializations Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 03cd6b508db8f1ebce7fdffebfc9882232e0b321 https://github.com/phpmyadmin/phpmyadmin/commit/03cd6b508db8f1ebce7fdffebfc… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Config/Forms/BaseFormList.php M libraries/classes/Footer.php M libraries/classes/Header.php M libraries/classes/Plugins/Schema/Eps/Eps.php M libraries/classes/ResponseRenderer.php M libraries/classes/Theme/ThemeManager.php M test/classes/Stubs/ResponseRenderer.php Log Message: ----------- Merge pull request #18409 from kamil-tekiela/Property-initialization Fix property initializations

1 0

[phpmyadmin/phpmyadmin] 111640: Add never type
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 111640ef36a24e24104e5623d2a459e748ae0503 https://github.com/phpmyadmin/phpmyadmin/commit/111640ef36a24e24104e5623d2a… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-11 (Thu, 05 May 2023) +01:00 Changed paths: M libraries/classes/Pdf.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/ResponseRenderer.php M libraries/classes/Sql.php M libraries/classes/UrlRedirector.php Log Message: ----------- Add never type Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 77dc78e32bf567095bed86216052de521fb3af4c https://github.com/phpmyadmin/phpmyadmin/commit/77dc78e32bf567095bed8621605… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Pdf.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/ResponseRenderer.php M libraries/classes/Sql.php M libraries/classes/UrlRedirector.php Log Message: ----------- Merge pull request #18410 from kamil-tekiela/never-type Add never type

1 0

[phpmyadmin/phpmyadmin] 3ac8b6: Use short lambdas
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 3ac8b6d87bcf3fe6283bcd68db048d1bc38be913 https://github.com/phpmyadmin/phpmyadmin/commit/3ac8b6d87bcf3fe6283bcd68db0… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-11 (Thu, 05 May 2023) +01:00 Changed paths: M test/classes/Database/SearchTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Import/ImportLdiTest.php M test/classes/Server/PrivilegesTest.php M test/classes/SystemDatabaseTest.php M test/classes/TableTest.php M test/classes/Tracking/TrackerTest.php M test/classes/UserPreferencesTest.php Log Message: ----------- Use short lambdas Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 1d2ee56f95f2b8c5cd46e637e583ab1766fc15f3 https://github.com/phpmyadmin/phpmyadmin/commit/1d2ee56f95f2b8c5cd46e637e58… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M test/classes/Database/SearchTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Import/ImportLdiTest.php M test/classes/Server/PrivilegesTest.php M test/classes/SystemDatabaseTest.php M test/classes/TableTest.php M test/classes/Tracking/TrackerTest.php M test/classes/UserPreferencesTest.php Log Message: ----------- Merge pull request #18411 from kamil-tekiela/short-lambdas Use short lambdas

1 0

[phpmyadmin/phpmyadmin] 176645: Shorten else/if to elseif
by Kamil Tekiela 12 May '23

12 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 176645be7bce3e792ce24863253dc61163a7783c https://github.com/phpmyadmin/phpmyadmin/commit/176645be7bce3e792ce24863253… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-12 (Fri, 05 May 2023) +01:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Database/Events.php M libraries/classes/Database/Qbe.php M libraries/classes/ErrorHandler.php M libraries/classes/Export.php M libraries/classes/IpAllowDeny.php M libraries/classes/ListDatabase.php M libraries/classes/Navigation/NavigationTree.php M libraries/classes/Operations.php M libraries/classes/Plugins/Export/ExportCsv.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Import/ImportMediawiki.php M libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php M libraries/classes/Server/Privileges.php M libraries/classes/Setup/Index.php M libraries/classes/Table.php M libraries/classes/Util.php M psalm-baseline.xml Log Message: ----------- Shorten else/if to elseif Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 20d206a705ab3808df98f7865accbea5ed972945 https://github.com/phpmyadmin/phpmyadmin/commit/20d206a705ab3808df98f7865ac… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-12 (Fri, 05 May 2023) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Database/Events.php M libraries/classes/Database/Qbe.php M libraries/classes/ErrorHandler.php M libraries/classes/Export.php M libraries/classes/IpAllowDeny.php M libraries/classes/ListDatabase.php M libraries/classes/Navigation/NavigationTree.php M libraries/classes/Operations.php M libraries/classes/Plugins/Export/ExportCsv.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Import/ImportMediawiki.php M libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php M libraries/classes/Server/Privileges.php M libraries/classes/Setup/Index.php M libraries/classes/Table.php M libraries/classes/Util.php M psalm-baseline.xml Log Message: ----------- Merge pull request #18412 from kamil-tekiela/ShortenElseIfRector Shorten else/if to elseif

1 0