- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 93fa48: Refactor the ServerRequest::getRoute() method
by Maurício Meneghini Fauth 12 Aug '23

12 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 93fa48e286def43b336a207ca7e87472e1300e41 https://github.com/phpmyadmin/phpmyadmin/commit/93fa48e286def43b336a207ca7e… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-12 (Sat, 08 August 2023) -03:00 Changed paths: A test/classes/Controllers/HomeControllerTest.php M libraries/classes/Application.php M libraries/classes/Controllers/HomeController.php M libraries/classes/DatabaseInterface.php M libraries/classes/Footer.php M libraries/classes/Http/ServerRequest.php M libraries/classes/Menu.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Routing/Routing.php M libraries/services_controllers.php M psalm-baseline.xml M test/classes/ApplicationTest.php M test/classes/Http/ServerRequestTest.php Log Message: ----------- Refactor the ServerRequest::getRoute() method Extracts the redirection to database and table pages to the HomeController for an actual redirection instead of an implicit one. Removes the Application::getRequest() method as the ServerRequest object should be an immutable object. Adds a Routing::$route static variable to be used at the places that the ServerRequest object is not available. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 7e9ce8df8ce2f1c5970f134e25433a56aef2567b https://github.com/phpmyadmin/phpmyadmin/commit/7e9ce8df8ce2f1c5970f134e254… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-12 (Sat, 08 August 2023) -03:00 Changed paths: A test/classes/Controllers/HomeControllerTest.php M libraries/classes/Application.php M libraries/classes/Controllers/HomeController.php M libraries/classes/DatabaseInterface.php M libraries/classes/Footer.php M libraries/classes/Http/ServerRequest.php M libraries/classes/Menu.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Routing/Routing.php M libraries/services_controllers.php M psalm-baseline.xml M test/classes/ApplicationTest.php M test/classes/Http/ServerRequestTest.php Log Message: ----------- Merge pull request #18616 from MauricioFauth/server-request-route Refactor the `ServerRequest::getRoute()` method

1 0

[phpmyadmin/phpmyadmin] a2b8c1: Pass a ServerRequest object to the 2FA plugin
by Maurício Meneghini Fauth 11 Aug '23

11 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a2b8c17c30adf510c0836b3993da5529da2c300a https://github.com/phpmyadmin/phpmyadmin/commit/a2b8c17c30adf510c0836b3993d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-11 (Fri, 08 August 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/Controllers/Preferences/TwoFactorController.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/TwoFactor/Application.php M libraries/classes/Plugins/TwoFactor/Invalid.php M libraries/classes/Plugins/TwoFactor/Key.php M libraries/classes/Plugins/TwoFactor/Simple.php M libraries/classes/Plugins/TwoFactor/WebAuthn.php M libraries/classes/Plugins/TwoFactorPlugin.php M libraries/classes/TwoFactor.php M phpstan-baseline.neon M test/classes/Plugins/TwoFactor/WebAuthnTest.php M test/classes/TwoFactorTest.php Log Message: ----------- Pass a ServerRequest object to the 2FA plugin Removes the Application::getRequest() call for the WebAuthn plugin. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: e9be991d500a0f3c9a89e1c70f69e8b918493daf https://github.com/phpmyadmin/phpmyadmin/commit/e9be991d500a0f3c9a89e1c70f6… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-11 (Fri, 08 August 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/Controllers/Preferences/TwoFactorController.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/TwoFactor/Application.php M libraries/classes/Plugins/TwoFactor/Invalid.php M libraries/classes/Plugins/TwoFactor/Key.php M libraries/classes/Plugins/TwoFactor/Simple.php M libraries/classes/Plugins/TwoFactor/WebAuthn.php M libraries/classes/Plugins/TwoFactorPlugin.php M libraries/classes/TwoFactor.php M phpstan-baseline.neon M test/classes/Plugins/TwoFactor/WebAuthnTest.php M test/classes/TwoFactorTest.php Log Message: ----------- Merge pull request #18615 from MauricioFauth/2fa-request Pass a ServerRequest object to the 2FA plugin

1 0

[phpmyadmin/phpmyadmin] 2ba2e8: Refactor ErrorHandler::dispFatalError() to use a Response object
by Maurício Meneghini Fauth 09 Aug '23

09 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2ba2e80d399c60c203073edef045cfc1d7b3f9a5 https://github.com/phpmyadmin/phpmyadmin/commit/2ba2e80d399c60c203073edef04… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-09 (Wed, 08 August 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/ErrorHandler.php M libraries/classes/ResponseRenderer.php M phpstan-baseline.neon M test/classes/ErrorHandlerTest.php M test/classes/Stubs/ResponseRenderer.php Log Message: ----------- Refactor ErrorHandler::dispFatalError() to use a Response object Removes the dependency on ResponseRenderer for this method. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] bf9405: Add a Template property to the ResponseRenderer class
by Maurício Meneghini Fauth 09 Aug '23

09 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: bf9405860201d2b047b33308cfc73cc74624495b https://github.com/phpmyadmin/phpmyadmin/commit/bf9405860201d2b047b33308cfc… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-09 (Wed, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/Setup/MainController.php M libraries/classes/Footer.php M libraries/classes/Header.php M libraries/classes/Menu.php M libraries/classes/ResponseRenderer.php M libraries/classes/Scripts.php M phpstan-baseline.neon M test/classes/FooterTest.php M test/classes/HeaderTest.php M test/classes/MenuTest.php M test/classes/ScriptsTest.php M test/classes/Stubs/ResponseRenderer.php Log Message: ----------- Add a Template property to the ResponseRenderer class Passes the Template object to its dependencies. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 5f9ba2: Extract Relation and Template dependencies from UserPreferences
by Maurício Meneghini Fauth 09 Aug '23

09 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 5f9ba2e1d1f9027d0dd146882f39f7b9555b8bdc https://github.com/phpmyadmin/phpmyadmin/commit/5f9ba2e1d1f9027d0dd146882f3… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-09 (Wed, 08 August 2023) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Controllers/ErrorReportController.php M libraries/classes/Header.php M libraries/classes/Navigation/Navigation.php M libraries/classes/TwoFactor.php M libraries/classes/UserPreferences.php M libraries/services.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Config/PageSettingsTest.php M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/Controllers/Table/ExportControllerTest.php M test/classes/Controllers/Table/ImportControllerTest.php M test/classes/Controllers/Table/SqlControllerTest.php M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/UserPreferencesTest.php Log Message: ----------- Extract Relation and Template dependencies from UserPreferences Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 41c1d2: Fix some failing tests
by Maurício Meneghini Fauth 09 Aug '23

09 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 41c1d2bed8c2d4acda7246648b033423b9e19e53 https://github.com/phpmyadmin/phpmyadmin/commit/41c1d2bed8c2d4acda7246648b0… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: M test/classes/Config/PageSettingsTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php Log Message: ----------- Fix some failing tests Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 1f636f: Create the Http\Handler\ApplicationHandler class
by Maurício Meneghini Fauth 09 Aug '23

09 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 1f636fedbe53e9a63225b2b9b043fd57043697af https://github.com/phpmyadmin/phpmyadmin/commit/1f636fedbe53e9a63225b2b9b04… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: A libraries/classes/Http/Handler/ApplicationHandler.php A test/classes/Http/Handler/ApplicationHandlerTest.php M composer.json M libraries/classes/Application.php M libraries/classes/ResponseRenderer.php Log Message: ----------- Create the Http\Handler\ApplicationHandler class Uses the Laminas\HttpHandlerRunner\RequestHandlerRunner class to handle the server request and the response emission. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: daad3ab13a0c708b8036cf4ad765fe8b496e4937 https://github.com/phpmyadmin/phpmyadmin/commit/daad3ab13a0c708b8036cf4ad76… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: A libraries/classes/Http/Handler/QueueRequestHandler.php A libraries/classes/Middleware/PhpExtensionsChecking.php A test/classes/Http/Handler/QueueRequestHandlerTest.php M composer.json M libraries/classes/Application.php Log Message: ----------- Add support for PSR-15 middleware Creates the Http/Handler/QueueRequestHandler class to handle the middleware queue. Extracts the PHP extensions checking into a middleware. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 5dc23aec19b40ba1de9a82f62e60ab4fd198f896 https://github.com/phpmyadmin/phpmyadmin/commit/5dc23aec19b40ba1de9a82f62e6… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: A libraries/classes/Middleware/ErrorHandling.php M libraries/classes/Application.php M libraries/classes/ErrorHandler.php Log Message: ----------- Create the ErrorHandling middleware Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 54a080c15df3422c7f6f107e60b08ac3d2179384 https://github.com/phpmyadmin/phpmyadmin/commit/54a080c15df3422c7f6f107e60b… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: A libraries/classes/Middleware/OutputBuffering.php M libraries/classes/Application.php M libraries/classes/ResponseRenderer.php M phpstan-baseline.neon D libraries/classes/OutputBuffering.php Log Message: ----------- Create the OutputBuffering middleware Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 58bd13f318fea7969b5975a05a50738afbd62e6c https://github.com/phpmyadmin/phpmyadmin/commit/58bd13f318fea7969b5975a05a5… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: A libraries/classes/Http/Handler/ApplicationHandler.php A libraries/classes/Http/Handler/QueueRequestHandler.php A libraries/classes/Middleware/ErrorHandling.php A libraries/classes/Middleware/OutputBuffering.php A libraries/classes/Middleware/PhpExtensionsChecking.php A test/classes/Http/Handler/ApplicationHandlerTest.php A test/classes/Http/Handler/QueueRequestHandlerTest.php M composer.json M libraries/classes/Application.php M libraries/classes/ErrorHandler.php M libraries/classes/ResponseRenderer.php M phpstan-baseline.neon D libraries/classes/OutputBuffering.php Log Message: ----------- Merge pull request #18589 from MauricioFauth/psr15-middleware Add support for PSR-15 middleware

1 0

[phpmyadmin/phpmyadmin] 7aa9c4: Fix some failing tests
by Maurício Meneghini Fauth 08 Aug '23

08 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 7aa9c4a3abf6dc0e80ccd3c562a78c5d1eb7b73a https://github.com/phpmyadmin/phpmyadmin/commit/7aa9c4a3abf6dc0e80ccd3c562a… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: M test/classes/Plugins/Auth/AuthenticationConfigTest.php M test/classes/Plugins/TwoFactor/WebAuthnTest.php Log Message: ----------- Fix some failing tests Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] c0d04b: Add a Response object to ResponseRenderer class
by Maurício Meneghini Fauth 08 Aug '23

08 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c0d04b68956b47ce84131b9a68723f58275d789a https://github.com/phpmyadmin/phpmyadmin/commit/c0d04b68956b47ce84131b9a687… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-07 (Mon, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/ChangeLogController.php M libraries/classes/Controllers/LicenseController.php M libraries/classes/Controllers/Server/Privileges/AccountLockController.php M libraries/classes/Controllers/Server/Privileges/AccountUnlockController.php M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Server/UserGroupsFormController.php M libraries/classes/Controllers/Server/Variables/GetVariableController.php M libraries/classes/Controllers/Setup/ShowConfigController.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/ResponseRenderer.php M libraries/classes/Setup/FormProcessing.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/AbstractControllerTest.php M test/classes/Controllers/Server/Privileges/AccountLockControllerTest.php M test/classes/Controllers/Server/Privileges/AccountUnlockControllerTest.php M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php M test/classes/CoreTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php M test/classes/Setup/FormProcessingTest.php M test/classes/Stubs/ResponseRenderer.php M test/classes/UserPreferencesTest.php D test/classes/AbstractNetworkTestCase.php Log Message: ----------- Add a Response object to ResponseRenderer class Uses a Response object to handle the HTTP headers and HTTP status code. This makes the AbstractNetworkTestCase obsolete and removes it. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 5d9932d2cb828ffa9dc0b401d342b48f5ee7d8d0 https://github.com/phpmyadmin/phpmyadmin/commit/5d9932d2cb828ffa9dc0b401d34… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-08 (Tue, 08 August 2023) -03:00 Changed paths: M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/ChangeLogController.php M libraries/classes/Controllers/LicenseController.php M libraries/classes/Controllers/Server/Privileges/AccountLockController.php M libraries/classes/Controllers/Server/Privileges/AccountUnlockController.php M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Server/UserGroupsFormController.php M libraries/classes/Controllers/Server/Variables/GetVariableController.php M libraries/classes/Controllers/Setup/ShowConfigController.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/ResponseRenderer.php M libraries/classes/Setup/FormProcessing.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/AbstractControllerTest.php M test/classes/Controllers/Server/Privileges/AccountLockControllerTest.php M test/classes/Controllers/Server/Privileges/AccountUnlockControllerTest.php M test/classes/Controllers/Table/DropColumnConfirmationControllerTest.php M test/classes/CoreTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php M test/classes/Setup/FormProcessingTest.php M test/classes/Stubs/ResponseRenderer.php M test/classes/UserPreferencesTest.php D test/classes/AbstractNetworkTestCase.php Log Message: ----------- Merge pull request #18609 from MauricioFauth/response-renderer-response Add a Response object to ResponseRenderer class

1 0

[phpmyadmin/phpmyadmin] a520e2: Move Core::sendHeaderLocation() to ResponseRenderer::redirect()
by Maurício Meneghini Fauth 06 Aug '23

06 Aug '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a520e235eb78bb2d3d68b3f0d2c7d83f0016d0b6 https://github.com/phpmyadmin/phpmyadmin/commit/a520e235eb78bb2d3d68b3f0d2c… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Config/PageSettings.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/CollationConnectionController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Controllers/LogoutController.php M libraries/classes/Controllers/Sql/SqlController.php M libraries/classes/Controllers/ThemeSetController.php M libraries/classes/Core.php M libraries/classes/Export/Export.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Replication/ReplicationGui.php M libraries/classes/ResponseRenderer.php M libraries/classes/UrlRedirector.php M libraries/classes/UserPreferences.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/ConfigTest.php M test/classes/Controllers/CollationConnectionControllerTest.php M test/classes/CoreTest.php M test/classes/UserPreferencesTest.php D templates/header_location.twig Log Message: ----------- Move Core::sendHeaderLocation() to ResponseRenderer::redirect() Removes the IIS specific logic. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 5b428f6f77e80e92ad9d0f286b5bf83f62dd3441 https://github.com/phpmyadmin/phpmyadmin/commit/5b428f6f77e80e92ad9d0f286b5… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-06 (Sun, 08 August 2023) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Config/PageSettings.php M libraries/classes/Controllers/AbstractController.php M libraries/classes/Controllers/CollationConnectionController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Controllers/LogoutController.php M libraries/classes/Controllers/Sql/SqlController.php M libraries/classes/Controllers/ThemeSetController.php M libraries/classes/Core.php M libraries/classes/Export/Export.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Replication/ReplicationGui.php M libraries/classes/ResponseRenderer.php M libraries/classes/UrlRedirector.php M libraries/classes/UserPreferences.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/ConfigTest.php M test/classes/Controllers/CollationConnectionControllerTest.php M test/classes/CoreTest.php M test/classes/UserPreferencesTest.php D templates/header_location.twig Log Message: ----------- Merge pull request #18603 from MauricioFauth/response-redirect Move Core::sendHeaderLocation() to ResponseRenderer::redirect()

1 0