- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 719bc9: $column['values'] is never set anywhere
by Kamil Tekiela 25 May '23

25 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 719bc917976268eeabaf910fe769864ebebcfc1d https://github.com/phpmyadmin/phpmyadmin/commit/719bc917976268eeabaf910fe76… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-23 (Tue, 05 May 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/table/insert/column_row.twig Log Message: ----------- $column['values'] is never set anywhere Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 919bf36460ec734b8751e27e021f2aa51ca38da2 https://github.com/phpmyadmin/phpmyadmin/commit/919bf36460ec734b8751e27e021… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-23 (Tue, 05 May 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/table/insert/column_row.twig M test/classes/InsertEditTest.php Log Message: ----------- Move getColumnTitle() out of $column Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 90c0dc3b302b7d1eaf1d914c068f432a23c48402 https://github.com/phpmyadmin/phpmyadmin/commit/90c0dc3b302b7d1eaf1d914c068… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-23 (Tue, 05 May 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php Log Message: ----------- Remove unused params in IO plugins Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: fa826f737a8cd7c6ce389bc96e838ec91668939d https://github.com/phpmyadmin/phpmyadmin/commit/fa826f737a8cd7c6ce389bc96e8… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-23 (Tue, 05 May 2023) +01:00 Changed paths: A libraries/classes/InsertEditColumn.php M libraries/classes/Database/Routines.php M libraries/classes/Html/Generator.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/table/insert/column_row.twig M templates/table/insert/value_column_for_other_datatype.twig M test/classes/Html/GeneratorTest.php M test/classes/InsertEditTest.php M test/classes/Plugins/Transformations/TransformationPluginsTest.php Log Message: ----------- Implement InsertEditColumn Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 7838a42a34ea6a644086b29ae9ce714d5431469c https://github.com/phpmyadmin/phpmyadmin/commit/7838a42a34ea6a644086b29ae9c… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-23 (Tue, 05 May 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M libraries/classes/Query/Generator.php M test/classes/InsertEditTest.php M test/classes/Query/GeneratorTest.php Log Message: ----------- Move buildInsertSqlQuery to Generator Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 62ec1bcc2c14c465ed688c8805b7a645e9d1e2bd https://github.com/phpmyadmin/phpmyadmin/commit/62ec1bcc2c14c465ed688c8805b… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-24 (Wed, 05 May 2023) -03:00 Changed paths: A libraries/classes/InsertEditColumn.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/Database/Routines.php M libraries/classes/Html/Generator.php M libraries/classes/InsertEdit.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php M libraries/classes/Query/Generator.php M phpstan-baseline.neon M psalm-baseline.xml M templates/table/insert/column_row.twig M templates/table/insert/value_column_for_other_datatype.twig M test/classes/Html/GeneratorTest.php M test/classes/InsertEditTest.php M test/classes/Plugins/Transformations/TransformationPluginsTest.php M test/classes/Query/GeneratorTest.php Log Message: ----------- Merge pull request #18445 from kamil-tekiela/InsertEdit-pt4 InsertEdit refactoring - part 4

1 0

[phpmyadmin/phpmyadmin] 442a30: Translated using Weblate (Polish)
by Andrzej Pauli 24 May '23

24 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 442a30e2261f4c8099306a59f8186ab92ed36c73 https://github.com/phpmyadmin/phpmyadmin/commit/442a30e2261f4c8099306a59f81… Author: Andrzej Pauli <andrzej.pauli(a)gmail.com> Date: 2023-05-20 (Sat, 05 May 2023) +02:00 Changed paths: M po/pl.po Log Message: ----------- Translated using Weblate (Polish) Currently translated at 51.1% (1753 of 3427 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/pl/ Signed-off-by: Andrzej Pauli <andrzej.pauli(a)gmail.com> Commit: daa6cb9c1278a28e7257daf055983df0ed1871d2 https://github.com/phpmyadmin/phpmyadmin/commit/daa6cb9c1278a28e7257daf0559… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-24 (Wed, 05 May 2023) +01:00 Changed paths: M templates/database/central_columns/main.twig Log Message: ----------- Fix broken link-button Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 6d6f3dc29f4f66840bf263f71790c9c4f5bbff26 https://github.com/phpmyadmin/phpmyadmin/commit/6d6f3dc29f4f66840bf263f7179… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-24 (Wed, 05 May 2023) -03:00 Changed paths: M templates/database/central_columns/main.twig Log Message: ----------- Merge pull request #18449 from kamil-tekiela/Fix-broken-link-button Fix broken link-button Commit: 7943cf86ed48a0529c075674d03eea8ec5e4f4ff https://github.com/phpmyadmin/phpmyadmin/commit/7943cf86ed48a0529c075674d03… Author: IAndreyI <36403726+IAndreyI(a)users.noreply.github.com> Date: 2023-05-24 (Wed, 05 May 2023) -03:00 Changed paths: M ChangeLog M js/src/functions.js Log Message: ----------- Fix #18314 - dragged row in index form (#18388) * fix dragged row in index form Signed-off-by: Petrichenko Andrey <1993czar(a)gmail.com> * correct remarks Signed-off-by: Petrichenko Andrey <1993czar(a)gmail.com> --------- Signed-off-by: Petrichenko Andrey <1993czar(a)gmail.com> Co-authored-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: b100c05f8498bed672d9f32ef7ab1a273eba1555 https://github.com/phpmyadmin/phpmyadmin/commit/b100c05f8498bed672d9f32ef7a… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-24 (Wed, 05 May 2023) -03:00 Changed paths: M ChangeLog M js/src/modules/functions.ts M phpstan-baseline.neon M psalm-baseline.xml M templates/database/central_columns/main.twig Log Message: ----------- Merge branch 'QA_5_2' Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] daa6cb: Fix broken link-button
by Kamil Tekiela 24 May '23

24 May '23

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: daa6cb9c1278a28e7257daf055983df0ed1871d2 https://github.com/phpmyadmin/phpmyadmin/commit/daa6cb9c1278a28e7257daf0559… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-24 (Wed, 05 May 2023) +01:00 Changed paths: M templates/database/central_columns/main.twig Log Message: ----------- Fix broken link-button Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 6d6f3dc29f4f66840bf263f71790c9c4f5bbff26 https://github.com/phpmyadmin/phpmyadmin/commit/6d6f3dc29f4f66840bf263f7179… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-24 (Wed, 05 May 2023) -03:00 Changed paths: M templates/database/central_columns/main.twig Log Message: ----------- Merge pull request #18449 from kamil-tekiela/Fix-broken-link-button Fix broken link-button

1 0

[phpmyadmin/phpmyadmin] 9590ba: Replace superglobals with serverrequest in GetFieldController with fixes
by Evgeny Skorlov 24 May '23

24 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 9590ba6bc1c2e444bc7889c064b67a1e95dec91e https://github.com/phpmyadmin/phpmyadmin/commit/9590ba6bc1c2e444bc7889c064b… Author: Evgeny Skorlov <eugene(a)skorlov.name> Date: 2023-05-10 (Wed, 05 May 2023) +11:00 Changed paths: M libraries/classes/Controllers/Table/GetFieldController.php M test/classes/Controllers/Table/GetFieldControllerTest.php Log Message: ----------- Replace superglobals with serverrequest in GetFieldController with fixes Signed-off-by: Evgeny Skorlov <eugene(a)skorlov.name> Commit: 44f2b4d5bd6cc0e928f32c4c23297a59b1809915 https://github.com/phpmyadmin/phpmyadmin/commit/44f2b4d5bd6cc0e928f32c4c232… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-24 (Wed, 05 May 2023) -03:00 Changed paths: M libraries/classes/Controllers/Table/GetFieldController.php M test/classes/Controllers/Table/GetFieldControllerTest.php Log Message: ----------- Merge pull request #18390 from ru-asdx/refactor-17769-p2 Replace superglobals with serverrequest in GetFieldController

1 0

[phpmyadmin/phpmyadmin] d0e1b3: Fix missing params when using Edit inline on SQL message box
by Maurício Meneghini Fauth 23 May '23

23 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: d0e1b3a0932fe92d186b782456b7b729342a1c6c https://github.com/phpmyadmin/phpmyadmin/commit/d0e1b3a0932fe92d186b782456b… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-23 (Tue, 05 May 2023) -03:00 Changed paths: M js/src/modules/functions.ts Log Message: ----------- Fix missing params when using Edit inline on SQL message box Fixes https://github.com/phpmyadmin/phpmyadmin/issues/18440 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 1a611a: Fix failing Selenium tests
by Maurício Meneghini Fauth 23 May '23

23 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 1a611a96410a3d67ebd3cd210aa781b18e337474 https://github.com/phpmyadmin/phpmyadmin/commit/1a611a96410a3d67ebd3cd210aa… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-23 (Tue, 05 May 2023) -03:00 Changed paths: M phpstan-baseline.neon M test/selenium/Database/OperationsTest.php M test/selenium/ImportTest.php M test/selenium/ServerSettingsTest.php M test/selenium/Table/OperationsTest.php Log Message: ----------- Fix failing Selenium tests Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] d1c686: Fix some failing Selenium tests
by Maurício Meneghini Fauth 23 May '23

23 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: d1c6861b2c3303cb90b5ff1a199dd4af016b5d7a https://github.com/phpmyadmin/phpmyadmin/commit/d1c6861b2c3303cb90b5ff1a199… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-23 (Tue, 05 May 2023) -03:00 Changed paths: M test/selenium/Database/EventsTest.php M test/selenium/Database/ProceduresTest.php M test/selenium/Database/StructureTest.php M test/selenium/Database/TriggersTest.php M test/selenium/Table/OperationsTest.php M test/selenium/Table/StructureTest.php M test/selenium/TrackingTest.php Log Message: ----------- Fix some failing Selenium tests Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 9e5619: Fix issue with inline edit with multiple SQL message box
by Maurício Meneghini Fauth 23 May '23

23 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 9e56194fc0915112434ae19d97db8202f9caa87b https://github.com/phpmyadmin/phpmyadmin/commit/9e56194fc0915112434ae19d97d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-23 (Tue, 05 May 2023) -03:00 Changed paths: M js/src/modules/functions.ts M libraries/classes/Html/Generator.php M test/classes/Controllers/Table/DeleteRowsControllerTest.php M test/classes/Html/GeneratorTest.php Log Message: ----------- Fix issue with inline edit with multiple SQL message box Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] c4421d: Improve type hint
by Kamil Tekiela 23 May '23

23 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c4421d064d16df3da41690c6925b3eb89a1ef282 https://github.com/phpmyadmin/phpmyadmin/commit/c4421d064d16df3da41690c6925… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: M libraries/classes/ConfigStorage/Relation.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Improve type hint Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 3b611f39451cc843fe5965fd939d1da79aad59ad https://github.com/phpmyadmin/phpmyadmin/commit/3b611f39451cc843fe5965fd939… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: A libraries/classes/ColumnFull.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Implement ColumnFull DTO This is MVP. In following commits the DTO will be expanded and improved. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 2c9153ac5d9702ddfa728ed9e60dcfcd0013649d https://github.com/phpmyadmin/phpmyadmin/commit/2c9153ac5d9702ddfa728ed9e60… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Refactor column length calculation Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0d9e7958902a55627fadb79ca2eeadcf112d84a9 https://github.com/phpmyadmin/phpmyadmin/commit/0d9e7958902a55627fadb79ca2e… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: M libraries/classes/DatabaseInterface.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Narrow down type of SHOW COLUMNS MySQL clearly defines the structure of the fields for SHOW [FULL] COLUMNS. We can be sure it will be either string or null. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0aa3210ee10be006cd6ac4f8d7545329f7c5929d https://github.com/phpmyadmin/phpmyadmin/commit/0aa3210ee10be006cd6ac4f8d75… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Use array shape instead of (string|null)[] Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: fccaaf65a390d5ccbfaf6e312562871a3ee425b2 https://github.com/phpmyadmin/phpmyadmin/commit/fccaaf65a390d5ccbfaf6e31256… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: M libraries/classes/Controllers/Database/DataDictionaryController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Normalization.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Table/StructureControllerTest.php Log Message: ----------- Remove all new Psalm issues Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 1d180c54825a9443bc5bbfc8eb61fc93815b6005 https://github.com/phpmyadmin/phpmyadmin/commit/1d180c54825a9443bc5bbfc8eb6… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/Structure/ChangeController.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Use null as sentinel value in getColumn Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 43a864b50fce42dd5c5c4260be9de9614ebae0a2 https://github.com/phpmyadmin/phpmyadmin/commit/43a864b50fce42dd5c5c4260be9… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M test/classes/InsertEditTest.php Log Message: ----------- Assign Default inside analyzeTableColumnsArray Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 56136bb350c701c26719a8bd1316bb252778a73f https://github.com/phpmyadmin/phpmyadmin/commit/56136bb350c701c26719a8bd131… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-19 (Fri, 05 May 2023) +01:00 Changed paths: M test/classes/Stubs/DbiDummy.php Log Message: ----------- Fix failing test Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 30ff7d4b6a790538bd9aa9cd55d021ef7a0751b8 https://github.com/phpmyadmin/phpmyadmin/commit/30ff7d4b6a790538bd9aa9cd55d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-05-23 (Tue, 05 May 2023) -03:00 Changed paths: A libraries/classes/ColumnFull.php M libraries/classes/ConfigStorage/Relation.php M libraries/classes/Controllers/Database/DataDictionaryController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/Structure/ChangeController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M libraries/classes/InsertEdit.php M libraries/classes/Normalization.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/InsertEditTest.php M test/classes/Stubs/DbiDummy.php Log Message: ----------- Merge pull request #18434 from kamil-tekiela/InsertEdit-pt-3 InsertEdit refactoring - part 3

1 0

[phpmyadmin/phpmyadmin] 37473d: Update psalm-baseline.xml
by Kamil Tekiela 23 May '23

23 May '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 37473d1a36e8756d1b43c816946e80f2c1c7e192 https://github.com/phpmyadmin/phpmyadmin/commit/37473d1a36e8756d1b43c816946… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-05-22 (Mon, 05 May 2023) +01:00 Changed paths: M psalm-baseline.xml Log Message: ----------- Update psalm-baseline.xml Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0