- Git - lists.phpmyadmin.net

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] ceb77c: Function was used before it was defined
by Marc Delisle 12 Jun '14

12 Jun '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: ceb77ce6d4fc473b7eac79a5292f5a3b2065b64d https://github.com/phpmyadmin/phpmyadmin/commit/ceb77ce6d4fc473b7eac79a5292… Author: Marc Delisle <marc(a)infomarc.info> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M js/functions.js Log Message: ----------- Function was used before it was defined Signed-off-by: Marc Delisle <marc(a)infomarc.info>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 98034b: Remove $GLOBALS['cfg']['Bookmark'] variable
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 98034ba148b0d9fe2abcb7519c5fbc695a19c594 https://github.com/phpmyadmin/phpmyadmin/commit/98034ba148b0d9fe2abcb7519c5… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M import.php M libraries/bookmark.lib.php M libraries/sql.lib.php M libraries/sql_query_form.lib.php Log Message: ----------- Remove $GLOBALS['cfg']['Bookmark'] variable It makes it impossible to include bookmark library at any time as when it is included before configuration is loaded it caches false result for bookmarks support. And anyway, using superglobals is always bad idea. Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 2bd954: bug-4454: PMA_DatabaseInterface::getColumnsFull() ...
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2bd95448787239e66ab87e4f9cd3cb47d603f5dc https://github.com/phpmyadmin/phpmyadmin/commit/2bd95448787239e66ab87e4f9cd… Author: Chirayu Chiripal <chirayu.chiripal(a)gmail.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/DatabaseInterface.class.php Log Message: ----------- bug-4454: PMA_DatabaseInterface::getColumnsFull() when called with no database or table parameter gives incorrectly nested keys Signed-off-by: Chirayu Chiripal <chirayu.chiripal(a)gmail.com> Commit: 2b8bb91bc3a66e2014ea078a68a0962708609eee https://github.com/phpmyadmin/phpmyadmin/commit/2b8bb91bc3a66e2014ea078a68a… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/DatabaseInterface.class.php Log Message: ----------- Merge pull request #1223 from D-storm/bug-4454 bug-4454: PMA_DatabaseInterface::getColumnsFull() when called with no da... Commit: ddac366fd6e29d3b347adf81997e190a7fe78343 https://github.com/phpmyadmin/phpmyadmin/commit/ddac366fd6e29d3b347adf81997… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/DatabaseInterface.class.php Log Message: ----------- Merge remote-tracking branch 'origin/QA_4_2' Conflicts: libraries/DatabaseInterface.class.php Compare: https://github.com/phpmyadmin/phpmyadmin/compare/a7bcbbc35f5e...ddac366fd6e2

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 2bd954: bug-4454: PMA_DatabaseInterface::getColumnsFull() ...
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/QA_4_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2bd95448787239e66ab87e4f9cd3cb47d603f5dc https://github.com/phpmyadmin/phpmyadmin/commit/2bd95448787239e66ab87e4f9cd… Author: Chirayu Chiripal <chirayu.chiripal(a)gmail.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/DatabaseInterface.class.php Log Message: ----------- bug-4454: PMA_DatabaseInterface::getColumnsFull() when called with no database or table parameter gives incorrectly nested keys Signed-off-by: Chirayu Chiripal <chirayu.chiripal(a)gmail.com> Commit: 2b8bb91bc3a66e2014ea078a68a0962708609eee https://github.com/phpmyadmin/phpmyadmin/commit/2b8bb91bc3a66e2014ea078a68a… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/DatabaseInterface.class.php Log Message: ----------- Merge pull request #1223 from D-storm/bug-4454 bug-4454: PMA_DatabaseInterface::getColumnsFull() when called with no da... Compare: https://github.com/phpmyadmin/phpmyadmin/compare/bc6031502398...2b8bb91bc3a6

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 96977c: Use require here
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 96977c994e0e76df7348c4ed8e79ab4c96dc045a https://github.com/phpmyadmin/phpmyadmin/commit/96977c994e0e76df7348c4ed8e7… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php Log Message: ----------- Use require here Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: a7bcbbc35f5ec84f10ad9513c7eb8b312676e607 https://github.com/phpmyadmin/phpmyadmin/commit/a7bcbbc35f5ec84f10ad9513c7e… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M test/classes/plugin/auth/PMA_AuthenticationCookie_test.php Log Message: ----------- Wrap long line Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/20640592f032...a7bcbbc35f5e

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 206405: Always use phpseclib for cookie encryption
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 20640592f03239e11053d507c68e6093144f8bbc https://github.com/phpmyadmin/phpmyadmin/commit/20640592f03239e11053d507c68… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php M test/classes/plugin/auth/PMA_AuthenticationCookie_test.php Log Message: ----------- Always use phpseclib for cookie encryption - it provides fallback in case mcrypt is not found - we now use AES in both mcrypt and PHP code case - cleanup the code by removing mcrypt conditials - rename some methods and cookies so that they don't refer to implementation details - switching encryption implementations no longer invalidates the credentials Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] d69f8b: Update phpseclib to latest Git snapshot
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: d69f8bdd09df47a882391422666e3d948c735712 https://github.com/phpmyadmin/phpmyadmin/commit/d69f8bdd09df47a882391422666… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/phpseclib/Crypt/AES.php A libraries/phpseclib/Crypt/Base.php A libraries/phpseclib/Crypt/Random.php M libraries/phpseclib/Crypt/Rijndael.php Log Message: ----------- Update phpseclib to latest Git snapshot Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: c6e76422c41e1c573c0c0163376a61d4556083b2 https://github.com/phpmyadmin/phpmyadmin/commit/c6e76422c41e1c573c0c0163376… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M doc/vendors.rst M libraries/plugins/auth/AuthenticationCookie.class.php M libraries/vendor_config.php Log Message: ----------- Allow to use system phpseclib Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: bc603150239888637f21b3fef821d9cde8f65565 https://github.com/phpmyadmin/phpmyadmin/commit/bc603150239888637f21b3fef82… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php M test/classes/plugin/auth/PMA_AuthenticationCookie_test.php Log Message: ----------- Adjust tests to new IV logic Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 0652ca9ccd98454fcdb2bb175a4273b317353ef5 https://github.com/phpmyadmin/phpmyadmin/commit/0652ca9ccd98454fcdb2bb175a4… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php M test/classes/plugin/auth/PMA_AuthenticationCookie_test.php Log Message: ----------- Merge remote-tracking branch 'origin/QA_4_2' Compare: https://github.com/phpmyadmin/phpmyadmin/compare/716f6d4c553e...0652ca9ccd98

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] bc6031: Adjust tests to new IV logic
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/QA_4_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: bc603150239888637f21b3fef821d9cde8f65565 https://github.com/phpmyadmin/phpmyadmin/commit/bc603150239888637f21b3fef82… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php M test/classes/plugin/auth/PMA_AuthenticationCookie_test.php Log Message: ----------- Adjust tests to new IV logic Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 953c74: Separate check for password cookie
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 953c7415ad548820f605c3beea9c556629f137e2 https://github.com/phpmyadmin/phpmyadmin/commit/953c7415ad548820f605c3beea9… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php Log Message: ----------- Separate check for password cookie Otherwise it would not be possible to recall user name. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 716f6d4c553eb6e3db693ccb8eec1d288edcf15c https://github.com/phpmyadmin/phpmyadmin/commit/716f6d4c553eb6e3db693ccb8ee… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php Log Message: ----------- Merge remote-tracking branch 'origin/QA_4_2' Compare: https://github.com/phpmyadmin/phpmyadmin/compare/bd482546bc27...716f6d4c553e

1 0

[Phpmyadmin-git] [phpmyadmin/phpmyadmin] 953c74: Separate check for password cookie
by Michal Čihař 12 Jun '14

12 Jun '14

Branch: refs/heads/QA_4_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 953c7415ad548820f605c3beea9c556629f137e2 https://github.com/phpmyadmin/phpmyadmin/commit/953c7415ad548820f605c3beea9… Author: Michal Čihař <michal(a)cihar.com> Date: 2014-06-12 (Thu, 12 Jun 2014) Changed paths: M libraries/plugins/auth/AuthenticationCookie.class.php Log Message: ----------- Separate check for password cookie Otherwise it would not be possible to recall user name. Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0