- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 7d3c84: Increase the PHPStan level and update the baseline file
by Maurício Meneghini Fauth 03 Dec '21

03 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 7d3c84a88163237211b9908978d473e91657ce3f https://github.com/phpmyadmin/phpmyadmin/commit/7d3c84a88163237211b9908978d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-12-03 (Fri, 12 December 2021) -03:00 Changed paths: M phpstan-baseline.neon M phpstan.neon.dist M psalm-baseline.xml Log Message: ----------- Increase the PHPStan level and update the baseline file Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] a42803: Psalm fixes 3 (#17221)
by Kamil Tekiela 03 Dec '21

03 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a42803297c3110ac10247a5e5a4b663bf1849f59 https://github.com/phpmyadmin/phpmyadmin/commit/a42803297c3110ac10247a5e5a4… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-12-03 (Fri, 12 December 2021) -03:00 Changed paths: M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Database/Qbe.php M libraries/classes/Database/Triggers.php M libraries/classes/Display/Results.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Server/Privileges.php M libraries/classes/Utils/HttpRequest.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Server/PrivilegesTest.php Log Message: ----------- Psalm fixes 3 (#17221) * Update psalm-baseline.xml Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Small bug fixes Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * non-falsy-string is always true Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * currentSearch property is nullable Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove unusued parameter $columnIndex Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Use parameters instead of globals in sendEditor() The two globals in this method are read-only. There is an unused parameter in the signature. Let's add one more and use them instead of globals. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove unusued parameter $crlf Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] f446e6: Remove unused variables
by Kamil Tekiela 03 Dec '21

03 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: f446e6da88645921d82e2d2ab5a3ed91f5b21604 https://github.com/phpmyadmin/phpmyadmin/commit/f446e6da88645921d82e2d2ab5a… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-12-03 (Fri, 12 December 2021) +00:00 Changed paths: M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/ImportController.php M libraries/classes/Controllers/Table/ChangeRowsController.php M libraries/classes/Controllers/Table/ChartController.php M libraries/classes/Controllers/Table/ExportRowsController.php M libraries/classes/Controllers/Table/Structure/BrowseController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Database/Qbe.php M libraries/classes/Display/Results.php M libraries/classes/Linter.php M libraries/classes/Plugins.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Export/ExportYaml.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Import/ImportCsv.php M libraries/classes/Table.php M libraries/classes/Table/ColumnsDefinition.php M libraries/classes/Table/Indexes.php M libraries/classes/Tracking.php M libraries/classes/Utils/HttpRequest.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Remove unused variables Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: ef72b89fa8da9c7d842a48c53fe58fddd0d5819c https://github.com/phpmyadmin/phpmyadmin/commit/ef72b89fa8da9c7d842a48c53fe… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-12-03 (Fri, 12 December 2021) -03:00 Changed paths: M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/ImportController.php M libraries/classes/Controllers/Table/ChangeRowsController.php M libraries/classes/Controllers/Table/ChartController.php M libraries/classes/Controllers/Table/ExportRowsController.php M libraries/classes/Controllers/Table/Structure/BrowseController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Database/Qbe.php M libraries/classes/Display/Results.php M libraries/classes/Linter.php M libraries/classes/Plugins.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Export/ExportYaml.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Import/ImportCsv.php M libraries/classes/Table.php M libraries/classes/Table/ColumnsDefinition.php M libraries/classes/Table/Indexes.php M libraries/classes/Tracking.php M libraries/classes/Utils/HttpRequest.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Merge pull request #17220 from kamil-tekiela/Psalm-fixes-2 Remove unused variables

1 0

[phpmyadmin/phpmyadmin] f4493b: Fix bug #17216 (multi-assignment of privileges)
by Kamil Tekiela 02 Dec '21

02 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: f4493bb0cad22d850ddc9269f8d135a67d879e74 https://github.com/phpmyadmin/phpmyadmin/commit/f4493bb0cad22d850ddc9269f8d… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-12-01 (Wed, 12 December 2021) +00:00 Changed paths: M libraries/classes/Server/Privileges.php M psalm-baseline.xml Log Message: ----------- Fix bug #17216 (multi-assignment of privileges) Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9245cec29046a95820a21e68086ce8f681a56caf https://github.com/phpmyadmin/phpmyadmin/commit/9245cec29046a95820a21e68086… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-12-01 (Wed, 12 December 2021) +00:00 Changed paths: M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Server/Privileges.php M psalm-baseline.xml Log Message: ----------- Fix type issues in PrivilegesController Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: a7053f14a8758642c61ca550e32f5e3373085a5e https://github.com/phpmyadmin/phpmyadmin/commit/a7053f14a8758642c61ca550e32… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-12-01 (Wed, 12 December 2021) +00:00 Changed paths: M test/classes/Server/PrivilegesTest.php Log Message: ----------- Add tests for bug #17216 (multi-assignment of privileges) Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 92fb287763ae920efb22ea00ec03354734a40aa8 https://github.com/phpmyadmin/phpmyadmin/commit/92fb287763ae920efb22ea00ec0… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-12-01 (Wed, 12 December 2021) +00:00 Changed paths: M libraries/classes/Server/Privileges.php M psalm-baseline.xml Log Message: ----------- Fix broken routine privileges Procedures are case-insensitive in MySQL. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 8664a7b819bafa82da2ada76cdec895cf0708af6 https://github.com/phpmyadmin/phpmyadmin/commit/8664a7b819bafa82da2ada76cde… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-12-02 (Thu, 12 December 2021) -03:00 Changed paths: M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Server/Privileges.php M psalm-baseline.xml M test/classes/Server/PrivilegesTest.php Log Message: ----------- Merge pull request #17217 from kamil-tekiela/Fix-privileges-bug Fix bug #17216

1 0

[phpmyadmin/phpmyadmin] 488e7c: Use array_keys whenever only keys are needed in foreach
by Kamil Tekiela 02 Dec '21

02 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 488e7cb5bf5e7ce1197d5bb65469c7a6157aa64f https://github.com/phpmyadmin/phpmyadmin/commit/488e7cb5bf5e7ce1197d5bb6546… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-11-29 (Mon, 11 November 2021) +00:00 Changed paths: M libraries/classes/BrowseForeigners.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Controllers/Setup/HomeController.php M libraries/classes/Controllers/Table/ChartController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Operations.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Schema/TableStats.php M libraries/classes/Server/UserGroups.php M libraries/classes/Sql.php M libraries/classes/Table.php M libraries/classes/Table/ColumnsDefinition.php M psalm-baseline.xml M test/classes/AbstractTestCase.php M test/classes/Config/DescriptionTest.php Log Message: ----------- Use array_keys whenever only keys are needed in foreach Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: acff73aa247e00afb84760b63c1174acd78716e5 https://github.com/phpmyadmin/phpmyadmin/commit/acff73aa247e00afb84760b63c1… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-12-02 (Thu, 12 December 2021) -03:00 Changed paths: M libraries/classes/BrowseForeigners.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Controllers/Setup/HomeController.php M libraries/classes/Controllers/Table/ChartController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Operations.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Schema/TableStats.php M libraries/classes/Server/UserGroups.php M libraries/classes/Sql.php M libraries/classes/Table.php M libraries/classes/Table/ColumnsDefinition.php M psalm-baseline.xml M test/classes/AbstractTestCase.php M test/classes/Config/DescriptionTest.php Log Message: ----------- Merge pull request #17215 from kamil-tekiela/Psalm-fixes-1 Use array_keys whenever only keys are needed in foreach

1 0

[phpmyadmin/phpmyadmin] b604a8: Refactor getMenu() method
by Kamil Tekiela 02 Dec '21

02 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: b604a8660ee40b829dc42b26caa180a787563719 https://github.com/phpmyadmin/phpmyadmin/commit/b604a8660ee40b829dc42b26caa… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-11-28 (Sun, 11 November 2021) +00:00 Changed paths: M libraries/classes/Menu.php M psalm-baseline.xml Log Message: ----------- Refactor getMenu() method Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 7b95a4b6d244533abb3dc27da2eb668b35338d18 https://github.com/phpmyadmin/phpmyadmin/commit/7b95a4b6d244533abb3dc27da2e… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-11-28 (Sun, 11 November 2021) +00:00 Changed paths: M libraries/classes/Header.php M libraries/classes/Menu.php M test/classes/MenuTest.php Log Message: ----------- Use DI for $dbi in Menu.php Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 63b59f25504c336b5fff1cbd537c1dff70f2ee82 https://github.com/phpmyadmin/phpmyadmin/commit/63b59f25504c336b5fff1cbd537… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-11-28 (Sun, 11 November 2021) +00:00 Changed paths: M libraries/classes/Menu.php M libraries/classes/Sql.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Fix issues with wrong type provided for $table Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 36fc97c45c5df542e93dac5e3e60bef58ad9caf4 https://github.com/phpmyadmin/phpmyadmin/commit/36fc97c45c5df542e93dac5e3e6… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-11-28 (Sun, 11 November 2021) +00:00 Changed paths: M libraries/classes/Menu.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Default return value to an empty array. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: a1bb68a742556c64ad4813c856982c4978f812cd https://github.com/phpmyadmin/phpmyadmin/commit/a1bb68a742556c64ad4813c8569… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-11-28 (Sun, 11 November 2021) +00:00 Changed paths: M libraries/classes/Menu.php M psalm-baseline.xml Log Message: ----------- Introduce typed variable Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: b4dcec26faedbb8429212998049f07824328f1a8 https://github.com/phpmyadmin/phpmyadmin/commit/b4dcec26faedbb8429212998049… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-12-02 (Thu, 12 December 2021) -03:00 Changed paths: M libraries/classes/Header.php M libraries/classes/Menu.php M libraries/classes/Sql.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/MenuTest.php Log Message: ----------- Merge pull request #17213 from kamil-tekiela/Refactor-Menu.php Refactor menu.php

1 0

[phpmyadmin/phpmyadmin] 1270ef: Refactor util.php (#17212)
by Kamil Tekiela 02 Dec '21

02 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 1270efc2a9205f5160262ecbd33558203f9e21a1 https://github.com/phpmyadmin/phpmyadmin/commit/1270efc2a9205f5160262ecbd33… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-12-02 (Thu, 12 December 2021) -03:00 Changed paths: M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Display/Results.php M libraries/classes/InsertEdit.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Util.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Display/ResultsTest.php M test/classes/UtilTest.php Log Message: ----------- Refactor util.php (#17212) * Remove extra space Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove null checks on properties that cannot be null The value could be null only if the property exists in stdClass returned by mysqli but is null. Mysqli doesn't do that. Unless the value can be null in some other way, this check is redundant. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Add psalm-return Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove $handle parameter of getUniqueCondition() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Type hint the $row parameter Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Co-authored-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] dea4c9: Refactor relations.php (#17210)
by Kamil Tekiela 02 Dec '21

02 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: dea4c972afce6ba8d7bc904d2706924befc503de https://github.com/phpmyadmin/phpmyadmin/commit/dea4c972afce6ba8d7bc904d270… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-12-02 (Thu, 12 December 2021) -03:00 Changed paths: M libraries/classes/Relation.php M psalm-baseline.xml Log Message: ----------- Refactor relations.php (#17210) * Refactor getComments() Use early return and remove redundant if statement. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Fix indentation Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove temporary variable Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove redundant code Remove redundant if statement. Break at the end of the loop. elseif when there is no other choice. Redundant ! empty(). Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Collapse if statement into an elvis operator Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Better type hinting for return array We can tell Psalm what to expect, but we should declare the variables first. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove dead code Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Use array_keys instead of unused variable Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Add type declaration and psalm-return Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Add psalm-return to checkChildForeignReferences() Also added type declaration, and simplified the code Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Refactor getChildReferences() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Improve type inference for foreignDropdown Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * [bugfix] Cast the value to a string to avoid type mismatch. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Add proper string type declaration to $foreign_filter Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] ee45b3: Create the `UrlRedirector` class
by Maurício Meneghini Fauth 01 Dec '21

01 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: ee45b3981c5b4310d492ee243a9e34910af8e4b2 https://github.com/phpmyadmin/phpmyadmin/commit/ee45b3981c5b4310d492ee243a9… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-12-01 (Wed, 12 December 2021) -03:00 Changed paths: A libraries/classes/UrlRedirector.php M psalm-baseline.xml M url.php Log Message: ----------- Create the `UrlRedirector` class Extracts the url.php logic to the UrlRedirector::redirect static method. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] e936ca: Add basic test for `Table\OperationsController` class
by Maurício Meneghini Fauth 01 Dec '21

01 Dec '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: e936cad5429a6773c412369412d1dbc539aea1e4 https://github.com/phpmyadmin/phpmyadmin/commit/e936cad5429a6773c412369412d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-12-01 (Wed, 12 December 2021) -03:00 Changed paths: A test/classes/Controllers/Table/OperationsControllerTest.php M psalm-baseline.xml M test/classes/AbstractTestCase.php Log Message: ----------- Add basic test for `Table\OperationsController` class Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0