- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] aa7405: Coding standard fixes
by William Desportes 15 Jul '21

15 Jul '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: aa7405c90b19b226026492ec220eb3128d421eda https://github.com/phpmyadmin/phpmyadmin/commit/aa7405c90b19b226026492ec220… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M test/bootstrap-static.php Log Message: ----------- Coding standard fixes Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: b4652b108ef1fe2aef0795f23049c5e3cd233738 https://github.com/phpmyadmin/phpmyadmin/commit/b4652b108ef1fe2aef0795f2304… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M libraries/classes/Util.php Log Message: ----------- Remove non used Util::getFirstOccurringRegularExpression Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: fe295d66751554bd69db49598367892acbe2bb7e https://github.com/phpmyadmin/phpmyadmin/commit/fe295d66751554bd69db4959836… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M psalm.xml Log Message: ----------- Set Psalm sealing to true See: https://psalm.dev/docs/running_psalm/configuration/#sealallmethods Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] bcf635: Adjust static bootstrap for Psalm alter
by William Desportes 15 Jul '21

15 Jul '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: bcf635100dc9154430f5adc54c191e14016a52a9 https://github.com/phpmyadmin/phpmyadmin/commit/bcf635100dc9154430f5adc54c1… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M test/bootstrap-static.php Log Message: ----------- Adjust static bootstrap for Psalm alter Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 587536b766f1d29ff1190b0dbd1bfb8352394715 https://github.com/phpmyadmin/phpmyadmin/commit/587536b766f1d29ff1190b0dbd1… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M libraries/classes/Controllers/Database/QueryByExampleController.php M libraries/classes/Database/Routines.php M libraries/classes/Table.php M psalm-baseline.xml M setup/validate.php M test/classes/ConfigTest.php M test/classes/FlashMessagesTest.php M test/classes/Plugins/Import/ImportOdsTest.php Log Message: ----------- Remove non used variables Running: composer run psalm -- --alter --issues=UnusedVariable And removing the false positives I reported upstream Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: c30b1887a59cf8c01236c6963e8080021df47e20 https://github.com/phpmyadmin/phpmyadmin/commit/c30b1887a59cf8c01236c6963e8… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M psalm.xml Log Message: ----------- Add types to globals on Psalm Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 34acbcdc3834e33a37a0864113a93e95078b2df4 https://github.com/phpmyadmin/phpmyadmin/commit/34acbcdc3834e33a37a0864113a… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M libraries/classes/Display/Results.php M libraries/classes/Util.php Log Message: ----------- Fix calls to fetchRow using two parameters but function has only one parameter None of our fetchRow methods have more than one parameter Thank you Psalm for catching this ! Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: aa9b58c63c7584a0ffc28360c0d25bca2ea07fa9 https://github.com/phpmyadmin/phpmyadmin/commit/aa9b58c63c7584a0ffc28360c0d… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M ChangeLog Log Message: ----------- Add a ChangeLog entry for 34acbcdc38 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 4499e759018ef5fa238dbef30f111fbb2b53bcc2 https://github.com/phpmyadmin/phpmyadmin/commit/4499e759018ef5fa238dbef30f1… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M ChangeLog M libraries/classes/Display/Results.php M libraries/classes/Utils/Gis.php Log Message: ----------- Merge branch 'QA_5_1' Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 86b296dec7c9789b2a68b57ccb270615a374ca34 https://github.com/phpmyadmin/phpmyadmin/commit/86b296dec7c9789b2a68b57ccb2… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M psalm-baseline.xml M psalm.xml Log Message: ----------- Add more globals to Psalm config and update baseline Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] 34acbc: Fix calls to fetchRow using two parameters but function has only one parameter
by William Desportes 15 Jul '21

15 Jul '21

Branch: refs/heads/QA_5_1 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 34acbcdc3834e33a37a0864113a93e95078b2df4 https://github.com/phpmyadmin/phpmyadmin/commit/34acbcdc3834e33a37a0864113a… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M libraries/classes/Display/Results.php M libraries/classes/Util.php Log Message: ----------- Fix calls to fetchRow using two parameters but function has only one parameter None of our fetchRow methods have more than one parameter Thank you Psalm for catching this ! Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: aa9b58c63c7584a0ffc28360c0d25bca2ea07fa9 https://github.com/phpmyadmin/phpmyadmin/commit/aa9b58c63c7584a0ffc28360c0d… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M ChangeLog Log Message: ----------- Add a ChangeLog entry for 34acbcdc38 Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] aa7957: Ref #16939 - Remove FAQ 6.28 and update FAQ 6.8
by William Desportes 15 Jul '21

15 Jul '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: aa7957a979383d45e17a93a27e46de239a2b8401 https://github.com/phpmyadmin/phpmyadmin/commit/aa7957a979383d45e17a93a27e4… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M doc/faq.rst Log Message: ----------- Ref #16939 - Remove FAQ 6.28 and update FAQ 6.8 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 8661506815909773667ea0be81105d11ece19e62 https://github.com/phpmyadmin/phpmyadmin/commit/8661506815909773667ea0be811… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M doc/faq.rst Log Message: ----------- Update FAQ 1.20 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: a36dd1126bed39a87a2ee80c973259361c5c1e80 https://github.com/phpmyadmin/phpmyadmin/commit/a36dd1126bed39a87a2ee80c973… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Html/Generator.php M test/classes/Html/GeneratorTest.php Log Message: ----------- Fix #17006 - Disable the URL limit for the MariaDB analyser feature Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: b58730c5aceb70bc423962aaaab60496c536ecd9 https://github.com/phpmyadmin/phpmyadmin/commit/b58730c5aceb70bc423962aaaab… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M ChangeLog Log Message: ----------- Add a ChangeLog entry for #17006 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: ef84f770d1531574fb0251eee26eb9148ecfcdcb https://github.com/phpmyadmin/phpmyadmin/commit/ef84f770d1531574fb0251eee26… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M ChangeLog M doc/faq.rst M libraries/classes/Html/Generator.php M test/classes/Html/GeneratorTest.php Log Message: ----------- Merge branch 'QA_5_1' Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: d5b4eae5dd00fe14c5fcd4ab4320891b9bb79c35 https://github.com/phpmyadmin/phpmyadmin/commit/d5b4eae5dd00fe14c5fcd4ab432… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-16 (Fri, 07 July 2021) +02:00 Changed paths: M psalm-baseline.xml M psalm.xml Log Message: ----------- Enable full typed mode of Psalm See: https://github.com/vimeo/psalm/discussions/6003 Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] a36dd1: Fix #17006 - Disable the URL limit for the MariaDB analyser feature
by William Desportes 15 Jul '21

15 Jul '21

Branch: refs/heads/QA_5_1 Home: https://github.com/phpmyadmin/phpmyadmin Commit: a36dd1126bed39a87a2ee80c973259361c5c1e80 https://github.com/phpmyadmin/phpmyadmin/commit/a36dd1126bed39a87a2ee80c973… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Html/Generator.php M test/classes/Html/GeneratorTest.php Log Message: ----------- Fix #17006 - Disable the URL limit for the MariaDB analyser feature Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: b58730c5aceb70bc423962aaaab60496c536ecd9 https://github.com/phpmyadmin/phpmyadmin/commit/b58730c5aceb70bc423962aaaab… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M ChangeLog Log Message: ----------- Add a ChangeLog entry for #17006 Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] aa7957: Ref #16939 - Remove FAQ 6.28 and update FAQ 6.8
by William Desportes 15 Jul '21

15 Jul '21

Branch: refs/heads/QA_5_1 Home: https://github.com/phpmyadmin/phpmyadmin Commit: aa7957a979383d45e17a93a27e46de239a2b8401 https://github.com/phpmyadmin/phpmyadmin/commit/aa7957a979383d45e17a93a27e4… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M doc/faq.rst Log Message: ----------- Ref #16939 - Remove FAQ 6.28 and update FAQ 6.8 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 8661506815909773667ea0be81105d11ece19e62 https://github.com/phpmyadmin/phpmyadmin/commit/8661506815909773667ea0be811… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M doc/faq.rst Log Message: ----------- Update FAQ 1.20 Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] 253585: Fix duplicate quote in navigation nodes
by Maurício Meneghini Fauth 15 Jul '21

15 Jul '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2535853fcc834f18d9f7eec730141cafd44603ca https://github.com/phpmyadmin/phpmyadmin/commit/2535853fcc834f18d9f7eec7301… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-07-15 (Thu, 07 July 2021) -03:00 Changed paths: M ChangeLog M libraries/classes/Navigation/NavigationTree.php Log Message: ----------- Fix duplicate quote in navigation nodes Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: f2871b89fd77f6e309be972e828e6abb9a548ef1 https://github.com/phpmyadmin/phpmyadmin/commit/f2871b89fd77f6e309be972e828… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-07-15 (Thu, 07 July 2021) -03:00 Changed paths: M ChangeLog M libraries/classes/Navigation/NavigationTree.php Log Message: ----------- Merge branch 'QA_5_1'

1 0

[phpmyadmin/phpmyadmin] 253585: Fix duplicate quote in navigation nodes
by Maurício Meneghini Fauth 15 Jul '21

15 Jul '21

Branch: refs/heads/QA_5_1 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 2535853fcc834f18d9f7eec730141cafd44603ca https://github.com/phpmyadmin/phpmyadmin/commit/2535853fcc834f18d9f7eec7301… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-07-15 (Thu, 07 July 2021) -03:00 Changed paths: M ChangeLog M libraries/classes/Navigation/NavigationTree.php Log Message: ----------- Fix duplicate quote in navigation nodes Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 43a29b: Ref #15247 - Remove `defined('TESTSUITE')` from Session::secure
by William Desportes 14 Jul '21

14 Jul '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 43a29b7a5aed538de84c92bb20ab1910f21308a3 https://github.com/phpmyadmin/phpmyadmin/commit/43a29b7a5aed538de84c92bb20a… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Session.php Log Message: ----------- Ref #15247 - Remove `defined('TESTSUITE')` from Session::secure Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 45d6336b9004665738ae66af79d7dee25b71f657 https://github.com/phpmyadmin/phpmyadmin/commit/45d6336b9004665738ae66af79d… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Relation.php Log Message: ----------- Ref #15247 - Remove `defined('TESTSUITE')` from Relation::setHistory Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: d1ed1a10d4610a4b6399be172faa4626e1af3e6e https://github.com/phpmyadmin/phpmyadmin/commit/d1ed1a10d4610a4b6399be172fa… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Util.php Log Message: ----------- Ref #15247 - Remove `defined('TESTSUITE')` from Util::date Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 8f77a9f29db9e797a23eff609c4851d3cfb86910 https://github.com/phpmyadmin/phpmyadmin/commit/8f77a9f29db9e797a23eff609c4… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/InsertEditTest.php Log Message: ----------- Ref #15247 - Remove `defined('TESTSUITE')` from ReplaceController and remove an exit Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 5f8bfbbae145db5a04f6394dd8ad425dd1767f17 https://github.com/phpmyadmin/phpmyadmin/commit/5f8bfbbae145db5a04f6394dd8a… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Header.php Log Message: ----------- Ref #16939 - Remove not used params from Header::getJsParams Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: fcd0a2393a42e1ef2baa9f2cf49f11364a348202 https://github.com/phpmyadmin/phpmyadmin/commit/fcd0a2393a42e1ef2baa9f2cf49… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/InsertEdit.php Log Message: ----------- Fix coding standard issues Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 4c879b925ab09bb6ff5dd68b8c13243b78e27450 https://github.com/phpmyadmin/phpmyadmin/commit/4c879b925ab09bb6ff5dd68b8c1… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M js/src/export.js Log Message: ----------- Ref #16939 - Remove Export.aliasSelectHandler not used since 4.7.2 Ref: 358d2fd1f1dca6bfb16fb415e76bb9b0b68f0499 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 2f59c9b3bee42577edd09d659df03b7c0db3cc79 https://github.com/phpmyadmin/phpmyadmin/commit/2f59c9b3bee42577edd09d659df… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M js/src/functions.js Log Message: ----------- Fix #16939 - Remove old code not used since 4.3 I could this code occurrences on 4.3 Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] 751d41: fixing the case-sensitive issue of innodb_file_format
by Fawzi E. Abdulfattah 14 Jul '21

14 Jul '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 751d415216aea238662a62bc0736d5cf17fc9e09 https://github.com/phpmyadmin/phpmyadmin/commit/751d415216aea238662a62bc073… Author: Fawzi E. Abdulfattah <iifawzie(a)gmail.com> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Operations.php Log Message: ----------- fixing the case-sensitive issue of innodb_file_format Signed-off-by: Fawzi E. Abdulfattah <iifawzie(a)gmail.com> Commit: f490ee886776d64bdd3aca87b5a63d748aaea85c https://github.com/phpmyadmin/phpmyadmin/commit/f490ee886776d64bdd3aca87b5a… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/InsertEdit.php Log Message: ----------- Fix a coding standard mistake Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: c81bb0ad394d74144c2fd1849572062926a82343 https://github.com/phpmyadmin/phpmyadmin/commit/c81bb0ad394d74144c2fd184957… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M js/src/common.js Log Message: ----------- Fix - do not try to process an empty common string, make more valid urls Before: index.php?&server=1 After: index.php?server=1 Using move and go to database feature Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: f724f648e1019976cbabbbff21d3a735ce58eba4 https://github.com/phpmyadmin/phpmyadmin/commit/f724f648e1019976cbabbbff21d… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Controllers/Table/OperationsController.php Log Message: ----------- Fix #16976 - Wrong link when a table is moved from a database to another Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 4fcbd2ae45a09f8240e95893d3c2d55545e5d172 https://github.com/phpmyadmin/phpmyadmin/commit/4fcbd2ae45a09f8240e95893d3c… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M libraries/classes/Operations.php Log Message: ----------- Merge #17013 - Fix #16985 - Fixing the case-sensitive issue of innodb_file_format Fixes: #16985 Pull-request: #17013 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 1692494643443c2b156b12ab37311a5bc6d88920 https://github.com/phpmyadmin/phpmyadmin/commit/1692494643443c2b156b12ab373… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M ChangeLog Log Message: ----------- Add ChangeLog entries for c81bb0ad394, #16976 and #16985 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: c830c1e93a6a4b668eca01664c29f776c066b8c5 https://github.com/phpmyadmin/phpmyadmin/commit/c830c1e93a6a4b668eca01664c2… Author: William Desportes <williamdes(a)wdes.fr> Date: 2021-07-15 (Thu, 07 July 2021) +02:00 Changed paths: M ChangeLog M js/src/common.js M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/InsertEdit.php M libraries/classes/Operations.php Log Message: ----------- Merge branch 'origin/QA_5_1' Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0